[gwt-contrib] Re: Remove JProgram.jsniMap in favor of local accounting. (issue1445801)

2011-05-10 Thread jbrosenberg
LGTM http://gwt-code-reviews.appspot.com/1445801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (left):

[gwt-contrib] Re: Log error instead of throwing when a generated unit cannot be transferred to a file. (issue1357804)

2011-05-10 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1357804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove JProgram.jsniMap in favor of local accounting. (issue1445801)

2011-05-10 Thread scottb
http://gwt-code-reviews.appspot.com/1445801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (left):

[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-10 Thread zundel
On 2011/05/03 18:57:36, scottb wrote: I mean only super-sourced. Does Object come through as 'com/google/gwt/emul/java/lang/Object.java' or merely 'java/lang/Object.java'? Sigh.. no. I just got this up in the debugger and saw that RerootedResource re-writes

[gwt-contrib] [google-web-toolkit] r10168 committed - Better error reporting. Also, move the proxy and request interfaces...

2011-05-10 Thread codesite-noreply
Revision: 10168 Author: rj...@google.com Date: Mon May 9 10:55:18 2011 Log: Better error reporting. Also, move the proxy and request interfaces to shared, where they belong — the servlet validates against them. Review at http://gwt-code-reviews.appspot.com/1444801 Review by:

[gwt-contrib] [google-web-toolkit] r10169 committed - Disabling test for null on getBrowserById for DOM elements without DTD...

2011-05-10 Thread codesite-noreply
Revision: 10169 Author: rchan...@google.com Date: Mon May 9 11:41:57 2011 Log: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 Review at http://gwt-code-reviews.appspot.com/1443801

[gwt-contrib] [google-web-toolkit] r10170 committed - See http://code.google.com/p/google-web-toolkit/issues/detail?id=6015...

2011-05-10 Thread codesite-noreply
Revision: 10170 Author: zun...@google.com Date: Tue May 10 03:27:54 2011 Log: See http://code.google.com/p/google-web-toolkit/issues/detail?id=6015 Log error instead of throwing when a generated unit cannot be transferred to a file, so that filenames exceeding file system limits

[gwt-contrib] [google-web-toolkit] r10171 committed - Remove JProgram.jsniMap in favor of local accounting....

2011-05-10 Thread codesite-noreply
Revision: 10171 Author: sco...@google.com Date: Tue May 10 05:59:20 2011 Log: Remove JProgram.jsniMap in favor of local accounting. http://gwt-code-reviews.appspot.com/1445801/ Review by: jbrosenb...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10171 Added:

[gwt-contrib] Re: Disabling test for null on getBrowserById for DOM elements without DTD when running on Chrome 12 (issue1443801)

2011-05-10 Thread rchandia
Submitted as of r10169 http://gwt-code-reviews.appspot.com/1443801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add styleName attribute to Grid (issue1441802)

2011-05-10 Thread rchandia
Mostly nits. http://gwt-code-reviews.appspot.com/1441802/diff/1/user/src/com/google/gwt/uibinder/elementparsers/GridParser.java File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right):

[gwt-contrib] Re: Add styleName attribute to Grid (issue1441802)

2011-05-10 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1441802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10172 committed - Add styleName attribute to Grid...

2011-05-10 Thread codesite-noreply
Revision: 10172 Author: tfisc...@google.com Date: Tue May 10 08:14:26 2011 Log: Add styleName attribute to Grid Review at http://gwt-code-reviews.appspot.com/1441802 Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10172 Modified:

[gwt-contrib] Re: Attachable elements in UiBinder: always run logicalAdd(Attachable) for Attachable widgets. (issue1446801)

2011-05-10 Thread rdcastro
LGTM http://gwt-code-reviews.appspot.com/1446801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. (issue1427810)

2011-05-10 Thread rchandia
Still bad content errors. Not fixed yet, it seems. On 2011/05/10 21:42:15, rchandia wrote: http://gwt-code-reviews.appspot.com/1427810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Decentralize nullmethod/nullfield (issue1442802)

2011-05-10 Thread scottb
Reviewers: cromwellian, jbrosenberg, Message: Helps with my GwtAstBuilder work. Please review this at http://gwt-code-reviews.appspot.com/1442802/ Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JField.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M

[gwt-contrib] Re: Pruner runs only once. (issue1436802)

2011-05-10 Thread scottb
This is ready for review now. http://gwt-code-reviews.appspot.com/1436802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors