[gwt-contrib] [google-web-toolkit] r10363 committed - Cherry pick of r10338, Add a compile-time check against provided UiFie...

2011-06-22 Thread codesite-noreply
Revision: 10363 Author: gwt.mirror...@gmail.com Date: Tue Jun 21 23:18:26 2011 Log: Cherry pick of r10338, Add a compile-time check against provided UiFields for RenderablePanel. http://code.google.com/p/google-web-toolkit/source/detail?r=10363 Modified:

[gwt-contrib] [google-web-toolkit] r10365 committed - Cherry picking r10341 into releases/2.4 for issue 6429

2011-06-22 Thread codesite-noreply
Revision: 10365 Author: zun...@google.com Date: Thu Jun 16 09:57:28 2011 Log: Cherry picking r10341 into releases/2.4 for issue 6429 http://code.google.com/p/google-web-toolkit/source/detail?r=10365 Modified:

[gwt-contrib] [google-web-toolkit] r10366 committed - Cherry-pick r10343 into GWT 2.4 branch.

2011-06-22 Thread codesite-noreply
Revision: 10366 Author: b...@google.com Date: Fri Jun 17 03:59:15 2011 Log: Cherry-pick r10343 into GWT 2.4 branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10366 Added: /releases/2.4/user/src/com/google/web/bindery/requestfactory/vm/testing

[gwt-contrib] [google-web-toolkit] r10367 committed - Integrate r10344 into GWT 2.4 branch.

2011-06-22 Thread codesite-noreply
Revision: 10367 Author: b...@google.com Date: Fri Jun 17 04:22:15 2011 Log: Integrate r10344 into GWT 2.4 branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10367 Modified: /releases/2.4/user/src/com/google/gwt/core/client/impl/WeakMapping.java

[gwt-contrib] [google-web-toolkit] r10368 committed - Integrate r10346 into GWT 2.4 branch.

2011-06-22 Thread codesite-noreply
Revision: 10368 Author: b...@google.com Date: Fri Jun 17 05:16:47 2011 Log: Integrate r10346 into GWT 2.4 branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10368 Modified: /releases/2.4/user/src/com/google/web/bindery/requestfactory/server/Resolver.java

[gwt-contrib] [google-web-toolkit] r10370 committed - Integrate r10342 into GWT 2.4 branch.

2011-06-22 Thread codesite-noreply
Revision: 10370 Author: rj...@google.com Date: Fri Jun 17 11:00:00 2011 Log: Integrate r10342 into GWT 2.4 branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10370 Modified: /releases/2.4/user/src/com/google/gwt/activity/shared/ActivityManager.java

[gwt-contrib] [google-web-toolkit] r10371 committed - Turns off creating archived modules for GWT 2.4 release....

2011-06-22 Thread codesite-noreply
Revision: 10371 Author: zun...@google.com Date: Mon Jun 20 15:02:05 2011 Log: Turns off creating archived modules for GWT 2.4 release. Review by: jbrosenb...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10371 Modified: /releases/2.4/user/build.xml

[gwt-contrib] [google-web-toolkit] r10373 committed - Integrate r10359 into GWT 2.4 branch.

2011-06-22 Thread codesite-noreply
Revision: 10373 Author: gwt.mirror...@gmail.com Date: Wed Jun 22 01:49:11 2011 Log: Integrate r10359 into GWT 2.4 branch. http://code.google.com/p/google-web-toolkit/source/detail?r=10373 Modified: /releases/2.4/user/src/com/google/web/bindery/autobean/shared/ValueCodex.java

[gwt-contrib] [google-web-toolkit] r10374 committed - Cherry picking r10362 into GWT 2.4 release

2011-06-22 Thread codesite-noreply
Revision: 10374 Author: zun...@google.com Date: Tue Jun 21 14:52:10 2011 Log: Cherry picking r10362 into GWT 2.4 release http://code.google.com/p/google-web-toolkit/source/detail?r=10374 Added: /releases/2.4/user/src/com/google/gwt/core/client/ScriptInjector.java

[gwt-contrib] [google-web-toolkit] r10375 committed - rollback of scriptInjector patch - problems found on some version of S...

2011-06-22 Thread codesite-noreply
Revision: 10375 Author: zun...@google.com Date: Wed Jun 22 01:14:16 2011 Log: rollback of scriptInjector patch - problems found on some version of Safari Review at http://gwt-code-reviews.appspot.com/1451818 http://code.google.com/p/google-web-toolkit/source/detail?r=10375

[gwt-contrib] RequestFactory annotation processor generates uncompilable code when there are nested proxies

2011-06-22 Thread Thomas Broyer
I'm trying to add a unit test for issue 5926 and I don't know how to deal with the TypeTokenResolver to easily run the test from within Eclipse. I enabled the requestfactory-apt.jar annotation processor on the gwt-user project and it generates a Java file that cannot be compiled, because it

[gwt-contrib] Switch on incremental compilation. (issue1461802)

2011-06-22 Thread scottb
Reviewers: zundel, Message: Looks ready to go! Please review this at http://gwt-code-reviews.appspot.com/1461802/ Affected files: M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java Index: dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java diff --git

[gwt-contrib] Remove the pre-GwtAstBuilder compile chain. (issue1465805)

2011-06-22 Thread scottb
Reviewers: jbrosenberg, zundel, Message: Going ahead and putting this out for review, but we'll just toggle the switch first and let the dust settle. Description: - WebModeCompilerFrontEnd - BuildTypeMap - GenerateJavaAST Please review this at http://gwt-code-reviews.appspot.com/1465805/

[gwt-contrib] Remove CompilationUnit.getSource() (issue1462807)

2011-06-22 Thread scottb
Reviewers: zundel, Description: Follow-on to: http://gwt-code-reviews.appspot.com/1465805/ Please review this at http://gwt-code-reviews.appspot.com/1462807/ Affected files: M dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java M

[gwt-contrib] Re: Add more TCK tests. (issue1467803)

2011-06-22 Thread rchandia
LGTM. With nits. http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java File user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java (right):

[gwt-contrib] Re: Fixing a bug in CellTree where refreshing an empty list of children causes an AssertionError tha... (issue1463805)

2011-06-22 Thread jlabanca
committed as r10353 http://gwt-code-reviews.appspot.com/1463805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds hooks to Widget reduce MVP boilerplate and enshrines the app-wide EventBus. (issue1449817)

2011-06-22 Thread jlabanca
Forgot to send these comments earlier. Ignore if they're too late. http://gwt-code-reviews.appspot.com/1449817/diff/4001/user/src/com/google/gwt/user/client/ui/IsEventSource.java File user/src/com/google/gwt/user/client/ui/IsEventSource.java (right):

[gwt-contrib] Re: Adding convenience methods to SafeStylesUtils and SafeStylesBuilder for style properties support... (issue1454808)

2011-06-22 Thread jlabanca
committed as r10356 http://gwt-code-reviews.appspot.com/1454808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add RequestFactory validator implemented as an annotation processor. (issue1467804)

2011-06-22 Thread bobv
Reviewers: pquislund_google.com, tbroyer, Message: This annotation processor will provide compile-time validation of RequestFactory interfaces. It produces red-squigglies in Eclipse on save. The plan is for this to replace the existing RequestFactoryInterfaceValidator by pre-generating all of

[gwt-contrib] [google-web-toolkit] r10376 committed - Fixing a bug in CellTree where pushing new data that renders to the sa...

2011-06-22 Thread codesite-noreply
Revision: 10376 Author: jlaba...@google.com Date: Wed Jun 22 06:01:15 2011 Log: Fixing a bug in CellTree where pushing new data that renders to the same content results in an invalid state where child are still attached to a stale parent. For example, consider a tree contains IDs

[gwt-contrib] Re: RequestFactory annotation processor generates uncompilable code when there are nested proxies

2011-06-22 Thread BobV
On Wed, Jun 22, 2011 at 4:57 AM, Thomas Broyer t.bro...@gmail.com wrote: I'm trying to add a unit test for issue 5926 and I don't know how to deal with the TypeTokenResolver to easily run the test from within Eclipse. I enabled the requestfactory-apt.jar annotation processor on the gwt-user

[gwt-contrib] Re: Add more TCK tests. (issue1467803)

2011-06-22 Thread nchalko
http://gwt-code-reviews.appspot.com/1467803/diff/1/user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java File user/test/com/google/gwt/validation/tck/ConstraintsGroupsGwtSuite.java (right):

Re: [gwt-contrib] Re: RequestFactory annotation processor generates uncompilable code when there are nested proxies

2011-06-22 Thread Thomas Broyer
On Wed, Jun 22, 2011 at 6:13 PM, BobV b...@google.com wrote: On Wed, Jun 22, 2011 at 4:57 AM, Thomas Broyer t.bro...@gmail.com wrote: I'm trying to add a unit test for issue 5926 and I don't know how to deal with the TypeTokenResolver to easily run the test from within Eclipse. I enabled the

[gwt-contrib] [google-web-toolkit] r10377 committed - Add more TCK tests....

2011-06-22 Thread codesite-noreply
Revision: 10377 Author: ncha...@google.com Date: Wed Jun 22 06:42:43 2011 Log: Add more TCK tests. [JSR 303 TCK Result] 143 of 257 (55.64%) Pass with 22 Failures and 8 Errors. Review at http://gwt-code-reviews.appspot.com/1467803 Review by: rchan...@google.com

[gwt-contrib] Re: RFC: ElementBuilder API (issue1455802)

2011-06-22 Thread jlabanca
There are a few constraints that led to the current API. First, there are dozens of element types, many of which have unique methods. Dumping all of these methods into one uber ElementBuilder would mean a class with hundreds of methods, and we would need a lot of runtime checks to ensure the

[gwt-contrib] Re: Fixing a bug in CellTree where pushing new data that renders to the same content results in an i... (issue1466803)

2011-06-22 Thread jlabanca
committed as r10376 http://gwt-code-reviews.appspot.com/1466803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove CompilationUnit.getSource() (issue1462807)

2011-06-22 Thread zundel
LGTM. Can't wait to see how this impacts size of CachedCompilationUnits! http://gwt-code-reviews.appspot.com/1462807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Switch on incremental compilation. (issue1461802)

2011-06-22 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1461802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Call getContentId to ensure the source has been read (issue1463803)

2011-06-22 Thread stephen . haberman
Note that getSource() is deprecated That's the getSource in CompilationUnit (which I saw the patch for--exciting stuff!). http://gwt-code-reviews.appspot.com/1463803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10378 committed - Ensure contentId is not null when creating a SourceFileCompilationUnit...

2011-06-22 Thread codesite-noreply
Revision: 10378 Author: zun...@google.com Date: Wed Jun 22 09:13:57 2011 Log: Ensure contentId is not null when creating a SourceFileCompilationUnit Patch by: stephen.haberman Review by: zundel Review at: http://gwt-code-reviews.appspot.com/1463803/

[gwt-contrib] Re: Update CompiledClass to use DiskCacheToken (issue1464801)

2011-06-22 Thread zundel
On 2011/06/17 16:28:14, stephenh wrote: Note that because CompiledClass doesn't have a serialVersionUID, this change causes deserialization exceptions against gwtars produced by the old code. Even though technically the serialization format is the same. Committed as r10364 Thanks for the

[gwt-contrib] Update client bundle result caching to track absent resources (issue1466804)

2011-06-22 Thread jbrosenberg
Reviewers: tobyr, zundel, Description: Update client bundle result caching to track absent resources Please review this at http://gwt-code-reviews.appspot.com/1466804/ Affected files: M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java M

[gwt-contrib] Re: Update client bundle result caching to track absent resources (issue1466804)

2011-06-22 Thread jbrosenberg
This change is to correctly respect the default extension search order for resources. So, for example, an image resource is first searched in the order: resourceName.png resourceName.jpg resourceName.gif This change makes sure we verify that if a resolved image is resourceName.jpg, that we

[gwt-contrib] Re: Update client bundle result caching to track absent resources (issue1466804)

2011-06-22 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/1466804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10379 committed - Switch on GWT incremental compilation....

2011-06-22 Thread codesite-noreply
Revision: 10379 Author: sco...@google.com Date: Wed Jun 22 13:09:08 2011 Log: Switch on GWT incremental compilation. http://gwt-code-reviews.appspot.com/1461802/ http://code.google.com/p/google-web-toolkit/source/detail?r=10379 Modified:

[gwt-contrib] Refactor LoadingStrategy for xsiframe linker and rename it to ScriptLoadingStrategy since it is ... (issue1468802)

2011-06-22 Thread unnurg
Reviewers: zundel, Description: Refactor LoadingStrategy for xsiframe linker and rename it to ScriptLoadingStrategy since it is not inherently tied to the xsiframe linker. Bring it more in line with the XhrLoadingStrategy and give them API compatibility so the xsiframe linker could use either

[gwt-contrib] Re: Refactor LoadingStrategy for xsiframe linker and rename it to ScriptLoadingStrategy since it is ... (issue1468802)

2011-06-22 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1468802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10380 committed - Temporary rollback of GwtAstBuilder enabling....

2011-06-22 Thread codesite-noreply
Revision: 10380 Author: zun...@google.com Date: Wed Jun 22 17:02:06 2011 Log: Temporary rollback of GwtAstBuilder enabling. *** Original change description *** Switch on GWT incremental compilation. http://gwt-code-reviews.appspot.com/1461802/

[gwt-contrib] Last change prevented re-loading modules, but caused it to write too many (issue1464803)

2011-06-22 Thread zundel
Reviewers: jbrosenberg, tobyr, Description: Last change prevented re-loading modules, but caused it to write too many modules out in an archive. Please review this at http://gwt-code-reviews.appspot.com/1464803/ Affected files: M dev/core/src/com/google/gwt/dev/CompileModule.java Index: