[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread rjrjr
I think LGTM, but could you help me understand CompositeEditor and CompositeEditor.Chain first? http://gwt-code-reviews.appspot.com/848801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java (right):

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread bobv
http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20 user/src/com/google/gwt/editor/client/CompositeEditor.java:20: * some other type. * An interface that

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread Ray Ryan
LGTM On Thu, Sep 9, 2010 at 12:04 PM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20