http://gwt-code-reviews.appspot.com/853801/diff/4001/5008
File user/test/com/google/gwt/dev/StrictModeTest.java (right):
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45
user/test/com/google/gwt/dev/StrictModeTest.java:45: private File
outDir;
The comment needs updating.
I
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008
File user/test/com/google/gwt/dev/StrictModeTest.java (right):
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45
user/test/com/google/gwt/dev/StrictModeTest.java:45: private File
outDir;
Strange, I don't see outDir
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008
File user/test/com/google/gwt/dev/StrictModeTest.java (right):
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45
user/test/com/google/gwt/dev/StrictModeTest.java:45: private File
outDir;
You're right. I'll delete it. I
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/853801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Those two changes are made now. It's ready for another round of review.
http://gwt-code-reviews.appspot.com/853801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Just nits, no need to re-review if you decide to fix them.
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008
File user/test/com/google/gwt/dev/StrictModeTest.java (right):
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45
High-level comments:
- CompilationState doesn't really need the extra API, because you can always
just iterate through the returned collection looking for errors. Arguably,
this would take a few extra cycles, but I've kinda been wanting to move the
error reporting out CompilationState anyway
