http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Okay, so here's my main issue with the general idea. As far as I can
tell, the lifetime of the 'storage' is the same as the lifetime of
generator instances.
I sort of see how it's expedient to have it accessible via
GeneratorContext... however, the downside is you give up static typing
and red
On 2010/09/02 13:44:49, scottb wrote:
Okay, so here's my main issue with the general idea. As far as I can
tell, the
lifetime of the 'storage' is the same as the lifetime of generator
instances.
I thought we agreed after discussing the previous patch for this that
the GeneratorContext was
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode88
dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:88: * com /
google / gwt / core /
I'll review the rest separately, but I wanted to get this to you first.
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode74
The i18n stuff looks good except where commented.
http://gwt-code-reviews.appspot.com/826802/diff/3001/4004
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/826802/diff/3001/4004#newcode402
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM for i18n parts.
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/826802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
11 matches
Mail list logo