[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-08 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread scottb
Okay, so here's my main issue with the general idea. As far as I can tell, the lifetime of the 'storage' is the same as the lifetime of generator instances. I sort of see how it's expedient to have it accessible via GeneratorContext... however, the downside is you give up static typing and red

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread conroy
On 2010/09/02 13:44:49, scottb wrote: Okay, so here's my main issue with the general idea. As far as I can tell, the lifetime of the 'storage' is the same as the lifetime of generator instances. I thought we agreed after discussing the previous patch for this that the GeneratorContext was

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread conroy
http://gwt-code-reviews.appspot.com/826802/diff/3001/4001 File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode88 dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:88: * com / google / gwt / core /

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread jat
I'll review the rest separately, but I wanted to get this to you first. http://gwt-code-reviews.appspot.com/826802/diff/3001/4001 File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4001#newcode74

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread jat
The i18n stuff looks good except where commented. http://gwt-code-reviews.appspot.com/826802/diff/3001/4004 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/826802/diff/3001/4004#newcode402

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-02 Thread jat
LGTM for i18n parts. http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix DevMode memory leaks by attaching cache lifetimes to the GeneratorContext (issue826802)

2010-09-01 Thread conroy
http://gwt-code-reviews.appspot.com/826802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors