[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
iframetest.html still looks weird. I'll assume it looks correct on your system. http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java File user/src/com/google/gwt/user/client/ui/Frame.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/17001/user/src/com/google/gwt/user/client/ui/Frame.java#newcode78

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-14 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-03-13 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-01-18 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-01-18 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002 File user/test/com/google/gwt/dom/client/FrameTests.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49 user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer timer = new Timer() { On

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-01-18 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-01-14 Thread pdr
http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug on IE where onload events don't fire for IFrames. (issue1294801)

2011-01-14 Thread jlabanca
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002 File user/test/com/google/gwt/dom/client/FrameTests.java (right): http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49 user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer timer = new Timer() { Do you need