Submitted as of r10210
On 2011/05/23 20:00:39, rjrjr wrote:
LGTM
Woot!
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
File
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
Rolled back at r10213
On 2011/05/24 15:31:52, rchandia wrote:
Submitted as of r10210
On 2011/05/23 20:00:39, rjrjr wrote:
LGTM
Woot!
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
File
PTAL
http://gwt-code-reviews.appspot.com/1442804/diff/7001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Nearly there, just a couple of nits. Thanks!
After this patch lands we're going to need to think harder about the
testing. The coverage introduced here is pretty light. E.g., we're not
reproducing any of the escaping checks (like the various
test*FunnyChars tests in UiBinderTest. I don't have an
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):
LGTM
Woot!
http://gwt-code-reviews.appspot.com/1442804/diff/10001/user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
File
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
(right):
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
PTAL. Smoke tests pass.
On 2011/05/13 19:16:42, rchandia wrote:
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1442804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
12 matches
Mail list logo