[gwt-contrib] Re: Teach Image about DataResource

2009-10-09 Thread bobv
LGTM. You could add an automatic test to at least verify that the DataResource returns something for getUrl(). http://gwt-code-reviews.appspot.com/77808/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/BundleWriter.java (right):

[gwt-contrib] Re: Teach Image about DataResource

2009-10-09 Thread rjrjr
Test added, checkstyle embarrassment fixed. I'll submit once the build has turned green. http://gwt-code-reviews.appspot.com/77808/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/BundleWriter.java (right): http://gwt-code-reviews.appspot.com/77808/diff/1/2#newcode63 Line 63:

[gwt-contrib] Re: Teach Image about DataResource

2009-10-09 Thread rjrjr
Committed r6341 http://gwt-code-reviews.appspot.com/77808 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---