[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-10 Thread bobv
lgtm. When the codegen code is hard to read, it's useful to add some example comments showing what the generated code might look at. It would pull up your code:comment ratio :-) http://gwt-code-reviews.appspot.com/831801/diff/7013/9009 File

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-10 Thread scottb
Thanks for the feedback. I'm in a good functional state, so I'm going to go ahead and commit this as-is, and add comments in a follow-up change. http://gwt-code-reviews.appspot.com/831801/diff/7013/9009 File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right):

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-09 Thread scottb
Fix for inaccessible types, and also fix a generics issue. http://gwt-code-reviews.appspot.com/831801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors