Re: [gPXE-devel] [PATCH] hierarchal friendly settings_ui

2010-07-09 Thread Glenn Brown
[This is a resend, since my previous send never reached the list...] Here are screen shots showing the result of the preceding patches. root_inherited.gif show the page reached by the config command with no option. Here, I scrolled down to a setting that is inherited from net1.nvo, to show

Re: [gPXE-devel] [PATCH] hierarchal friendly settings_ui

2010-07-09 Thread Glenn Brown
[This is a resend, since my previous send never reached the list...] Woops: I see the original reached the list archives. I've found and corrected the problem at my end. Sorry to spam the list. --Glenn ___ gPXE-devel mailing list

Re: [gPXE-devel] [PATCH][pcnet32] Fix pcnet32_wio_reset() bug

2010-07-09 Thread Stefan Hajnoczi
On Wed, Jul 7, 2010 at 2:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jul 7, 2010 at 1:43 PM, Andrei Faur da3d...@gmail.com wrote: This bug caused .probe to fail because the NIC did not reset properly. Looks good. Applied, thanks!

Re: [gPXE-devel] Weak pxe_menu_boot()

2010-07-09 Thread Stefan Hajnoczi
On Sat, Jul 3, 2010 at 6:47 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Here is the objdump -dr bin/autoboot.o output we want (using the glibc weak alias technique): 20e:   e8 fc ff ff ff          call   20f netboot+0xe2                        20f: R_386_PC32 printf  213:   89 f0          

Re: [gPXE-devel] Regression with embedded images

2010-07-09 Thread Marty Connor
Great, thanks Stefan. / Marty / Stefan Hajnoczi wrote on 7/9/10 1:28 AM: On Fri, Jul 9, 2010 at 2:15 AM, Marty Connorm...@etherboot.org wrote: Ah, ok, thanks Alessandro. That fix should be committed soon. I have it queued for the next ipxe-sync:

Re: [gPXE-devel] [PATCH] [virtio] Replace virtio-net with native gPXE driver

2010-07-09 Thread Thomas Miletich
Hello Stefan Here are a few comments: - virtnet_enqueue_iob: The address of the local variable 'header' is passed to vring_add_buf(). As you said on IRC, the hypervisor could access the data after 'header' went out of scope and 'header' could already be overwritten by something else. - We have

Re: [gPXE-devel] [PATCH] [virtio] Replace virtio-net with native gPXE driver

2010-07-09 Thread Stefan Hajnoczi
On Fri, Jul 9, 2010 at 12:48 PM, Thomas Miletich thomas.milet...@gmail.com wrote: Hello Stefan Here are a few comments: - virtnet_enqueue_iob: The address of the local variable 'header' is passed to vring_add_buf(). As you said on IRC, the hypervisor could access the data after 'header' went

Re: [gPXE-devel] Weak pxe_menu_boot()

2010-07-09 Thread Joshua Oreman
On Fri, Jul 9, 2010 at 3:29 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Richard Sandiford identified the issue: the compiler inlines pxe_menu_boot() because the symbol has visibility hidden.  From include/compiler.h: /* Force visibility of all symbols to hidden, i.e. inform gcc that  * all