Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Markus Neteler]

On Tue, Mar 29, 2016 at 4:08 PM, Pietro  wrote:
> On Tue, Mar 29, 2016 at 3:12 PM, Vaclav Petras  wrote:
>>
>> On Tue, Mar 29, 2016 at 5:33 AM, Pietro  wrote:
>>>
>>> I have fixed these errors, but since these changes are not fixing
>>> bugs, I've just reverted them. I will commit these change back to
>>> trunk as soon as we can start working on grass72.
>>
>>
>> I hope this won't become a common practice. I think trunk is where the
>> development happens. It is not a stable branch regardless of any plans.
>> Should I also revert all my non-bugfixes from last weeks? If needed, I can
>> certainly do that in the 7.2 release branch once thare is one. I just don't
>> see need to do this in trunk.
>
> Perhaps I miss-interpreted what Martin said to me in (Re: [GRASS-SVN]
> r68140 - in grass/trunk/scripts: d.correlate...):
>
> "personally I would wait with such changes to the moment when we will
> create releasebranch_7_2 (two months before planning 7.2. release. For
> now I would suggest to revert these changes from trunk. Any opinion?"
>
> no one reply on his question, and therefore I reverted. Perhaps I
> should wait longer...

Yes, I think so :-)

> What can I say is that it is quite challenging to maintain such large
> changes locally on my pc, with not possibility to commit smaller
> changes...

Indeed... I think that the changes are relevant for 7.2, so that
should be in trunk now to receive sufficient testing.
We are not in freeze nor anything else at time.

> Git+pull request, in this case, seems much more flexible.

Maybe, but IMHO this would be a different topic.

Markus
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Pietro]

On Tue, Mar 29, 2016 at 3:12 PM, Vaclav Petras  wrote:
>
> On Tue, Mar 29, 2016 at 5:33 AM, Pietro  wrote:
>>
>> I have fixed these errors, but since these changes are not fixing
>> bugs, I've just reverted them. I will commit these change back to
>> trunk as soon as we can start working on grass72.
>
>
> I hope this won't become a common practice. I think trunk is where the
> development happens. It is not a stable branch regardless of any plans.
> Should I also revert all my non-bugfixes from last weeks? If needed, I can
> certainly do that in the 7.2 release branch once thare is one. I just don't
> see need to do this in trunk.

Perhaps I miss-interpreted what Martin said to me in (Re: [GRASS-SVN]
r68140 - in grass/trunk/scripts: d.correlate...):

"personally I would wait with such changes to the moment when we will
create releasebranch_7_2 (two months before planning 7.2. release. For
now I would suggest to revert these changes from trunk. Any opinion?"

no one reply on his question, and therefore I reverted. Perhaps I
should wait longer...

What can I say is that it is quite challenging to maintain such large
changes locally on my pc, with not possibility to commit smaller
changes...

Git+pull request, in this case, seems much more flexible.

Pietro
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Martin Landa]

Hi,

2016-03-29 15:12 GMT+02:00 Vaclav Petras :
> I hope this won't become a common practice. I think trunk is where the
> development happens. It is not a stable branch regardless of any plans.
> Should I also revert all my non-bugfixes from last weeks? If needed, I can
> certainly do that in the 7.2 release branch once thare is one. I just don't
> see need to do this in trunk.

I think there is misunderstanding. The PEP 394 should part of
relbr_72, ASAIU. So we can apply them in trunk before relbr_72 will be
created from trunk or after but with backporting them. Ma

-- 
Martin Landa
http://geo.fsv.cvut.cz/gwiki/Landa
http://gismentors.cz/mentors/landa
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Vaclav Petras]

On Tue, Mar 29, 2016 at 5:33 AM, Pietro  wrote:

> I have fixed these errors, but since these changes are not fixing
> bugs, I've just reverted them. I will commit these change back to
> trunk as soon as we can start working on grass72.
>


I hope this won't become a common practice. I think trunk is where the
development happens. It is not a stable branch regardless of any plans.
Should I also revert all my non-bugfixes from last weeks? If needed, I can
certainly do that in the 7.2 release branch once thare is one. I just don't
see need to do this in trunk.
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Pietro]

Hi Vaclav,

On Fri, Mar 25, 2016 at 8:38 PM, Vaclav Petras  wrote:
> Nice! But please, check the tests:
>
> http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/gunittest/test_doctests/index.html
> http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/gunittest/test_gmodules/index.html
> http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/temporal/test_doctests/index.html

I have fixed these errors, but since these changes are not fixing
bugs, I've just reverted them. I will commit these change back to
trunk as soon as we can start working on grass72.

I've also fixed locally the temporal modules (to be importable in python3).
Therefore I was able to get the xml description for all the modules
under python3.

Since this morning I add the support to compile with both python2 and
python3 (this is another set of changes that are waiting for grass72).

Best regards

Pietro
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Vaclav Petras]

On Fri, Mar 25, 2016 at 2:14 AM, Pietro  wrote:

>
> I commit some changes in pygrass (r68138), temporal library (r68139)
> and GRASS scripts (r68140) that were on my trunk from a bit...



Nice! But please, check the tests:

http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/gunittest/test_doctests/index.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/gunittest/test_gmodules/index.html
http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2016-03-25-07-00/report_for_nc_basic_spm_grass7_nc/lib/python/temporal/test_doctests/index.html

It happened a just now:

http://fatra.cnr.ncsu.edu/grassgistests/summary_report/nc/index.html

Likely caused by those two commits:

https://trac.osgeo.org/grass/log/grass/trunk?action=stop_on_copy=stop_on_copy=68140_rev=68127=100
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Pietro]

On Thu, Mar 24, 2016 at 12:52 AM, Luca Delucchi  wrote:
> On 13 March 2016 at 10:52, Maris Nartiss  wrote:
>> I personally would like to see adoption of PEP8 and moving all python
>> code to be python3 ready. As old python versions are dying out, there
>> is less and less initiative to not do so.
>> Also related to
>> https://lists.osgeo.org/pipermail/grass-dev/2016-February/078828.html
>>
>
> I also have the same feeling, we should work to be python3 ready,
> maybe we could release 7.2 and start to work on it

I commit some changes in pygrass (r68138), temporal library (r68139)
and GRASS scripts (r68140) that were on my trunk from a bit...

At the moment the compile chain is not working on python3, so you have
to compile using python2 but then you can use GRASS with python3.
The issue with ctypes (#2708 [0]) is still valid, I've "locally" fixed
changing / with // only for the line: ('__val', c_ulong * (1024 / (8 *
sizeof(c_ulong

Of course, GRASS with python3 works only in text-mode, no gui.

All the best

Pietro

[0] https://trac.osgeo.org/grass/ticket/2708
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Luca Delucchi]

On 13 March 2016 at 10:52, Maris Nartiss  wrote:
> I personally would like to see adoption of PEP8 and moving all python
> code to be python3 ready. As old python versions are dying out, there
> is less and less initiative to not do so.
> Also related to
> https://lists.osgeo.org/pipermail/grass-dev/2016-February/078828.html
>

I also have the same feeling, we should work to be python3 ready,
maybe we could release 7.2 and start to work on it

> Māris.
>

my2cents

-- 
ciao
Luca

www.lucadelu.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Glynn Clements]

Maciej Sieczka wrote:

> What are the prospects, if any, for GRASS Python code to conform to
> https://www.python.org/dev/peps/pep-0394 ?
> 
> Not a huge issue to me personally. I'm just curious about GRASS team
> opinions on this matter. It might be worth considering. At least in the
> future, when more distros move to Python 3.

For now, this is best treated as a packaging issue, i.e. people making
binary packages for specific distributions should perform any fixup
required to make the package conform to the distribution's
requirements and conventions.

If this starts to become more common, then I'd suggest adding a
INSTALL_PYTHON variable to the build system which can be used
similarly to $(INSTALL) or $(INSTALL_DATA), which would replace the
shebang as part of the copying process.

-- 
Glynn Clements 
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Maris Nartiss]

I personally would like to see adoption of PEP8 and moving all python
code to be python3 ready. As old python versions are dying out, there
is less and less initiative to not do so.
Also related to
https://lists.osgeo.org/pipermail/grass-dev/2016-February/078828.html

Māris.


2016-03-12 22:56 GMT+02:00 Maciej Sieczka :
> Hi,
>
> What are the prospects, if any, for GRASS Python code to conform to
> https://www.python.org/dev/peps/pep-0394 ?
>
> Not a huge issue to me personally. I'm just curious about GRASS team
> opinions on this matter. It might be worth considering. At least in the
> future, when more distros move to Python 3.
>
> Maciek
> ___
> grass-dev mailing list
> grass-dev@lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/grass-dev
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev

[GRASS-dev] PEP 394 - The "python" Command on Unix-Like Systems

[Maciej Sieczka]

Hi,

What are the prospects, if any, for GRASS Python code to conform to
https://www.python.org/dev/peps/pep-0394 ?

Not a huge issue to me personally. I'm just curious about GRASS team
opinions on this matter. It might be worth considering. At least in the
future, when more distros move to Python 3.

Maciek
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev