[PATCH] Building on Ubuntu 7.10 x86-64

2007-11-10 Thread Vesa Jääskeläinen
Hi All, I needed to do following modification in order to build grub2 on my 64bit laptop. In case there is no complaints I will commit it to CVS. Additionally I needed to install gcc-multilib package (and normal packages like ruby, lzo...). And after that just doing following made runnable

Re: [PATCH] Avoid crash on empty menu

2007-11-10 Thread Christian Franke
Marco Gerards wrote: + e = get_entry (menu, boot_entry); + if (! e) + continue; /* menu is empty */ Please use proper interpunctions for comments. Fixed. Christian 2007-11-10 Christian Franke [EMAIL PROTECTED] * normal/menu.c (run_menu): Check for

Re: [PATCH] Fix grub-emu curses KEY_* mapping

2007-11-10 Thread Christian Franke
Marco Gerards wrote: Christian Franke [EMAIL PROTECTED] writes: Curses function keys do not work in grub-emu, this patch fixes this in grub_ncurses_getkey(). Ha! I once noticed this and forgot to document this bug :( Another approach would be to remove the scancode translation

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Christian Franke
Marco Gerards wrote: .. 2007-10-25 Christian Franke [EMAIL PROTECTED] * disk/host.c (grub_host_open): Add check for host. This fixes the problem that grub-emu does not find partitions. Please mention the attribute change. ... static grub_err_t -grub_host_open

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Christian Franke
Robert Millan wrote: On Fri, Nov 09, 2007 at 10:17:19PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote: static grub_err_t -grub_host_open (const char *name __attribute((unused)), grub_disk_t

[patch] Fix for vga terminal

2007-11-10 Thread Vesa Jääskeläinen
Hi All, Here is patch for fixing vga terminal. At least it worked fine on qemu. Now it uses only font system to get fonts so you need to load font module and use fonts. See gfxterm section on the wiki on how to do that. I had to edit patch by hand as 64bit patch is still pending and I need that

Re: [PATCH] fix serial console on LinuxBIOS

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: This patch fixes serial console on LinuxBIOS. I'd appreciate comments (specially on the grub/machine/machine.h addition). -- Robert

Re: PC partitions and big disks

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: On Fri, Nov 09, 2007 at 04:33:47PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: This should make the error much clearer when partition exceeds 2 TiB on a PC partition map (currently, all user gets is a out of partition

Re: grub2 efi patches

2007-11-10 Thread Marco Gerards
Alexandre Boeglin [EMAIL PROTECTED] writes: On Sun, 4 Nov 2007 00:06:31 +0100, Alexandre Boeglin [EMAIL PROTECTED] wrote: grub2_efi_chainloader_options.patch adds support for efi chainload options, it is not really beautiful (for instance, the ascii to utf16 conversion), but it works for

Re: grub2 efi patches

2007-11-10 Thread Marco Gerards
Alexandre Boeglin [EMAIL PROTECTED] writes: On Sun, 4 Nov 2007 01:21:24 +0100, Alexandre Boeglin [EMAIL PROTECTED] wrote: Le Sun, Nov 04, 2007 at 01:04:24AM +0100, Alexandre Boeglin a écrit : Sorry, there was a mistake in the previous one ... Oops, and line 91 of this one should be Hi,

Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Marco Gerards wrote: ... Add compile time assert to check packing. Can you remove the compile time assert? Done. We usually check stuff like this using configure. If you can send in a patch for configure.ac, that would be appreciated.

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Marco Gerards wrote: ... +static int +addr_is_valid (grub_addr_t addr) +{ + volatile unsigned char * p = (volatile unsigned char *)addr; Why volatile? I have the feeling it is not needed. + unsigned char x, y; + x = *p; + *p = x ^

Re: [PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Marco Gerards wrote: ... +static int +is_dir(const char *path, const char *name) is_dir ( OK. Too many projects, too many policies, sorry :-) np, don't worry :-) Hopefully you are not annoyed by my comments. A consistent style throughout

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Marco Gerards wrote: .. 2007-10-25 Christian Franke [EMAIL PROTECTED] * disk/host.c (grub_host_open): Add check for host. This fixes the problem that grub-emu does not find partitions. Please mention the attribute change. ...

Re: [PATCH] Add host open devicename check

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: On Fri, Nov 09, 2007 at 10:17:19PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote: static grub_err_t -grub_host_open (const char *name __attribute((unused)),

Re: Grub 2 functionality

2007-11-10 Thread Marco Gerards
Scott A Tovey [EMAIL PROTECTED] writes: Hi, I have two questions. 1. Will grub2 be taking over the hard drive recognition from the BIOS? It can be done, but it is not preferred. We are working on this. I believe that the Max OS X boots without using the BIOS hard drive IO. This allows

Re: How do I boot a standalone program in grub (a password checker via serial input) before allowing grub to continue booting?

2007-11-10 Thread Marco Gerards
CurlyCoconutTree [EMAIL PROTECTED] writes: How do I boot a standalone program in grub (1.95) (a password checker via serial input) before allowing grub to continue booting? I'm trying to develop a program that will run, stand alone or with the libraries Grub gives me access to, parse serial

Re: Outline menu

2007-11-10 Thread Marco Gerards
Markus Elfring [EMAIL PROTECTED] writes: Menu commands can have children already so you would get hierarchy information from there. Shortcut key you could just add as extra argument for menu, like --hotkey=1 Will an explanation of the data format be added to the wiki? In example: menu

Re: grub-setup: error: Non-sector-aligned data is found in the core file

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: On Thu, Nov 08, 2007 at 02:36:28PM +0200, UrJiZ wrote: On 11/7/07, Robert Millan [EMAIL PROTECTED] wrote: snip For building a floppy use grub-mkrescue instead. Used ./grub-mkrescue, but it: a) seems not to create a filesystem on the disk image

Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Unlike the other GRUB2 utils, grub-emu uses the glibc extension argp_parse(). It is unavailable on Cygwin, which might also be the case for other platforms where glibc is not the native runtime. This has been brought up before, BSD has the same

Re: [PATCH] Fixed ieee1275 console

2007-11-10 Thread Marco Gerards
Marcin Kurek [EMAIL PROTECTED] writes: Hell[o] Right, this is because it seems that the MSB is lost when writing a character to the screen. For the borders specific characters are used above 127 (non-ASCII). I wonder if the Pegasos console supports this ASCII extension if you change some

Re: Grub2 on a Macbook.

2007-11-10 Thread Marco Gerards
Isaac Dupree [EMAIL PROTECTED] writes: Eoin Hennessy wrote: Hello all, I've been taking a look at grub2 on an EFI Apple Macbook. I've installed a build from CVS HEAD and I can chainload grub.efi via the rEFIt loader. When grub loads I'm seeing the 'grub rescue' command prompt. As a test,

Re: pxebooting with GRUB 2

2007-11-10 Thread Marco Gerards
Daniel Kahn Gillmor [EMAIL PROTECTED] writes: On Sun 2007-09-30 12:07:38 -0400, Robert Millan wrote: WIP. Check latest mails from Marco on the subject. He sent patches implementing ethernet infrastructure and requested feedback. Ah, thanks. Are you referring to this, from two months ago?

Re: Strong Crypto Support for GRUB2

2007-11-10 Thread Marco Gerards
Simon Peter [EMAIL PROTECTED] writes: Hi, is my patch for strong crypto support going to make it into GRUB2 mainline? Sorry for keeping you waiting. I hope you are still interested in this; I am. Can you please send in your work as a patch+changelog to current CVS? Please make clear what

Re: [PATCH] generic ELF version of grub-mkimage

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: On Fri, Oct 12, 2007 at 05:55:03PM +0200, Robert Millan wrote: Ok. But no, I didn't really notice. I'll fix this entry and keep trying to get it right next time. Does this look good? This was committed, right? Otherwise poke me and I will look

Re: [PATCH] bug fix for the ntfs driver

2007-11-10 Thread Marco Gerards
Bean [EMAIL PROTECTED] writes: Hi, The problem is caused by the structure of compressed files. In ntfs, 16 clusters is the basic compressed unit. The original code assume that the file will break in 16 cluster long blocks, but in fact, the blocks will be merged if they are stored next to to

Re: Transparent decompression with file system filter

2007-11-10 Thread Marco Gerards
Bean [EMAIL PROTECTED] writes: Currently, grub2 support gziped file with the gzio module. To open a gziped file, you have to use a special function grub_gzfile_open, I think it could be better if grub_file_open could handle compressed file transparently. Are you still interested in working

Re: NTFS file system driver (update 4)

2007-11-10 Thread Marco Gerards
Bean [EMAIL PROTECTED] writes: On 8/3/07, Marco Gerards [EMAIL PROTECTED] wrote: Bean [EMAIL PROTECTED] writes: On 8/3/07, Marco Gerards [EMAIL PROTECTED] wrote: Bean [EMAIL PROTECTED] writes: If you make these two changes and send in the patch, I'll commit the patch. Ok,

Re: New command dump

2007-11-10 Thread Marco Gerards
Bean [EMAIL PROTECTED] writes: Hi, I have written a new command dump, it can hex dump content of file or memory. Great! usage: dump [-s skip] [-n length] { FILE | (mem) } The output look just like command hexdump. If you use (mem) as filename, it will dump physical memory instead of

Re: Using GRUB2 for booting from CD

2007-11-10 Thread Marco Gerards
Alex Roman [EMAIL PROTECTED] writes: Hi Alex, On 20/08/07, Robert Millan [EMAIL PROTECTED] wrote: I heard from Patrick Georgi on IRC (CCed) that he already has an ATAPI implementation for GRUB as part of his LinuxBIOS work. Maybe you should coordinate with him so that the code can be shared

Re: detecting other versions of SmartFirmware

2007-11-10 Thread Marco Gerards
Robert Millan [EMAIL PROTECTED] writes: 2007-09-05 Robert Millan [EMAIL PROTECTED] * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_test_flag): Detect SmartFirmware version updates (as released by Sven Luther), and avoid setting GRUB_IEEE1275_FLAG_NO_PARTITION_0 or

Re: [PATCH] Allow build without dirent.d_type, fix ls (host) crash

2007-11-10 Thread Christian Franke
Marco Gerards wrote: ... 2007-11-09 Christian Franke [EMAIL PROTECTED] * util/hostfs.c (is_dir): New function. (grub_hostfs_dir): Handle missing dirent.d_type case. (grub_hostfs_read): Add missing fseek(). (grub_hostfs_label): Clear label pointer. This fixes

Status of ATA support

2007-11-10 Thread Marco Gerards
Hi, A while ago I added support for ATA support. It wasn't complete yet, but I rather have this in CVS than rotting on my harddisk. Besides that, it isn't *that* bad. I will describe the outstanding issues below. First of all, this is mainly for i386-linuxbios. On i386-pc we have to disable

Improving the website about GRUB 2 development

2007-11-10 Thread Marco Gerards
Hi, On the website there is no information about how to send in patches (so improving in the title is a bit of an understatement ;)). I think we should add a page with information about patches that are sent in. That saves us some times to comment on obvious problems with a patch. But more

Re: [PATCH] Building on Ubuntu 7.10 x86-64

2007-11-10 Thread Marco Gerards
Vesa Jääskeläinen [EMAIL PROTECTED] writes: Hi Vesa, I needed to do following modification in order to build grub2 on my 64bit laptop. In case there is no complaints I will commit it to CVS. This looks ok to me. -- Marco ___ Grub-devel mailing

Re: [patch] Fix for vga terminal

2007-11-10 Thread Marco Gerards
Vesa Jääskeläinen [EMAIL PROTECTED] writes: Hi Vesa, Here is patch for fixing vga terminal. At least it worked fine on qemu. Now it uses only font system to get fonts so you need to load font module and use fonts. See gfxterm section on the wiki on how to do that. I had to edit patch by

Re: pxebooting with GRUB 2

2007-11-10 Thread Daniel Kahn Gillmor
On Sat 2007-11-10 12:25:10 -0500, Marco Gerards wrote: It will be committed soon, now for real ;-) Thanks for the followup. i await with bated breath; netboot is an important feature for me! Let me know if there's a patchset i can test at some point as an end user. Sorry i don't have the

Re: Layout testing for graphical menu

2007-11-10 Thread Marco Gerards
Vesa Jääskeläinen [EMAIL PROTECTED] writes: Hi, I was hoping that someone else might stand-up but as there wasn't really interest I made a draft. This is basically using Okuji's idea of using CSS for specifying look. I made HTML page and example CSS filling information. And of course it

Re: Standalone problem to test syntax rules

2007-11-10 Thread Marco Gerards
Bean [EMAIL PROTECTED] writes: In the tarball? Yes. Could you send the files to the list as attachments? Or whatever is relevant. tarballs on a mailinglist are very inconvenient. :-/ -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] Building on Ubuntu 7.10 x86-64

2007-11-10 Thread Vesa Jääskeläinen
Marco Gerards wrote: Vesa Jääskeläinen [EMAIL PROTECTED] writes: Hi Vesa, I needed to do following modification in order to build grub2 on my 64bit laptop. In case there is no complaints I will commit it to CVS. This looks ok to me. Committed. New configure was also generated, so

[PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE)

2007-11-10 Thread Christian Franke
HAVE_ASM_USCORE is checked by configure, but module loader does not work in this case. This patch fixes this by ignoring the difference. It actually works to load modules compiled on Linux by a kernel compiled on Cygwin (with underscores) and vice versa. It also prepares the

Re: Improving the website about GRUB 2 development

2007-11-10 Thread Vesa Jääskeläinen
Marco Gerards wrote: Hi, On the website there is no information about how to send in patches (so improving in the title is a bit of an understatement ;)). I think we should add a page with information about patches that are sent in. That saves us some times to comment on obvious problems

Re: GRUB 2 development

2007-11-10 Thread Vesa Jääskeläinen
Marco Gerards wrote: Hi, As you all might have noticed, I have been spamming this list like crazy the last two days :-) The problem currently is that, accidently, we lose track of outstanding bugs and patches. It is frustrating to both developers and people sending in

Re: Status of ATA support

2007-11-10 Thread Vesa Jääskeläinen
Marco Gerards wrote: First of all, this is mainly for i386-linuxbios. On i386-pc we have to disable biosdisk support because ata.mod and biosdisk.mod do not like eachother :-). Perhaps disk access via the BIOS will not be possible/safe anymore after loading ata.mod. We have to make sure we

Re: GRUB 2 development

2007-11-10 Thread Jordi Mallach
On Sat, Nov 10, 2007 at 06:53:51PM +0100, Marco Gerards wrote: Hopefully we can start using a bug tracker soon. There are many that are good. In my opinion the mailinglist and wiki doesn't work for us anymore. If we have a bug tracker, bugs and patches won't be forgotted until we actively

Re: Standalone problem to test syntax rules

2007-11-10 Thread Gregg Levine
On Nov 10, 2007 1:43 PM, Marco Gerards [EMAIL PROTECTED] wrote: Bean [EMAIL PROTECTED] writes: In the tarball? Yes. Could you send the files to the list as attachments? Or whatever is relevant. tarballs on a mailinglist are very inconvenient. :-/ -- Marco

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

2007-11-10 Thread Christian Franke
Marco Gerards wrote: Christian Franke [EMAIL PROTECTED] writes: ... volatile is necessary here to tell the complier that the memory address might not behave like regular memory. Otherwise, the optimizer might legitimately remove memory accesses and then constant propagation detects an

Re: [PATCH] bug fix for the ntfs driver

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 06:31:09PM +0100, Marco Gerards wrote: Sorry for forgetting about this patch. It should be committed. Robert, if you have time, can you commit this? I will mark this mail as important... If you don't have the time, I will surely commit it ASAP :-) Done. --

Re: detecting other versions of SmartFirmware

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 06:46:28PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: 2007-09-05 Robert Millan [EMAIL PROTECTED] * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_test_flag): Detect SmartFirmware version updates (as released by Sven

Re: [PATCH] generic ELF version of grub-mkimage

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 06:29:12PM +0100, Marco Gerards wrote: Robert Millan [EMAIL PROTECTED] writes: On Fri, Oct 12, 2007 at 05:55:03PM +0200, Robert Millan wrote: Ok. But no, I didn't really notice. I'll fix this entry and keep trying to get it right next time. Does this

Re: [PATCH] Avoid crash on empty menu

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 04:27:28PM +0100, Marco Gerards wrote: 2007-11-10 Christian Franke [EMAIL PROTECTED] * normal/menu.c (run_menu): Check for empty menu to avoid crash. (grub_menu_run): Likewise. This looks ok to me. We can apply this now, it's just a few line.

Re: Status of ATA support

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 09:21:38PM +0200, Vesa Jääskeläinen wrote: Marco Gerards wrote: First of all, this is mainly for i386-linuxbios. On i386-pc we have to disable biosdisk support because ata.mod and biosdisk.mod do not like eachother :-). Perhaps disk access via the BIOS will not be

Re: GRUB 2 development

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 06:53:51PM +0100, Marco Gerards wrote: The problem currently is that, accidently, we lose track of outstanding bugs and patches. It is frustrating to both developers and people sending in patches/bugreports. Hopefully we can start using a bug tracker soon. There

Re: Improving the website about GRUB 2 development

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 07:19:34PM +0100, Marco Gerards wrote: If we put this on a website in a friendly and attractive way, we might get more contributions. Getting more contributions sounds nice; but can we cope with them? I think it's more important to make sure we can properly (and

Re: [PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE)

2007-11-10 Thread Robert Millan
On Sat, Nov 10, 2007 at 08:03:57PM +0100, Christian Franke wrote: This patch fixes this by ignoring the difference. It actually works to load modules compiled on Linux by a kernel compiled on Cygwin (with underscores) and vice versa. [...] + + /* Ignore leading underscore used for C

serial port

2007-11-10 Thread Robert Millan
Hi Any reason why the serial port is not enabled in grub_serial_init() ? grub terminal Available terminal(s): console Current terminal: console grub serial grub terminal Available terminal(s): serial console Current terminal: serial -- Robert Millan GPLv2 I know my rights; I want my phone