Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-20 Thread Peter Jones
On Tue, Feb 20, 2018 at 03:51:59PM +0100, Daniel Kiper wrote: > On Wed, Jan 31, 2018 at 11:27:00AM -0500, Peter Jones wrote: > > This way debuginfo built from the .module will still include this > > information, but the final result won't have the data we don't actually > > need in the modules,

Re: [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-20 Thread Peter Jones
On Tue, Feb 20, 2018 at 03:48:44PM +0100, Daniel Kiper wrote: > On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote: > > +static int > > +SUFFIX (is_kept_section) (Elf_Shdr *s, const struct > > grub_install_image_target_desc *image_target); > > +static int > > +SUFFIX

[PATCH v2 2/3] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-20 Thread Peter Jones
Some versions of gcc include a plugin called "annobin", and in some build systems this is enabled by default. This plugin creates special ELF note sections to track which ABI-breaking features are used by a binary, as well as a series of relocations to annotate where. If grub is compiled with

[PATCH v2 1/3] mkimage: refactor a bunch of section data into a struct.

2018-02-20 Thread Peter Jones
This basically moves a bunch of the section information we pass around a lot into a struct, and passes a pointer to a single one of those instead. Because it's more convenient, it also puts the section_vaddresses calculations in locate_section(), which no longer returns the allocation for

[PATCH v2 3/3] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-20 Thread Peter Jones
This way debuginfo built from the .module will still include this information, but the final result won't have the data we don't actually need in the modules, either on-disk, loaded at runtime, or in prebuilt images. Signed-off-by: Peter Jones --- grub-core/genmod.sh.in | 4

Re: [PATCH] ieee1275: add nvme support within ofpath

2018-02-20 Thread Daniel Kiper
On Tue, Feb 20, 2018 at 09:57:14AM -0800, Eric Snowberg wrote: > Add NVMe support within ofpath. > > The Open Firmware text representation for a NVMe device contains the > Namespace ID. An invalid namespace ID is one whose value is zero or whose > value is greater than the value reported by the

Re: [PATCH] Make pmtimer tsc calibration not take 51 seconds to fail.

2018-02-20 Thread Daniel Kiper
On Mon, Feb 19, 2018 at 05:37:56PM -0500, Peter Jones wrote: > On my laptop running at 2.4GHz, if I run a VM where tsc calibration > using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds > to do so (as measured with the stopwatch on my phone), with a tsc delta > of 0x1cd1c85300,

[PATCH] ieee1275: add nvme support within ofpath

2018-02-20 Thread Eric Snowberg
Add NVMe support within ofpath. The Open Firmware text representation for a NVMe device contains the Namespace ID. An invalid namespace ID is one whose value is zero or whose value is greater than the value reported by the Number of Namespaces (NN) field in the Identify Controller data structure.

Re: [GRUB PARTUUID PATCH V5 2/3] Add PARTUUID detection support to grub-probe

2018-02-20 Thread Daniel Kiper
On Sun, Feb 04, 2018 at 11:47:36AM -0800, Nicholas Vinson wrote: > Add PARTUUID detection support grub-probe for MBR and GPT partition > schemes. The Linux kernel supports mounting the root filesystem by > Linux device name or by the Partition [GU]UID. GRUB's mkconfig, > however, currently only

Re: [GRUB PARTUUID PATCH V5 3/3] Update grub script template files

2018-02-20 Thread Daniel Kiper
On Sun, Feb 04, 2018 at 11:47:37AM -0800, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documenation. As earlier lack of SOB. Otherwise LGTM. Daniel ___ Grub-devel

Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints

2018-02-20 Thread Daniel Kiper
On Sun, Feb 04, 2018 at 11:47:35AM -0800, Nicholas Vinson wrote: > To help clean the code and simplify the code in util/grub-probe.c, this > patch renames grub_gpt_part_type to grub_gpt_part_guid and updates > grub_gpt_partentry to use this type for both the partition type GUID > string and the

Re: [PATCH] libgcrypt: Import replacement CRC operations

2018-02-20 Thread Daniel Kiper
On Sun, Feb 11, 2018 at 12:18:12AM +, Colin Watson wrote: > The CRC implementation imported from libgcrypt 1.5.3 is arguably > non-free, due to being encumbered by the restrictive Internet Society > licence on RFCs (see e.g. https://wiki.debian.org/NonFreeIETFDocuments). > Fortunately,

Re: [PATCH] x86-64: Treat R_X86_64_PLT32 as R_X86_64_PC32

2018-02-20 Thread Daniel Kiper
On Sat, Feb 17, 2018 at 06:47:28AM -0800, H.J. Lu wrote: > Starting from binutils commit bd7ab16b4537788ad53521c45469a1bdae84ad4a: > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=bd7ab16b4537788ad53521c45469a1bdae84ad4a > > x86-64 assembler generates R_X86_64_PLT32, instead of

Re: [PATCH v2] chainloader: Fix wrong break condition (must be AND not, OR)

2018-02-20 Thread Daniel Kiper
On Mon, Feb 19, 2018 at 03:26:35PM +0100, C. Masloch wrote: > The definition of bpb's num_total_sectors_16 and num_total_sectors_32 > is that either the 16-bit field is non-zero and is used (in which case > eg mkfs.fat sets the 32-bit field to zero), or it is zero and the > 32-bit field is used.

Re: LiMux GRUB-Patches

2018-02-20 Thread Max Harmathy
Hi Adrian! Thank you for the reply! Am 13.02.2018 um 11:02 schrieb John Paul Adrian Glaubitz: > Did you actually try setting a password without patch GRUB2? We > just added the following to /etc/grub.d/40_custom: > > #!/bin/sh > exec tail -n +3 $0 > # This file provides an easy way to add

Re: [PATCH 2/2] .mod files: Strip annobin annotations and .eh_frame, and their relocations

2018-02-20 Thread Daniel Kiper
On Wed, Jan 31, 2018 at 11:27:00AM -0500, Peter Jones wrote: > This way debuginfo built from the .module will still include this > information, but the final result won't have the data we don't actually > need in the modules, either on-disk, loaded at runtime, or in prebuilt > images. > >

Re: [PATCH 1/2] mkimage: avoid copying relocations for sections that won't be copied.

2018-02-20 Thread Daniel Kiper
On Wed, Jan 31, 2018 at 11:26:59AM -0500, Peter Jones wrote: > Some versions of gcc include a plugin called "annobin", and in some > build systems this is enabled by default. This plugin creates special > ELF note sections to track which ABI-breaking features are used by a > binary, as well as a