Re: [PATCH] commands/file: Fix array/enum desync

2021-02-26 Thread Daniel Kiper
On Fri, Feb 26, 2021 at 12:05:07PM -0600, Derek Foreman wrote: > commit f1957dc8a3347278a095bc8f44197662559a8ba3 added two entries to the > options array, but only 1 entry to the enum. This resulted in everything > after the insertion point being off by one. > > This broke at least the 'file

Re: [PATCH] loader/linux: Remove redundant code from in grub_cmd_linux()

2021-02-26 Thread Daniel Kiper
On Mon, Jan 11, 2021 at 11:04:51AM +0800, Tianjia Zhang wrote: > `preferred_address` has been assigned to GRUB_LINUX_BZIMAGE_ADDR > during initialization in grub_cmd_linux(). The assignment here > is redundant and should be removed. > > Signed-off-by: Tianjia Zhang Reviewed-by: Daniel Kiper

Re: [PATCH] loader/linux: Fix type error for reference variable

2021-02-26 Thread Daniel Kiper
On Mon, Jan 11, 2021 at 11:04:36AM +0800, Tianjia Zhang wrote: > `relocatable` is defined as type grub_uint8_t, this is also > one byte definition in linux boot protocol. by semantic > definition, it is a bool type. It is not appropriate to > treat it as a four bytes, this patch fix this issue. >

Re: [RESEND PATCH 1/1] efi: device-tree must be in EfiACPIReclaimMemory

2021-02-26 Thread Daniel Kiper
On Fri, Jan 29, 2021 at 04:32:29PM +0100, Heinrich Schuchardt wrote: > According to the Embedded Base Boot Requirements (EBBR) specification the > device-tree passed to Linux as a configuration table must reside in > EfiACPIReclaimMemory. > > Signed-off-by: Heinrich Schuchardt Reviewed-by:

Re: [PATCH 1/1] lsefisystab: short text for EFI_RT_PROPERTIES_TABLE_GUID

2021-02-26 Thread Daniel Kiper
On Fri, Jan 29, 2021 at 05:55:51PM +0100, Heinrich Schuchardt wrote: > UEFI specification 2.8 errata B introduced the EFI_RT_PROPERTIES_TABLE > describing the services available at runtime. > > The lsefisystab command is used to display installed EFI configuration > tables. Currently it only shows

[PATCH] commands/file: Fix array/enum desync

2021-02-26 Thread Derek Foreman
commit f1957dc8a3347278a095bc8f44197662559a8ba3 added two entries to the options array, but only 1 entry to the enum. This resulted in everything after the insertion point being off by one. This broke at least the 'file --is-hibernated-hiberfil' command. Bring the two back in sync by splitting

Re: bug #60114: The "Backspace" key doesn't work correctly in the superuser authentication prompt.

2021-02-26 Thread Daniel Kiper
On Fri, Feb 26, 2021 at 02:53:47PM +0300, Egor Ignatov wrote: > Hi, yesterday I submitted a bug report about wrong backspace key behavior in > superuser login prompt and I finally found it. So I attach patch with my fix > so it can be merged into upstream. > > >From

Re: [PATCH v3 1/1] docs: luks2: Mention key derivation function support

2021-02-26 Thread Daniel Kiper
Sorry for huge delay but I am very busy... On Fri, Feb 12, 2021 at 08:07:00AM +0100, Petr Vorel wrote: > To give users hint why Argon2 (the default in cryptsetup for LUKS2) > does not work. > > Reviewed-by: Patrick Steinhardt > Acked-by: Paul Menzel > Signed-off-by: Petr Vorel This should be

Re: [PATCH v2 0/7] Add xHCI USB support

2021-02-26 Thread Glenn Washburn
Good day Patrick, On Wed, 24 Feb 2021 07:46:48 +0100 Patrick Rudolph wrote: > Hi Glenn, > yes it's the same patch series, but has been cleaned and improved a > lot. I've addressed most of the comments received earlier. I see that I implied that you hadn't and I didn't mean to. I only meant to

bug #60114: The "Backspace" key doesn't work correctly in the superuser authentication prompt.

2021-02-26 Thread Egor Ignatov
Hi, yesterday I submitted a bug report about wrong backspace key behavior in superuser login prompt and I finally found it. So I attach patch with my fix so it can be merged into upstream. >From a227f1a2c54aa420e016ffb5ca1c41fe93a2bd68 Mon Sep 17 00:00:00 2001 From: Egor Ignatov Date: Fri, 26