Re: [PATCH] Fixed ieee1275 console

2007-11-18 Thread Marco Gerards
"Marcin Kurek" <[EMAIL PROTECTED]> writes: Hi, >> I prefer if it can be detected if this is Efika or for example an >> apple implementation of OF and handle these characters depending on >> that. IIRC this code does work on the apple, but unfortunately I >> cannot check this anymore. > > Attache

Re: [PATCH] Fixed ieee1275 console

2007-11-18 Thread Marco Gerards
"Marcin Kurek" <[EMAIL PROTECTED]> writes: Hi Marcin, > Finaly I found a few free minutes to look at ofconsole as it never > correctly work for me. There was 3 problems on my Pegasos: :-) > 1) Backspace key not works with USB keyboard. It does with PS/2? Are you sure this fix works on apple f

Re: [PATCH] Fixed ieee1275 console

2007-11-18 Thread Marco Gerards
"Marcin Kurek" <[EMAIL PROTECTED]> writes: Hi, >> Can you provide something that makes use of that? > > Hmm, I should have example code somewhere on disk. I will try to find it. :-) >> Will do :-) > > I already send e-mail to fsf today as there was no reply to my previous > e-mail. Great! --

Re: [PATCH] Fixed ieee1275 console

2007-11-11 Thread Marcin Kurek
Hell[o] > Can you provide something that makes use of that? Hmm, I should have example code somewhere on disk. I will try to find it. > Will do :-) I already send e-mail to fsf today as there was no reply to my previous e-mail. -- --- Marcin 'Morgoth' Kurek --- _

Re: [PATCH] Fixed ieee1275 console

2007-11-10 Thread Marco Gerards
"Marcin Kurek" <[EMAIL PROTECTED]> writes: > Hell[o] > >> Right, this is because it seems that the MSB is lost when writing a >> character to the screen. For the borders specific characters are used >> above 127 (non-ASCII). I wonder if the Pegasos console supports this >> ASCII extension if you

Re: [PATCH] Fixed ieee1275 console

2007-10-15 Thread Marcin Kurek
Hell[o] > I prefer if it can be detected if this is Efika or for example an > apple implementation of OF and handle these characters depending on > that. IIRC this code does work on the apple, but unfortunately I > cannot check this anymore. Attached current console patchset. The graphical frame

Re: [PATCH] Fixed ieee1275 console

2007-10-12 Thread Marcin Kurek
Hell[o] > Right, this is because it seems that the MSB is lost when writing a > character to the screen. For the borders specific characters are used > above 127 (non-ASCII). I wonder if the Pegasos console supports this > ASCII extension if you change some settings or so... The problem is in f

Re: [PATCH] Fixed ieee1275 console

2007-10-11 Thread Marco Gerards
"Marcin Kurek" <[EMAIL PROTECTED]> writes: Hi Marcin, Sorry for the late reply. I have been absent for quite a while, but I intend to go over the emails on this list during the weekend (including yours). I noticed this email because I worked on this problem myself, so that is why I am replying

Re: [PATCH] Fixed ieee1275 console

2007-10-11 Thread Robert Millan
On Wed, Oct 10, 2007 at 11:57:44PM +0200, Marcin Kurek wrote: > > In your code there's a condition in which _serial is set to 0 and _fb is > > left unset (as 0). Is this intended? Sounds like a bug. > > Not this is not a bug. We can heve 3 cases here: > > 1) True serial console. In this case r

Re: [PATCH] Fixed ieee1275 console

2007-10-10 Thread Marcin Kurek
Hell[o] > Caught you! ;-) Holy shit. Lesson one take one more look at diff before send it :) > I know it seems burdensome, but please can you split this in three patches, > one > for each fix? Then it's easier to review just one and say "this is good", and > also easier to figure out why every

Re: [PATCH] Fixed ieee1275 console

2007-10-10 Thread Robert Millan
On Wed, Oct 10, 2007 at 05:11:13PM +0200, Marcin Kurek wrote: > Hell[o] > > > Avoid the cosmetical changes! (there are more thorough the patch) > > Arghh, I was sure I removed it :/ Anyway attached updated console patches. Great, thank you. > diff -urN grub2.org/term/ieee1275/ofconsole.c grub2/

Re: [PATCH] Fixed ieee1275 console

2007-10-10 Thread Marcin Kurek
Hell[o] > Avoid the cosmetical changes! (there are more thorough the patch) Arghh, I was sure I removed it :/ Anyway attached updated console patches. 01-grub2-simple_console.patch: Cleanups only. Should have no more "cosmetical" changes inside. 04-grub2-ofconsole_fix.patch: Added detection of

Re: [PATCH] Fixed ieee1275 console

2007-10-04 Thread Robert Millan
On Thu, Oct 04, 2007 at 01:33:25AM +0200, Marcin Kurek wrote: > diff -urN grub2.org/include/grub/term.h grub2/include/grub/term.h > --- grub2.org/include/grub/term.h 2007-07-22 01:32:22.0 +0200 > +++ grub2/include/grub/term.h 2007-10-01 19:20:49.734330521 +0200 > @@ -51,10 +51,13 @@ >

Re: [PATCH] Fixed ieee1275 console

2007-10-03 Thread Marcin Kurek
Hell[o] Attached current version of console fix'es patches, generaly synced with cvs && cleanups for all of them and some changes in 04-grub2-ofconsole_fix.patch. First it seems pegasos OF uses 24 lines console by default, but it seems when no framebuffer is used the real number of rows is 25 not

Re: [PATCH] Fixed ieee1275 console

2007-10-02 Thread Robert Millan
On Mon, Oct 01, 2007 at 09:43:27PM +0200, Marcin Kurek wrote: > Hell[o] > > > Is this a bitmask? In this case, looks like you aren't using the right > > numbers. Now GRUB_TERM_SIMPLE_MENU == GRUB_TERM_DUMB | GRUB_TERM_NO_EDIT > > OTOH if that's what you intended, I think it's better to build one

Re: [PATCH] Fixed ieee1275 console

2007-10-01 Thread Marcin Kurek
Hell[o] > Is this a bitmask? In this case, looks like you aren't using the right > numbers. Now GRUB_TERM_SIMPLE_MENU == GRUB_TERM_DUMB | GRUB_TERM_NO_EDIT > OTOH if that's what you intended, I think it's better to build one macro > using the others. Eeeek, why ? The flags are checked using 'fl

Re: [PATCH] Fixed ieee1275 console

2007-10-01 Thread Robert Millan
On Mon, Oct 01, 2007 at 08:14:16PM +0200, Marcin Kurek wrote: > diff -urN grub2.org/include/grub/term.h grub2/include/grub/term.h > --- grub2.org/include/grub/term.h 2007-07-22 01:32:22.0 +0200 > +++ grub2/include/grub/term.h 2007-10-01 19:20:49.734330521 +0200 > @@ -51,10 +51,13 @@ >

Re: [PATCH] Fixed ieee1275 console

2007-10-01 Thread Marcin Kurek
Hell[o] > [...] OK, split fixes in to separate patches this time as requested. 01-grub2-simple_console.patch == This is a idea how to handle ascii&&cp473&&utf based menus for diffrent consoles. I added a two term flags GRUB_TERM_SIMPLE_MENU (ascii menu) and GRUB_TERM_CP4

Re: [PATCH] Fixed ieee1275 console

2007-10-01 Thread Robert Millan
On Mon, Oct 01, 2007 at 12:57:35PM +0200, Marcin Kurek wrote: > Hell[o] > > Finaly I found a few free minutes to look at ofconsole as it never > correctly work for me. There was 3 problems on my Pegasos: > > 1) Backspace key not works with USB keyboard. > 2) menu looks ugly like hell as it contai

Re: [PATCH] Fixed ieee1275 console

2007-10-01 Thread Robert Millan
On Mon, Oct 01, 2007 at 12:57:35PM +0200, Marcin Kurek wrote: > 2) menu looks ugly like hell as it contains some random characters in > place of borders. I have a few concerns about this part: > static void > grub_ofconsole_putchar (grub_uint32_t c) > { > - char chr = c; > - if (c == '\n') >