Re: PCI support

2008-02-02 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 31, 2008 at 09:51:38AM +0100, Marco Gerards wrote: >> > >> > grub_uint32_t >> > grub_inl (grub_uint32_t *addr) >> > { >> > return *addr; >> > } >> >> Nothing, except the missing volatile I guess. This just isn't an IO >> port. So you can

Re: PCI support

2008-01-31 Thread Robert Millan
On Thu, Jan 31, 2008 at 09:51:38AM +0100, Marco Gerards wrote: > > > > grub_uint32_t > > grub_inl (grub_uint32_t *addr) > > { > > return *addr; > > } > > Nothing, except the missing volatile I guess. This just isn't an IO > port. So you can't use IO port 0x60 to access the keyboard or so. > Bu

Re: PCI support

2008-01-31 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 30, 2008 at 11:17:49PM +0100, Marco Gerards wrote: >> >> IO addresses are Intel only, AFAIK. Almost all architectures have >> >> mmapped IO. It's really arch specific. >> > >> > Are you sure that makes grub_inl / grub_outl arch-specific ?

Re: PCI support

2008-01-30 Thread Robert Millan
On Wed, Jan 30, 2008 at 11:17:49PM +0100, Marco Gerards wrote: > >> IO addresses are Intel only, AFAIK. Almost all architectures have > >> mmapped IO. It's really arch specific. > > > > Are you sure that makes grub_inl / grub_outl arch-specific ? They can't be > > implemented as wrappers for dir

Re: PCI support

2008-01-30 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 30, 2008 at 09:08:34PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote: >> >> Marco Gerards <[EMAIL PROTECTED]> writes: >> >> >> >> > 2009-01-28

Re: PCI support

2008-01-30 Thread Robert Millan
On Wed, Jan 30, 2008 at 09:08:34PM +0100, Marco Gerards wrote: > Robert Millan <[EMAIL PROTECTED]> writes: > > > On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote: > >> Marco Gerards <[EMAIL PROTECTED]> writes: > >> > >> > 2009-01-28 Marco Gerards <[EMAIL PROTECTED]> > >> > > >> >

Re: PCI support

2008-01-30 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote: >> Marco Gerards <[EMAIL PROTECTED]> writes: >> >> > 2009-01-28 Marco Gerards <[EMAIL PROTECTED]> >> > >> >* bus/pci.c: New file. >> > >> >* include/grub/pci.h: Likewise. >> > >> >

Re: PCI support

2008-01-30 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Wednesday 30 January 2008 18:57, Marco Gerards wrote: >> No objections? Did everyone have a (quick) look at the interfaces? >> >> If I hear nothing, I will commit this patch Friday. > > You didn't check the return value from a hook. Besides th

Re: PCI support

2008-01-30 Thread Yoshinori K. Okuji
On Wednesday 30 January 2008 18:57, Marco Gerards wrote: > No objections? Did everyone have a (quick) look at the interfaces? > > If I hear nothing, I will commit this patch Friday. You didn't check the return value from a hook. Besides that, okay for me. Thanks, Okuji

Re: PCI support

2008-01-30 Thread Robert Millan
On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote: > Marco Gerards <[EMAIL PROTECTED]> writes: > > > 2009-01-28 Marco Gerards <[EMAIL PROTECTED]> > > > > * bus/pci.c: New file. > > > > * include/grub/pci.h: Likewise. > > > > * include/grub/i386/pc/pci.h: Likewise. > > > >

Re: PCI support

2008-01-30 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: > 2009-01-28 Marco Gerards <[EMAIL PROTECTED]> > > * bus/pci.c: New file. > > * include/grub/pci.h: Likewise. > > * include/grub/i386/pc/pci.h: Likewise. > > * commands/lspci.c: Likewise. > > * conf/i386-pc.rmk (pkglib_MODUL

Re: PCI support

2008-01-29 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 28, 2008 at 07:32:33PM +0100, Marco Gerards wrote: >> > --- qemu-0.9.0+20070816/hw/pc.c~2007-06-06 18:26:13.0 +0200 >> > +++ qemu-0.9.0+20070816/hw/pc.c 2008-01-28 18:25:00.0 +0100 >> > @@ -676,6 +676,8 @@ >> > qe

Re: PCI support

2008-01-28 Thread Robert Millan
On Mon, Jan 28, 2008 at 07:32:33PM +0100, Marco Gerards wrote: > > --- qemu-0.9.0+20070816/hw/pc.c~2007-06-06 18:26:13.0 +0200 > > +++ qemu-0.9.0+20070816/hw/pc.c 2008-01-28 18:25:00.0 +0100 > > @@ -676,6 +676,8 @@ > > qemu_irq *cpu_irq; > > qemu_irq *i8259; > > >

Re: PCI support

2008-01-28 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 28, 2008 at 03:03:33PM +0100, Marco Gerards wrote: >> >> I wanted to wait with this patch until the ATA driver is adapted. But >> I won't have time for that this week. So I can better get this >> committed and people working on this ;-).

Re: PCI support

2008-01-28 Thread Robert Millan
On Mon, Jan 28, 2008 at 03:03:33PM +0100, Marco Gerards wrote: > > I wanted to wait with this patch until the ATA driver is adapted. But > I won't have time for that this week. So I can better get this > committed and people working on this ;-). There is some code for ATA, > but it was not test

PCI support

2008-01-28 Thread Marco Gerards
Hi, Here is a patch that allows you to iterate over PCI devices. The file pci.c adds a function to iterate over the devices and a function to generate an address to query the PCI device. Furthermore, there is a function to actually access the hardware, which is machine specific. I only implement

[patch 3/3] PCI support (simple test driver)

2006-05-16 Thread vincent guffens
And here comes the last part, this test driver detects the ne2000 card in qemu. 2006-05-16 Vincent Guffens <[EMAIL PROTECTED]> * drivers/net/: New directory. * conf/i386-pc.rmk (pkgdata_MODULES): Added test_driver.mod to the list of modules. (test_driver_mod_S

[patch 2/3] PCI support (implementation from etherboot)

2006-05-16 Thread vincent guffens
grub_pci_io_support_etherboot.read_config_dword(dev, PCI_ROM_ADDRESS, &romaddr); + romaddr >>= 10; + dev->romaddr = romaddr; + + /* Get the ``membase'' */ +

[patch 1/3] PCI support (abstract interface)

2006-05-16 Thread vincent guffens
Hello, Here is a patch to add pci support to grub2. 2006-05-16 Vincent Guffens <[EMAIL PROTECTED]> * drivers/: New directory * conf/i386-pc.rmk (pkgdata_MODULES): Added pci.mod to the list of modules. (DRIVERS_CFLAGS): Added. (pci_mod_S

Re: pci support

2006-05-06 Thread Marco Gerards
vincent guffens <[EMAIL PROTECTED]> writes: >>>As I understand, supporting the etherboot drivers is no longer the >>>primary option. As it is out of the question to have its own set of >>>driver, the UNDI driver seems like a good idea. However, UNDI support >>>would constrain significantly the de

Re: pci support

2006-05-06 Thread vincent guffens
Marco Gerards wrote: > vincent guffens <[EMAIL PROTECTED]> writes: > > >>Marco Gerards wrote: >> >>>vincent guffens <[EMAIL PROTECTED]> writes: >>> >>>Hi Vincent, >>> >>> >>> >>>>I was won

Re: pci support

2006-05-06 Thread Marco Gerards
vincent guffens <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> vincent guffens <[EMAIL PROTECTED]> writes: >> >> Hi Vincent, >> >> >>>I was wondering if there was still an interest in pci support as >>>discussed previous

Re: pci support

2006-05-06 Thread vincent guffens
Marco Gerards wrote: > vincent guffens <[EMAIL PROTECTED]> writes: > > Hi Vincent, > > >>I was wondering if there was still an interest in pci support as >>discussed previously. That is a general interface exported by a module >>such as > > >

Re: pci support

2006-05-06 Thread Marco Gerards
vincent guffens <[EMAIL PROTECTED]> writes: Hi Vincent, > I was wondering if there was still an interest in pci support as > discussed previously. That is a general interface exported by a module > such as Yes, that will make it possible to implement all kinds of drivers and make

Re: pci support

2006-05-06 Thread Vesa Jääskeläinen
vincent guffens wrote: > Hi! > > I was wondering if there was still an interest in pci support as > discussed previously. That is a general interface exported by a module > such as Yes there is, in example PCI support would be enable usage of more ATA Controllers than legacy por

pci support

2006-05-06 Thread vincent guffens
Hi! I was wondering if there was still an interest in pci support as discussed previously. That is a general interface exported by a module such as struct grub_pci_support { /* My name. */ const char *name; void (*init)(void); void (*fini)(void); void (*adjust) (grub_pci_device_t p