[PATCH 2/2] Cryptomount support key files

From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase Signed-off-by: Denis 'GNUtoo' Carikli --- grub-core/disk/cryptodisk.c | 46 - grub-core/disk/geli.c | 4 +++- grub-core/disk/luks.c | 44

[PATCH 1/2] Cryptomount support LUKS detached header

From: John Lane Signed-off-by: John Lane gnu...@cyberdimension.org: rebase Signed-off-by: Denis 'GNUtoo' Carikli --- grub-core/disk/cryptodisk.c | 22 ++ grub-core/disk/geli.c | 7 -- grub-core/disk/luks.c | 45 ++---

Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

On Tue, Feb 18, 2020 at 10:39:07PM -0500, Nicholas Vinson wrote: > On 2/18/20 19:32, Peter Jones wrote: > > On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: > > > On 2/4/20 16:02, Peter Jones wrote: > > > > grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be > >

Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2

On Fri, Feb 21, 2020 at 01:26:20PM +0100, Daniel Kiper wrote: > On Thu, Feb 20, 2020 at 07:00:48PM +0100, Patrick Steinhardt wrote: > > One thing I'm not sure about here is whether it's fine to declare the > > argon2 mod's license as GPLv3. The code is licensed under CC0/Apache > > 2.0, where the

Re: [PATCH v2 6/6] luks2: Support key derival via Argon2

On Thu, Feb 20, 2020 at 07:00:54PM +0100, Patrick Steinhardt wrote: > One addition with LUKS2 was support of the key derival function Argon2 > in addition to the previously supported PBKDF2 algortihm. In order to > ease getting in initial support for LUKS2, we only reused infrastructure > to

Re: [PATCH v2 5/6] luks2: Discern Argon2i and Argon2id

On Thu, Feb 20, 2020 at 07:00:53PM +0100, Patrick Steinhardt wrote: > While GRUB is already able to parse both Argon2i and Argon2id parameters > from the LUKS2 header, it doesn't discern both types. This commit > introduces a new KDF type for Argon2id and sets up the parsed KDF's type >

Re: [PATCH v2 3/6] argon2: Import Argon2 from cryptsetup

On Thu, Feb 20, 2020 at 07:00:51PM +0100, Patrick Steinhardt wrote: > In order to support the Argon2 key derival function for LUKS2, we > obviously need to implement Argon2. It doesn't make a lot of sense to > hand-code any crypto, which is why this commit instead imports Argon2 > from the

Re: ZFS grubenv write support

On Fri, Feb 21, 2020 at 11:14:25AM +0100, Javier Martinez Canillas wrote: > On 1/17/20 1:10 PM, Daniel Kiper wrote: > > Hi Paul, > > > > [snip] > > > > > In general I like the idea. Though I would like to have this > > configurable by user if possible (some FSes may support traditional > > grubenv

Re: [PATCH v2 2/6] types.h: add UINT-related macros needed for Argon2

On Thu, Feb 20, 2020 at 07:00:50PM +0100, Patrick Steinhardt wrote: > For the upcoming import of the Argon2 library, we need the macros > GRUB_UINT32_MAX, GRUB_UINT32_C and GRUB_UINT64_C. Add them as a > preparatory step. > > Signed-off-by: Patrick Steinhardt > --- > include/grub/types.h | 8

Re: [PATCH v2 0/6] Support Argon2 KDF in LUKS2

Hi Patrick, On Thu, Feb 20, 2020 at 07:00:48PM +0100, Patrick Steinhardt wrote: > Hi, > > this is the second version of my patchset to add support for Argon2 > encryption keys for LUKS2. > > The most important change is that I've now verbosely imported the argon2 > code from the official

Re: [PATCH 1/2] build: Move TARGET_* assignments earlier

Adding John and Eric... On Wed, Feb 19, 2020 at 10:51:41PM -0800, Matt Turner wrote: > From: Mike Gilbert > > On a 32-bit SPARC userland, configure fails to compile assembly and the > build fails: > > checking for options to compile assembly... configure: error: could not > compile assembly

Re: ZFS grubenv write support

On 1/17/20 1:10 PM, Daniel Kiper wrote: > Hi Paul, > [snip] > > In general I like the idea. Though I would like to have this > configurable by user if possible (some FSes may support traditional > grubenv and special regions for boot loaders). I would also take into > account Luiz's comments.