Re: Grub2 EFI: compatibility with wimboot

2018-06-20 Thread Daniel Kiper
On Fri, Jun 15, 2018 at 07:14:29PM +0200, jame88f...@gmx.de wrote: > Okay, > wimboot works in Grub2 Legacy for example: > > # Successfully boots > menuentry "Windows 7" { > set ISOpath="/img/windows_7.iso" > loopback loop $ ISOpath > linux16 /boot/wimboot/wimboot > initrd16

Re: Grub2 EFI: compatibility with wimboot

2018-06-21 Thread Daniel Kiper
On Wed, Jun 20, 2018 at 05:27:23PM +0200, jame88f...@gmx.de wrote: > No it is windows UEFI 64bit on a UEFI 64bit platform Great! > it doesn't matter anyway because even if I try to boot only Wimboot EFI from > Grub2 EFI without parameters I also get a blackscreen. > > I mean: > > menuentry "Windo

Re: [PATCH v2] ieee1275: obdisk driver

2018-06-21 Thread Daniel Kiper
On Fri, Jun 15, 2018 at 09:58:56AM -0600, Eric Snowberg wrote: > > On Jun 15, 2018, at 6:02 AM, Daniel Kiper wrote: > > On Wed, May 30, 2018 at 04:55:22PM -0700, Eric Snowberg wrote: [...] > >> +static struct grub_scsi_test_unit_ready tur = &g

Re: Grub2 EFI: compatibility with wimboot

2018-06-23 Thread Daniel Kiper
On Thu, Jun 21, 2018 at 06:34:41PM +0200, jame88f...@gmx.de wrote: > Hello, > the problem is that with this method you can only load a wim file. > I have several windows ISOs that should boot separately. > Of course it would be really nice if you could load wimboot EFI with > parameters directly vi

Re: GRUB multiboot_elfxx.c issue

2018-07-02 Thread Daniel Kiper
On Mon, Jul 02, 2018 at 01:39:32PM +0200, Denis 'GNUtoo' Carikli wrote: > On Mon, 2 Jul 2018 15:21:05 +0500 > yanvasilij yan wrote: > > > Hello! > Hi, > > > I suppose there is error > > in ./grub-core/loader/multiboot_elfxx.c in 130 line. Becose of it I > > get a error: > > > > loader/multiboot_el

Re: [PATCH] i386/linux: add support for ext_lfb_base

2018-07-02 Thread Daniel Kiper
On Fri, Jun 29, 2018 at 12:18:29PM +, Nath, Arindam wrote: > > -Original Message- > > From: Arindam Nath On Behalf Of Arindam Nath > > Sent: Wednesday, June 27, 2018 8:26 PM > > To: grub-devel@gnu.org > > Cc: Nath, Arindam > > Subject: [PATCH] i386/linux: add support for ext_lfb_base

Re: TPM support within Grub2

2018-07-02 Thread Daniel Kiper
Hi Daniel, On Sun, Jul 01, 2018 at 07:09:30PM -0400, Daniel P. Smith wrote: > Greetings, > > I have a measured boot implementation I have been working on that > introduces a DRTM relocator that I would like to eventually upstream. > This work does rely on the ability to access a TPM 1.2 chip from

Re: [PATCH] grub-setup: debug message cleanup

2018-07-04 Thread Daniel Kiper
On Tue, Jul 03, 2018 at 06:51:13PM +0800, Cao jin wrote: > variable "root" is initialized after root device probing, and is null in > current place, so, drop it. > > Signed-off-by: Cao jin Reviewed-by: Daniel Kiper If there are no objections I will apply this in

Re: [PATCH 0/2] use arm*/linux.h for file command

2018-07-04 Thread Daniel Kiper
On Mon, Jun 25, 2018 at 06:01:27PM +0100, Leif Lindholm wrote: > We now have pretty, architecture-safe, structs and macros for > kernel image headers and magic values. Use this to get rid of > some hardcoding in the "file" command. Reviewed-by: Daniel Kiper If there are n

Re: [PATCH] EFI: console: Fix the "enter" key not working on X86 tablets

2018-07-04 Thread Daniel Kiper
rub-menu entry using the buttons on the tablet. > > Signed-off-by: Hans de Goede Reviewed-by: Daniel Kiper If there are no objections I will apply this in a week or so. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 1/6] efi: add central copy of grub_efi_find_mmap_size

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:15PM +0100, Leif Lindholm wrote: > There are several implementations of this function in the tree. > Add a central version in grub-core/efi/mm.c. I am happy with the code itself but I am not sure why you are not replacing these "several implementations of this functio

Re: [PATCH v3 2/6] efi: add grub_efi_get_ram_base() function for arm64

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:16PM +0100, Leif Lindholm wrote: > Since ARM platforms do not have a common memory map, add a helper > function that finds the lowest address region with the EFI_MEMORY_WB > attribute set in the UEFI memory map. > > Required for the arm64 efi linux loader to restrict t

Re: [PATCH v3 3/6] arm64 linux loader: rename functions and macros and move to common headers

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:17PM +0100, Leif Lindholm wrote: > In preparation for using the linux loader for 32-bit and 64-bit platforms, > rename grub_arm64*/GRUB_ARM64* to grub_efi*/GRUB_EFI*. > > Move prototypes for now-common functions to efi/efi.h. > > Signed-off-by: Leif Lindholm > --- >

Re: [PATCH v3 4/6] arm/efi: switch to arm64 linux loader

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:18PM +0100, Leif Lindholm wrote: > Switch over to the EFI-stub aware arm64 loader for 32-bit ARM platforms. Hmmm... Does it mean that ARM64 EFI stub can work on 32-bit ARM platforms? Daniel ___ Grub-devel mailing list Grub

Re: [PATCH v3 5/6] arm: delete unused efi support from loader/arm

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:19PM +0100, Leif Lindholm wrote: > The 32-bit arm efi port now shares the 64-bit linux loader, so delete > the now unused bits from the 32-bit linux loader. > > This in turn leaves the grub-core/kern/arm/efi/misc.c unused, so > delete that too. > > Signed-off-by: Leif

Re: [PATCH v3 6/6] efi: restrict arm/arm64 linux loader initrd placement

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 06:17:20PM +0100, Leif Lindholm wrote: > The 32-bit arm Linux kernel is built as a zImage, which self-decompresses > down to near start of RAM. In order for an initrd/initramfs to be > accessible, it needs to be placed within the first ~768MB of RAM. > The initrd loader buil

Re: [PATCH v3 1/6] efi: add central copy of grub_efi_find_mmap_size

2018-07-06 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 05:21:17PM +0100, Leif Lindholm wrote: > On Fri, Jul 06, 2018 at 05:00:45PM +0200, Daniel Kiper wrote: > > On Wed, Jun 27, 2018 at 06:17:15PM +0100, Leif Lindholm wrote: > > > There are several implementations of this function in the tree. > > &g

Re: [PATCH v3 4/6] arm/efi: switch to arm64 linux loader

2018-07-06 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 05:30:59PM +0100, Leif Lindholm wrote: > On Fri, Jul 06, 2018 at 05:48:21PM +0200, Daniel Kiper wrote: > > On Wed, Jun 27, 2018 at 06:17:18PM +0100, Leif Lindholm wrote: > > > Switch over to the EFI-stub aware arm64 loader for 32-bit ARM platforms. >

Re: Patch: allow the 'python' used to run gentpl.py to be configured

2018-07-06 Thread Daniel Kiper
On Wed, Jul 04, 2018 at 10:08:53AM -0700, Adam Williamson wrote: > gentpl.py is python2/3-agnostic, but there's no way to cause it > to be run with any interpreter other than 'python', it's just > hard-coded into Makefile.common that way. Adjust that to allow > a make variable PYTHONBIN to be set t

Re: Compatibility with Bootmgr

2018-07-06 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 08:44:15AM +, Nguy?n T? wrote: > Hi, > > Some users have reported that they have problems booting WinPE from > Grub2. Specifically, you will not see anything other than the current > background image. In the most recent case, the screen shows ripples > when booting Windo

Re: Where does grub receive initial screen settings?

2018-07-06 Thread Daniel Kiper
On Wed, Jul 04, 2018 at 08:33:00AM -0500, David Wyckoff wrote: > Good day and howdy, > > I am interested in knowing how grub gets its initial screen size. > The example: > > insert live cd (et al) > install distro > install grub to mbr --- > > Does grub get it's initial framebuffer/screen settin

Re: [PATCH] i386/linux: add support for ext_lfb_base

2018-07-06 Thread Daniel Kiper
On Wed, Jun 27, 2018 at 08:25:41PM +0530, Arindam Nath wrote: > The EFI Graphics Output Protocol can return a 64-bit > linear frame buffer address in some firmware/BIOS > implementations. We currently only store the lower > 32-bits in the lfb_base. This will eventually be > passed to Linux kernel a

Re: [PATCH v3 1/6] efi: add central copy of grub_efi_find_mmap_size

2018-07-06 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 06:13:30PM +0100, Leif Lindholm wrote: > On Fri, Jul 06, 2018 at 06:55:51PM +0200, Daniel Kiper wrote: > > On Fri, Jul 06, 2018 at 05:21:17PM +0100, Leif Lindholm wrote: > > > On Fri, Jul 06, 2018 at 05:00:45PM +0200, Daniel Kiper wrote: > > > &

Re: Patch: allow the 'python' used to run gentpl.py to be configured

2018-07-09 Thread Daniel Kiper
On Fri, Jul 06, 2018 at 01:19:18PM -0700, Adam Williamson wrote: > On Fri, 2018-07-06 at 19:25 +0200, Daniel Kiper wrote: > > On Wed, Jul 04, 2018 at 10:08:53AM -0700, Adam Williamson wrote: > > > gentpl.py is python2/3-agnostic, but there's no way to cause it > > >

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-07-09 Thread Daniel Kiper
On Sun, Jul 08, 2018 at 05:51:37PM +0200, Goffredo Baroncelli wrote: > A gentle ping. Sorry for delay. I remember about this patchset but I am swamped with other stuff. I will take a look at it this week. Daniel ___ Grub-devel mailing list Grub-devel@

Re: V/v: Compatibility with Bootmgr

2018-07-10 Thread Daniel Kiper
On Tue, Jul 10, 2018 at 01:09:23AM +, Nguy???n T??? wrote: > Sorry, > > Grub2 configfile: > > ntldr /bootmgr What kind of Windows do you use? Which GRUB2 version do you use? Could you try the latest one from the git tree? Daniel ___ Grub-devel mail

Re: [PATCH v4 0/6] efi: arm linux loader unification and correctness

2018-07-10 Thread Daniel Kiper
On Mon, Jul 09, 2018 at 06:32:59PM +0100, Leif Lindholm wrote: > The existing linux loader for 32-bit ARM is really only a piggy-back > on the U-Boot loader, and for UEFI it's entirely possible to reuse > the same loader across multiple architectures. > > This set will stop the ability to boot non-

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-11 Thread Daniel Kiper
On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke > the build on i386-efi - genmoddep.awk bails out with message > grub_reboot in reboot is duplicated in kernel > This is because both lib/i386/reset.c and kern/efi/ef

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-12 Thread Daniel Kiper
On Wed, Jul 11, 2018 at 12:53:01PM +0100, Leif Lindholm wrote: > On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > > On Mon, Jul 09, 2018 at 07:49:06PM +0100, Leif Lindholm wrote: > > > Commit 0ba90a7f0178 ("efi: Move grub_reboot() into kernel") broke

Re: [PATCH] i386/linux: add support for ext_lfb_base (v2)

2018-07-12 Thread Daniel Kiper
On Thu, Jul 12, 2018 at 03:09:12PM +0530, Arindam Nath wrote: > From: Arindam Nath > > v2: changes suggested by Daniel > > - added #if defined (GRUB_MACHINE_EFI) && defined (__x86_64__) > - moved constant definitions to the beginning of header file > > v1: This should go... > The EFI Graphic

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 07:39:48PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 70 > 1 file changed, 70 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH 2/9] btrfs: Add helper to check the btrfs header.

2018-07-12 Thread Daniel Kiper
Otherwise, Reviewed-by: Daniel Kiper You can add it to the next patch release if you do not change anything except above listed things. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 07:39:50PM +0200, Goffredo Baroncelli wrote: > The caller knows better if this error is fatal or not, i.e. another disk is > available or not. > > This is a preparatory patch. > > Signed-off-by: Goffredo Baroncelli Reviewed-by: Dan

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 08:22:19PM +0200, Goffredo Baroncelli wrote: > Forward because this patch still doesn't reach the mailing list Could you fix that somehow? It is confusing. > -- > > If a device is not found, record this failure by storing NULL in > data-

Re: [PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

2018-07-12 Thread Daniel Kiper
tor the code inside > the for(;;) into an another function. > > Signed-off-by: Goffredo Baroncelli Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 6/9] btrfs: Refactor the code that read from disk

2018-07-12 Thread Daniel Kiper
isk logic. > Refactoring this code increases the general readability too. > > This is a preparatory patch, to help the adding of the RAID 5/6 recovery > code. > > Signed-off-by: Goffredo Baroncelli Otherwise, Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 07:39:54PM +0200, Goffredo Baroncelli wrote: > Add support for recovery for a RAID 5 btrfs profile. In addition > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 177 +

Re: [PATCH 8/9] btrfs: Make more generic the code for RAID 6 rebuilding

2018-07-12 Thread Daniel Kiper
segment. > This is not true for the btrfs code. In order to reuse the native > grub_raid6_recover() code, it is modified to not call > grub_diskfilter_read_node() directly, but to call an handler passed > as an argument. > > Signed-off-by: Goffredo Baroncelli R

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-07-12 Thread Daniel Kiper
On Tue, Jun 19, 2018 at 07:39:56PM +0200, Goffredo Baroncelli wrote: > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the md RAID 6 code already > present in grub. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Daniel Kiper
On Thu, Jul 12, 2018 at 12:52:49PM +0100, Leif Lindholm wrote: > On Thu, Jul 12, 2018 at 01:44:36PM +0200, Daniel Kiper wrote: > > On Wed, Jul 11, 2018 at 12:53:01PM +0100, Leif Lindholm wrote: > > > On Wed, Jul 11, 2018 at 01:03:12PM +0200, Daniel Kiper wrote: > > > &

Re: [PATCH v3] i386/linux: add support for ext_lfb_base

2018-07-13 Thread Daniel Kiper
On Thu, Jul 12, 2018 at 07:02:49PM +0530, Arindam Nath wrote: > From: Arindam Nath > > Signed-off-by: Arindam Nath > --- > Cc: Daniel Kiper > --- > v1: > > The EFI Graphics Output Protocol can return a 64-bit > linear frame buffer address in some firmware/BIOS &

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-13 Thread Daniel Kiper
On Fri, Jul 13, 2018 at 01:53:52PM +0100, Leif Lindholm wrote: > On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > > > > (i386_)ieee1275 implements its own grub_reboot(), so that should be > > > > > fine. (This does mean that i386_ieee1275 may curr

Re: TPM support within Grub2

2018-07-16 Thread Daniel Kiper
On Mon, Jul 02, 2018 at 06:35:08PM +0200, Daniel Kiper wrote: > Hi Daniel, > > On Sun, Jul 01, 2018 at 07:09:30PM -0400, Daniel P. Smith wrote: > > Greetings, > > > > I have a measured boot implementation I have been working on that > > introduces a DRTM relocato

Re: [PATCH v2] ieee1275: obdisk driver

2018-07-16 Thread Daniel Kiper
Sorry for late reply but I was busy with other stuff. On Thu, Jun 21, 2018 at 01:46:46PM -0600, Eric Snowberg wrote: > > On Jun 21, 2018, at 10:58 AM, Daniel Kiper wrote: > > On Fri, Jun 15, 2018 at 09:58:56AM -0600, Eric Snowberg wrote: > >>> On Jun 15, 2018, at 6:02

Re: TPM support within Grub2

2018-07-17 Thread Daniel Kiper
On Mon, Jul 16, 2018 at 12:33:42PM -0400, Daniel P. Smith wrote: > On 07/16/2018 08:06 AM, Daniel Kiper wrote: > > On Mon, Jul 02, 2018 at 06:35:08PM +0200, Daniel Kiper wrote: > >> Hi Daniel, > >> > >> On Sun, Jul 01, 2018 at 07:09:30PM -0400, Daniel P. Smith w

Re: [PATCH v2] ieee1275: obdisk driver

2018-07-17 Thread Daniel Kiper
On Mon, Jul 16, 2018 at 09:33:17AM -0600, Eric Snowberg wrote: > > On Jul 16, 2018, at 7:51 AM, Daniel Kiper wrote: > > > > Sorry for late reply but I was busy with other stuff. > > > > On Thu, Jun 21, 2018 at 01:46:46PM -0600, Eric Snowberg wrote: > >>>

Re: TPM support within Grub2

2018-07-18 Thread Daniel Kiper
On Tue, Jul 17, 2018 at 07:10:32PM +0100, Matthew Garrett wrote: > On Mon, Jul 16, 2018 at 12:33:42PM -0400, Daniel P. Smith wrote: > > On 07/16/2018 08:06 AM, Daniel Kiper wrote: > > > In general I am not against reorganization you are mentioning above. > > > Though I

Re: TPM support within Grub2

2018-07-20 Thread Daniel Kiper
On Wed, Jul 18, 2018 at 04:30:34PM -0400, Daniel P. Smith wrote: > On 07/18/2018 05:03 AM, Daniel Kiper wrote: > > On Tue, Jul 17, 2018 at 07:10:32PM +0100, Matthew Garrett wrote: > >> On Mon, Jul 16, 2018 at 12:33:42PM -0400, Daniel P. Smith wrote: > >>> On 07/16/201

Re: [RFC PATCH] i386: don't include lib/i386/reset.c in EFI builds

2018-07-25 Thread Daniel Kiper
On Fri, Jul 13, 2018 at 03:46:57PM +0100, Leif Lindholm wrote: > On Fri, Jul 13, 2018 at 03:59:38PM +0200, Daniel Kiper wrote: > > On Fri, Jul 13, 2018 at 01:53:52PM +0100, Leif Lindholm wrote: > > > On Fri, Jul 13, 2018 at 01:27:08PM +0200, Daniel Kiper wrote: > > &

[PATCH RFC v2 0/5] verifiers: Framework and EFI shim lock verifier

2018-08-03 Thread Daniel Kiper
+- include/grub/verify.h| 76 ++ util/grub-fstest.c |6 +- util/grub-mount.c|6 +- 86 files changed, 1172 insertions(+), 532 deletions(-) Daniel Kiper (1): efi: Add EFI shim lock verifier Vladimir

[PATCH RFC v2 2/5] verifiers: Framework core

2018-08-03 Thread Daniel Kiper
for the sake of clarity. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub-core/Makefile.core.def|5 + grub-core/commands/verify.c| 565 +--- grub-core/commands/verify_helper.c | 194 + include/grub/file.h

[PATCH RFC v2 1/5] verifiers: File type for fine-grained signature-verification controlling

2018-08-03 Thread Daniel Kiper
From: Vladimir Serbinenko Let's provide file type info to the I/O layer. This way verifiers framework and its users will be able to differentiate files and verify only required ones. This is preparatory patch. Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub

[PATCH RFC v2 4/5] verifiers: Add the documentation

2018-08-03 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- docs/grub-dev.texi | 53 1 file changed, 53 insertions(+) diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi index a9f4de6..591fd80 100644

[PATCH RFC v2 3/5] verifiers: Add possibility to verify kernel and modules command lines

2018-08-03 Thread Daniel Kiper
From: Vladimir Serbinenko Signed-off-by: Vladimir Serbinenko Signed-off-by: Daniel Kiper --- grub-core/commands/verify_helper.c| 14 ++ grub-core/lib/cmdline.c |9 + grub-core/loader/arm/linux.c |8 ++-- grub-core/loader

[PATCH RFC v2 5/5] efi: Add EFI shim lock verifier

2018-08-03 Thread Daniel Kiper
Just an RFC. TODO: - disable the GRUB2 modules load/unload, - disable the dangerous modules, e.g. iorw, memrw. Signed-off-by: Daniel Kiper --- grub-core/Makefile.core.def|6 +++ grub-core/commands/efi/shim_lock.c | 93 2 files changed, 99

Re: [PATCH RFC v2 1/5] verifiers: File type for fine-grained signature-verification controlling

2018-08-03 Thread Daniel Kiper
On Fri, Aug 03, 2018 at 09:56:41PM +0100, Matthew Garrett wrote: > On Fri, Aug 03, 2018 at 03:39:54PM +0200, Daniel Kiper wrote: > > +++ b/grub-core/commands/i386/nthibr.c > > Should this be a separate patch? It seems to be unrelated new > functionality. Yep, you are right. I w

Re: [PATCH v2] ieee1275: obdisk driver

2018-08-30 Thread Daniel Kiper
On Tue, Jul 17, 2018 at 09:59:33AM -0600, Eric Snowberg wrote: > > On Jul 17, 2018, at 7:38 AM, Daniel Kiper wrote: > > On Mon, Jul 16, 2018 at 09:33:17AM -0600, Eric Snowberg wrote: > >>> On Jul 16, 2018, at 7:51 AM, Daniel Kiper wrote: > >>> > >>>

Re: [PATCH v2] ieee1275: obdisk driver

2018-09-01 Thread Daniel Kiper
On Thu, Aug 30, 2018 at 09:28:52AM -0600, Eric Snowberg wrote: > > On Aug 30, 2018, at 8:06 AM, Daniel Kiper wrote: > > On Tue, Jul 17, 2018 at 09:59:33AM -0600, Eric Snowberg wrote: > >>> On Jul 17, 2018, at 7:38 AM, Daniel Kiper wrote: > >>> On Mon, Ju

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-09-03 Thread Daniel Kiper
On Mon, Jun 18, 2018 at 08:12:22PM +0200, Goffredo Baroncelli wrote: > On 06/14/2018 09:05 PM, Goffredo Baroncelli wrote: > >>> + > >>> +cleanup: > >> Space before the label please. > >> I have asked about earlier. > > The line before the label is already a space; Am I missing something > > I think

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-03 Thread Daniel Kiper
On Wed, Jul 18, 2018 at 08:24:50AM +0200, Goffredo Baroncelli wrote: > On 07/12/2018 03:46 PM, Daniel Kiper wrote: > > On Tue, Jun 19, 2018 at 07:39:48PM +0200, Goffredo Baroncelli wrote: > >> Signed-off-by: Goffredo Baroncelli > >> --- >

Re: [PATCH] grub-module-verifier: report the filename or modname in errors.

2018-09-03 Thread Daniel Kiper
On Wed, Aug 01, 2018 at 12:23:03PM -0400, Peter Jones wrote: > Make it so that when grub-module-verifier complains of an issue, it tells you > which module the issue was with. > > Signed-off-by: Peter Jones Reviewed-by: Daniel Kiper Daniel

Re: [PATCH] Fix an 8 year old typo.

2018-09-03 Thread Daniel Kiper
On Wed, Aug 01, 2018 at 12:28:43PM -0400, Peter Jones wrote: > Signed-off-by: Peter Jones Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] module-verifier: make it possible to run checkers on grub-module-verifierxx.c

2018-09-03 Thread Daniel Kiper
On Thu, Aug 02, 2018 at 10:36:33AM -0400, Peter Jones wrote: > This makes it so you can treat grub-module-verifierxx.c as a file you can > build directly, so syntax checkers like vim's "syntastic" plugin, which uses > "gcc -x c -fsyntax-only" to build it, will work. > > One still has to do whatever

Re: [PATCH] linux16 module: code cleanup

2018-09-04 Thread Daniel Kiper
On Tue, Aug 07, 2018 at 02:57:53PM +0800, Cao jin wrote: > 1. move relocator related code more close to each other > 2. use variable "len" since it has correct assignment, and keep coding > style with upper code > > Signed-off-by: Cao jin Reviewed-

Re: [PATCH] relocator16.S: comments update

2018-09-04 Thread Daniel Kiper
On Tue, Aug 14, 2018 at 03:03:25PM +0800, Cao jin wrote: > Signed-off-by: Cao jin Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] ofnet: Initialize structs in bootpath parser

2018-09-04 Thread Daniel Kiper
s/1785859 > Signed-off-by: Julian Andres Klode Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] grub-probe: Sort lists of enums and targets

2018-09-04 Thread Daniel Kiper
On Fri, Aug 31, 2018 at 10:15:20AM -0700, Elliott Mitchell wrote: > This makes it distinctly easier to find things in these tables. Both for > humans trying to add entries, and for computers trying to find entries. This patch does more then commit message says. So, please improve the commit messa

Re: [PATCH] grub-reboot: Warn when "for the next boot only" promise cannot be kept

2018-09-04 Thread Daniel Kiper
; and lvm abstractions. > > Ref: https://lists.gnu.org/archive/html/grub-devel/2009-12/msg00276.html > Ref: https://bugs.launchpad.net/bugs/788298 > > Signed-off-by: dann frazier Reviewed-by: Daniel Kiper Daniel ___ Grub-devel

Re: [PATCH] ahci: Increase time-out from 10 s to 32 s

2018-09-04 Thread Daniel Kiper
; > > We can't read the drives signature before it's ready, i.e. spun up. > > So set the timeout to the standard 30s. Also put a notice on the > > console, so the user knows why the signature reading failed. > > Signed-off-by: Paul Menzel Reviewed-by: D

Re: [PATCH] tests: Fix qemu options for UHCI test

2018-09-04 Thread Daniel Kiper
On Mon, Jul 30, 2018 at 12:37:42PM +0100, Colin Watson wrote: > qemu 2.12 removed the -usbdevice option. Use a more modern spelling > instead, in line with other USB-related tests. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Ki

Re: [PATCH] tests: Disable sercon in SeaBIOS

2018-09-04 Thread Daniel Kiper
On Mon, Jul 30, 2018 at 12:37:22PM +0100, Colin Watson wrote: > SeaBIOS 1.11.0 added support for VGA emulation over a serial port, which > interferes with grub-shell. Turn it off. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Ki

Re: [PATCH] hostdisk: Fix linux disk cache workaround on multipath disks

2018-09-04 Thread Daniel Kiper
On Wed, Jul 25, 2018 at 04:49:15PM +0800, Michael Chang wrote: > In hostdisk.c::grub_util_fd_open_device, there's a workaround to linux disk s#hostdisk.c::grub_util_fd_open_device#grub-core/osdep/linux/hostdisk.c:grub_util_fd_open_device()# > cache described below. > > "Linux has a bug that the d

Re: [PATCH v2] ieee1275: obdisk driver

2018-09-05 Thread Daniel Kiper
On Tue, Sep 04, 2018 at 09:45:14AM -0600, Eric Snowberg wrote: > > On Sep 1, 2018, at 11:10 AM, Daniel Kiper wrote: [...] > > I think that it is correct. If you use one '\' then after shell > > processing you will get > > > > (ieee1275//pci@308/pci@1/us

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-06 Thread Daniel Kiper
On Thu, Aug 09, 2018 at 08:20:07AM +0200, Paul Menzel wrote: > Date: Sun, 16 Apr 2017 21:02:58 +0200 > > The module `all_video` is used in `util/grub.d/00_header.in`, and > included for grub-pc by default. > > To make it easier to load such a GRUB configuration from disk with a > GRUB built as a co

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-06 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Unfortunately this pulls in some problematic graphics drivers that > shouldn't be in default payload Which ones? Daniel ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-06 Thread Daniel Kiper
On Mon, Jul 23, 2018 at 08:52:50AM +0200, Mihai Moldovan wrote: > When reading data off a disk, sector values are based on the disk sector > length. > > Within grub_util_fd_open_device(), the start of the partition was taken > directly from grub's partition information structure, which uses the > i

Re: [PATCH 0/3] use central copy of grub_efi_find_mmap_size

2018-09-06 Thread Daniel Kiper
-- > 3 files changed, 4 insertions(+), 131 deletions(-) Reviewed-by: Daniel Kiper for whole patch series. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] osdep/linux: convert partition start to disk sector length.

2018-09-06 Thread Daniel Kiper
on, reading invalid data. > > Signed-off-by: Mihai Moldovan Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Patch: allow the 'python' used to run gentpl.py to be configured

2018-09-14 Thread Daniel Kiper
On Thu, Sep 13, 2018 at 09:04:44PM -0700, Adam Williamson wrote: > On Tue, 2018-07-17 at 12:35 -0700, Adam Williamson wrote: > > On Fri, 2018-07-06 at 13:19 -0700, Adam Williamson wrote: > > > On Fri, 2018-07-06 at 19:25 +0200, Daniel Kiper wrote: > > > > On Wed, Ju

Re: Patch: allow the 'python' used to run gentpl.py to be configured

2018-09-19 Thread Daniel Kiper
On Tue, Jul 17, 2018 at 12:35:42PM -0700, Adam Williamson wrote: > On Fri, 2018-07-06 at 13:19 -0700, Adam Williamson wrote: > > On Fri, 2018-07-06 at 19:25 +0200, Daniel Kiper wrote: > > > On Wed, Jul 04, 2018 at 10:08:53AM -0700, Adam Williamson wrote: > > > > g

Re: [PATCH V1] hostdisk: Fix linux disk cache workaround on multipath disks

2018-09-19 Thread Daniel Kiper
On Thu, Sep 13, 2018 at 03:20:34PM +0800, Michael Chang wrote: > In grub-core/osdep/linux/hostdisk.c::grub_util_fd_open_device() there's > comment > about linux disk cache issue as below: > > /* Linux has a bug that the disk cache for a whole disk is not consistent > with the one for a part

Re: [PATCH] msdos: Fix overflow in converting partition start and length into 512B blocks

2018-09-19 Thread Daniel Kiper
t; and length into 512B blocks. > > Signed-off-by: Michael Chang Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: How I configure to get Unicode.pf2 and the command of grub-mkfont

2018-09-19 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 11:59:35AM +, Sherry Zhang(BJ-RD) wrote: > Hi all, > When I compile grub2.02 source code, I can not find that the Unicode.pf2 and > the command of grub-mkfont. > How I configure to get Unicode.pf2 and the command of grub-mkfont? > Build: > ./configure I have a feelin

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 08:02:02PM +0200, Mihai Moldovan wrote: > * On 09/06/2018 07:36 PM, Vladimir 'phcoder' Serbinenko wrote: > > Grub partition get start returns in 512B blocks. Can I have more details > > like > > which partmap you use? > > Yes, but this is a low-level function that expects s

Re: [PATCH] osdep/linux: convert partition start to disk sector length.

2018-09-19 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 03:58:56PM +0200, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 08:02:02PM +0200, Mihai Moldovan wrote: > > * On 09/06/2018 07:36 PM, Vladimir 'phcoder' Serbinenko wrote: > > > Grub partition get start returns in 512B blocks. Can I have more det

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: > On Thu, 6 Sep 2018, 17:03 Paul Menzel, wrote: > > > Date: Thu, 6 Sep 2018 15:15:45 +0200 > > > > If executing `efibootmgr` fails, for example, because the system is > > booted in legacy mode, but with a mounted EFI Sy

Re: [PATCH v2 2/2] build: Use pkg-config to find FreeType

2018-09-19 Thread Daniel Kiper
Ugh... Same drop off... Anyway, Reviewed-by: Daniel Kiper Daniel On Tue, Jan 30, 2018 at 09:59:09PM +, Colin Watson wrote: > pkg-config is apparently preferred over freetype-config these days (see > the BUGS section of freetype-config(1)). pkg-config support was added > to Fr

Re: [PATCH v3] Makefile.am: Add `all_video` to `default_payload.elf`

2018-09-19 Thread Daniel Kiper
On Thu, Sep 06, 2018 at 03:21:24PM +0200, Daniel Kiper wrote: > On Thu, Sep 06, 2018 at 03:07:57PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Unfortunately this pulls in some problematic graphics drivers that > > shouldn't be in default payload > > Which

Re: efinet SNP issue affects iscsi boot

2018-09-20 Thread Daniel Kiper
On Thu, Sep 20, 2018 at 06:38:07PM +0800, Michael Chang wrote: > On Thu, Sep 13, 2018 at 06:06:15PM -0600, Micah Parrish wrote: > > Hi, new subscriber here.? We have a problem with Grub 2 and its use of SNP > > instead of MNP.? Our UEFI driver for a network card parses the relevant DHCP > > options

Re: [RFC][PATCH 0/2] grub-install: Use arm-efi target EFI-mode QEMU virt machines

2018-09-20 Thread Daniel Kiper
On Tue, Aug 28, 2018 at 01:33:46PM -0600, dann frazier wrote: > Now that Leif has fixed up the arm-uefi target, I'm looking at adding that > support into Debian/Ubuntu for virtual machines. One issue is that > 'grub-install' errors out by default when only the arm-efi flavor is > installed: > > $ s

Re: [RFC][PATCH 2/2] arm: grub-install: Default to arm-efi target in EFI-based QEMU virt models

2018-09-20 Thread Daniel Kiper
On Tue, Aug 28, 2018 at 01:33:48PM -0600, dann frazier wrote: > From: dann frazier > > We currently default to the arm-uboot target in grub-install, > but arm-efi should be used for some systems with UEFI firmware, such as > Tianocore/EDK2-based QEMU models. We could change the default to arm-efi

Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description

2018-09-21 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 04:18:45PM +0200, Paul Menzel wrote: > Dear Daniel, > > > On 09/19/18 16:08, Daniel Kiper wrote: > > On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko > > wrote: > >> On Thu, 6 Sep 2018, 17:03 Paul Menzel,

Re: [PATCH 1/3] btrfs: Import kernel zstd

2018-09-21 Thread Daniel Kiper
On Mon, Aug 27, 2018 at 06:36:52PM -0700, Nick Terrell wrote: > Import xxhash and zstd from the upstream kernel as-is. This will not > compile. The next patch in the series contains all the changes needed to > make zstd compile in grub. Only the files needed for decompression are > imported from zs

Re: [PATCH 2/3] btrfs: Patch the kernel zstd

2018-09-21 Thread Daniel Kiper
On Mon, Aug 27, 2018 at 06:36:53PM -0700, Nick Terrell wrote: > Applies patches to the upstream kernel zstd needed to compile in grub. > * Replace kernel headers with "kerncompat.h". > * Replace the unaligned memory access functions. > * Add fallthrough statements for newer gcc versions. > * Rename

Re: [PATCH 3/3] btrfs: Add zstd support to btrfs

2018-09-21 Thread Daniel Kiper
On Mon, Aug 27, 2018 at 06:36:54PM -0700, Nick Terrell wrote: > Adds zstd support to the btrfs module. I'm not sure that my changes to the > Makefiles are correct, please let me know if I need to do something > differently. > > Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zs

Re: grubenv on md, Btrfs, LUKS, etc

2018-09-21 Thread Daniel Kiper
On Tue, Sep 18, 2018 at 01:40:06PM -0600, Chris Murphy wrote: > On Mon, Sep 17, 2018 at 10:59 PM, Chris Murphy > wrote: > > Hi, > > > > GRUB code can certainly read files that are on Btrfs, md devices, > > LUKS, LVM, and so on. But GRUB code can also write to the physical > > block for grubenv -

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-09-25 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 08:40:32PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 66 > 1 file changed, 66 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-

Re: [PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

2018-09-25 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 08:40:34PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > The caller knows better if this error is fatal or not, i.e. another disk is > available or not. > > This is a preparatory patch. > > Signed-off-by: Goffredo Baroncelli >

Re: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-09-25 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 08:40:35PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > If a device is not found, do not return immediately but > record this failure by storing NULL in data->devices_attached[]. Still the same question: Where the store happens in the code? I cannot fi

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-09-25 Thread Daniel Kiper
On Wed, Sep 19, 2018 at 08:40:38PM +0200, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > > Add support for recovery for a RAID 5 btrfs profile. In addition > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/

<    1   2   3   4   5   6   7   8   9   10   >