Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-17 Thread Daniel Wagner
On 2013-07-14 04:06, Hamish Mackenzie wrote: > cabal-meta does not like the gtk3 cabal file to be called gtk.cabal. > Please can we > > darcs move gtk.cabal gtk3.cabal Hm. I'm happy to do this; but will it work? Presumably then we would run into the problem that cabal-meta will want the gtk cab

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-17 Thread Daniel Wagner
On 2013-07-14 15:19, Hamish Mackenzie wrote: > One other thing. Removing the deprecated functions in gtk3.cabal is > fine with me, but toolbarSetIconSize is deprecated and I don't think > it should have been. > > The gtk3 docs for gtk_toolbar_set_icon_size list it as deprecated. > > We use it in

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-14 Thread Hamish Mackenzie
One other thing. Removing the deprecated functions in gtk3.cabal is fine with me, but toolbarSetIconSize is deprecated and I don't think it should have been. The gtk3 docs for gtk_toolbar_set_icon_size list it as deprecated. We use it in Leksah like this... toolbarSetIconSize toolbar IconSize

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-14 Thread Hamish Mackenzie
Looks good just a couple of minor issues... cabal-meta does not like the gtk3 cabal file to be called gtk.cabal. Please can we darcs move gtk.cabal gtk3.cabal We will need to update the build scripts. They also need to do a clean in between building the gtk2 and gtk3 versions (to make sure th

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-11 Thread Daniel Wagner
Okay, I obliterated the old patches. People following along at home should do the same; specifically, I obliterated the patches named "add the gtk3 package" and "begin a split into gtk and gtk3 packages". I also pushed Hamish's changes and a few add-on cleanup ones of my own, including making t

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-10 Thread Hamish Mackenzie
On 11 Jul 2013, at 07:45, Daniel Wagner wrote: > Awesome. I'll take a look in the morning. I might want the gtk3 bits to go in > their own package, rather than managing the difference with version numbers; > other than that a cursory glance says this is just spot on. I think you are right, tha

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-10 Thread Daniel Wagner
Awesome. I'll take a look in the morning. I might want the gtk3 bits to go in their own package, rather than managing the difference with version numbers; other than that a cursory glance says this is just spot on. I'm not sure about the Hackage complaint... the thing uploaded to Hackage preda

Re: [Gtk2hs-devel] gtk3 split into own package

2013-07-07 Thread Hamish Mackenzie
I have had a go at doing the two .cabal files trick and it seems to work. I have pushed the results here... http://patch-tag.com/r/hamish/gtk2hs You will probably need to "darcs rollback" or "darcs obliterate" the two gtk3 patches you added to the main repo before it will work. I think oblite

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Daniel Wagner
On 2013-05-25 13:56, Axel Simon wrote: > Uh, but code duplication means you have to fix bugs in two places. Yes, it absolutely sucks. > So is there no way to build CPP'd code base once as gtk2 with one > cabal file and then to build it as gtk3 with another cabal file. Then > you'd have one code b

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Axel Simon
Hi, On 25.05.2013, at 16:15, Daniel Wagner wrote: >>> ...in fact, just generally all feedback on this split is welcome. =) >> >> Before I try to do a visual diff: Could you detail what got >> duplicated? Just the cabal file and the Setup.hs? Or are there modules >> that cannot be customized usi

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Daniel Wagner
On 2013-05-25 11:54, Hamish Mackenzie wrote: > pkg-config treats gtk3 as a whole new package, so it might make sense > for gtk2hs to do the same. But I think we could consider using the > major version. We could call the new one gtk-3.12.x. Cabal should > let you install both gtk-0.12 and gtk-3.1

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Hamish Mackenzie
On 26 May 2013, at 02:15, Daniel Wagner wrote: > On 2013-05-25 07:39, Axel Simon wrote: >> Hi Daniel, >> >> On 25.05.2013, at 02:50, Daniel Wagner >> wrote: >> >>> The more I looked at the gtk3 support we had so far, the more >>> uncomfortable I got with how different the interfaces were. Sin

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Daniel Wagner
On 2013-05-25 07:39, Axel Simon wrote: > Hi Daniel, > > On 25.05.2013, at 02:50, Daniel Wagner > wrote: > >> The more I looked at the gtk3 support we had so far, the more >> uncomfortable I got with how different the interfaces were. Since >> it's >> not really possible for a cabal package to

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Daniel Wagner
On 2013-05-24 22:20, Conrad Parker wrote: > Can you add a gtk-core package that they both depend on? Well, not really, because they need to link against different things: the one is linking against the gtk2 library and the other against gtk3. Very little of the code in gtk is actually pure Haske

Re: [Gtk2hs-devel] gtk3 split into own package

2013-05-25 Thread Axel Simon
Hi Daniel, On 25.05.2013, at 02:50, Daniel Wagner wrote: > The more I looked at the gtk3 support we had so far, the more > uncomfortable I got with how different the interfaces were. Since it's > not really possible for a cabal package to depend on a compilation flag, > I feel like the right