Re: [PATCH] Add unboxed floating point comparison instructions.

Hi Andy, On Mon, Jan 9, 2017 at 4:23 PM, Andy Wingo wrote: > On Mon 09 Jan 2017 02:09, "Thompson, David" writes: > >> + /* br-if-f64= a:12 b:12 invert:1 _:7 offset:24 > > Missing - before the =. > >> + /* br-if-f64< a:12 b:12 invert:1 _:7 offset:24 >

Re: [PATCH] Add unboxed floating point comparison instructions.

Hi Andy, On Mon, Jan 9, 2017 at 4:23 PM, Andy Wingo wrote: > On Mon 09 Jan 2017 02:09, "Thompson, David" writes: > >> + /* br-if-f64= a:12 b:12 invert:1 _:7 offset:24 > > Missing - before the =. > >> + /* br-if-f64< a:12 b:12 invert:1 _:7 offset:24 >

Re: [PATCH] Add unboxed floating point comparison instructions.

On Mon 09 Jan 2017 02:09, "Thompson, David" writes: > + /* br-if-f64= a:12 b:12 invert:1 _:7 offset:24 Missing - before the =. > + /* br-if-f64< a:12 b:12 invert:1 _:7 offset:24 Here too. Please fix these nits and then LGTM; please push directly. Thanks! Andy

Re: [PATCH] Add unboxed floating point comparison instructions.

Hi Andy, Thanks for the feedback. I believe this new patch addresses everything you asked me to fix. Am I in time for 2.1.6? ;) - Dave From bfd7b4f343c5f5cc8761c8d1fed1f61ba564a5dd Mon Sep 17 00:00:00 2001 From: David Thompson Date: Mon, 12 Dec 2016 22:46:08 -0500

Re: [PATCH] Add unboxed floating point comparison instructions.

On Thu 05 Jan 2017 02:41, "Thompson, David" writes: > + VM_DEFINE_OP (189, br_if_f64_le, "br-if-f64-<=", OP3 (X8_S24, X8_S24, > B1_X7_L24)) Missing inline docs. > + /* br-if-f64-> a:24 _:8 b:24 invert:1 _:7 offset:24 > + * > + * If the F64 value in A is > than

Re: [PATCH] Add unboxed floating point comparison instructions.

Hello Andy and Mark, Thanks for taking the time to review this patch and bearing with me as a I stumble around the compiler. I've attached a new patch and have some additionally commentary below: On Wed, Dec 21, 2016 at 4:12 PM, Mark H Weaver wrote: > Andy Wingo

Re: [PATCH] Add unboxed floating point comparison instructions.

Andy Wingo writes: > I think /0 should be replaced by (/f64). Probably also you need > a good +nan.0 story here; does this do the right thing? e.g. > > (let ((a +nan.0)) > (if (< a 100.0) > (< a 200.0) > (> a 50.0))) > > Does this fold to #t? I think for

Re: [PATCH] Add unboxed floating point comparison instructions.

Hi! Patch looks good, just a couple of nits. On Wed 14 Dec 2016 15:51, "Thompson, David" writes: > + VM_DEFINE_OP (189, br_if_f64_le, "br-if-f64-<=", OP3 (X8_S24, X8_S24, > B1_X7_L24)) > +{ > + BR_F64_ARITHMETIC (<=); > +} Missing inline docs for this

Re: [PATCH] Add unboxed floating point comparison instructions.

Here is an updated patch. All of the code is the same but I added docs in doc/ref/vm.texi. - Dave From 7d8017812a77489f362c2b9b97ee0988e5d3d7bc Mon Sep 17 00:00:00 2001 From: David Thompson Date: Mon, 12 Dec 2016 22:46:08 -0500 Subject: [PATCH] Add unboxed floating