Re: Update 'uname' emulation on MS-Windows

2016-07-16 Thread Eli Zaretskii
> From: Andy Moreton > Date: Sat, 16 Jul 2016 22:40:38 +0100 > > On Sat 16 Jul 2016, Eli Zaretskii wrote: > > > The processors and OS versions of the emulated 'uname' need an update; > > the patch below does that: > > This uses GetVersionEx, which does not tell the

Re: guile-lib - devel branch - patch 4 of 11

2016-07-16 Thread Eli Zaretskii
> Date: Sat, 16 Jul 2016 17:34:02 -0300 > From: David Pirotte > Cc: guile-devel@gnu.org > > nice to see progress on MinGW, congrat! Thanks. > > > * configure.ac: Adding a copyright; bumping prereq -> 2.69 > > > Why is that a good idea? > > Why not? > 2.69 is the

Re: Update 'uname' emulation on MS-Windows

2016-07-16 Thread Andy Moreton
On Sat 16 Jul 2016, Eli Zaretskii wrote: > The processors and OS versions of the emulated 'uname' need an update; > the patch below does that: This uses GetVersionEx, which does not tell the truth on versions after Windows 8 unless the application contains a manifest (see online documentation

Re: guile-lib - devel branch - patch 4 of 11

2016-07-16 Thread David Pirotte
Hi Eli, nice to see progress on MinGW, congrat! > > * configure.ac: Adding a copyright; bumping prereq -> 2.69 > Why is that a good idea? Why not? 2.69 is the latest stable, available since April 2012 > Are there any features Guile needs that older versions don't support? It is

Avoid warnings in sockets.c when HAVE_SIN6_SCOPE_ID is unavailable

2016-07-16 Thread Eli Zaretskii
CC libguile_2.0_la-socket.lo socket.c: In function 'scm_fill_sockaddr': socket.c:747:16: warning: variable 'scope_id' set but not used [-Wunused-but-set-variable] unsigned long scope_id = 0; ^ The patch to avoid this warning is below. OK to commit? ---

Avoid warning about alloca in read.c

2016-07-16 Thread Eli Zaretskii
CC libguile_2.0_la-read.lo read.c: In function 'try_read_ci_chars': read.c:983:3: warning: implicit declaration of function 'alloca' [-Wimplicit-function-declaration] read.c:983:22: warning: incompatible implicit declaration of built-in function 'alloca' [enabled by

Avoid warnings in threads.c when building without threads

2016-07-16 Thread Eli Zaretskii
CC libguile_2.0_la-threads.lo In file included from ../libguile/threads.h:40:0, from ../libguile/gc.h:30, from ../libguile/_scm.h:76, from threads.c:28: threads.c: In function 'scm_call_with_new_thread':

Re: MinGW open-process, take N

2016-07-16 Thread Eli Zaretskii
> Date: Sat, 16 Jul 2016 16:24:46 +0300 > From: Eli Zaretskii > Cc: m...@netris.org, l...@gnu.org, guile-devel@gnu.org > > Is it okay to push what I have now, and remove all the tabs from > posix-w32.c (not just those I added) in a follow-up commit? Never mind, I just did that.

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 15:39:23 +0200 > > I think the right thing here is to use the mkostemp gnulib module > instead and pass O_BINARY in the flags. I have made this change in > git; please let me know if it causes problems for

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Andy Wingo
On Sat 16 Jul 2016 13:24, Eli Zaretskii writes: > diff --git a/libguile/filesys.c b/libguile/filesys.c > index 48232e8..c47c2f4 100644 > --- a/libguile/filesys.c > +++ b/libguile/filesys.c > @@ -1472,6 +1472,14 @@ SCM_DEFINE (scm_mkstemp, "mkstemp!", 1, 0, 0, >SCM_SYSCALL (rv =

Re: MinGW open-process, take N

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: m...@netris.org, l...@gnu.org, guile-devel@gnu.org > Date: Sat, 16 Jul 2016 13:32:04 +0200 > > Patch looks good to me, feel free to push after fixing tab problems and > adding the mutex. I added the mutex. Is it okay to push what I have now, and

Re: MinGW open-process, take N

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: m...@netris.org, l...@gnu.org, guile-devel@gnu.org > Date: Sat, 16 Jul 2016 13:32:04 +0200 > > On Sat 16 Jul 2016 12:54, Eli Zaretskii writes: > > > Here's the first cut. (I will rework it into git-format-patch form, > > or commit and

Re: MinGW open-process, take N

2016-07-16 Thread Andy Wingo
On Sat 16 Jul 2016 12:54, Eli Zaretskii writes: > Here's the first cut. (I will rework it into git-format-patch form, > or commit and push myself, whatever is more convenient for you, as > soon as it is okayed for upstream.) Looks good to me. Please configure your editor to not

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 10:33:56 +0200 > > > Can these please be applied? > > Sure let's work on it. Would you mind submitting these again, making > sure they apply cleanly to stable-2.0? 3 patches against the current stable-2.0

Re: MinGW open-process, take N

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: m...@netris.org, l...@gnu.org, guile-devel@gnu.org > Date: Thu, 14 Jul 2016 23:31:31 +0200 > > > I see your point, and I think I can fix this, together with the pid_t > > width issue in 64-bit build, if I introduce an array private to > > posix-w32.c

Re: [PATCH] Re: Patchset related to array functions

2016-07-16 Thread Chris Vine
On Sat, 16 Jul 2016 11:07:40 +0200 Andy Wingo wrote: [snip] > I would like stdint.h though :) I agree. stdint.h is required by C++11, Appendix D5, to be available in C++11 and later, with the same meaning as in C99, but in practice it was available before then. It is provided

Re: Guile's DATAROOTDIR and DATADIR

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: Mark H Weaver , guile-devel@gnu.org > Date: Sat, 16 Jul 2016 11:06:06 +0200 > > Any incompatible change between 2.0.12 and a previous release in the > 2.0.x series is a bug. It is impossible to make a list of all bugs in a > project of

Re: Update 'uname' emulation on MS-Windows

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 10:58:39 +0200 > > On Sat 16 Jul 2016 09:27, Eli Zaretskii writes: > > > 2016-07-16 Eli Zaretskii > > > > * libguile/posix-w32.c (uname): Update to modern processors (ia64

Re: Compilation warnings in net_db.c

2016-07-16 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 10:53:37 +0200 > > >net_db.c:454:20: warning: 'sym_ai_passive' defined but not used > > [-Wunused-variable] > > SCM_VARIABLE_INIT (sym_ai_passive, "AI_PASSIVE", > >^ > >

Re: Guile's DATAROOTDIR and DATADIR

2016-07-16 Thread Eli Zaretskii
> From: Mark H Weaver > Cc: guile-devel@gnu.org > Date: Sat, 16 Jul 2016 04:39:24 -0400 > > > It make sense if it indeed works in practice. > > As I wrote in my previous message, it does indeed seem to work in > practice, based on the lack of bug reports indicating otherwise.

Re: [PATCH] Re: Patchset related to array functions

2016-07-16 Thread Andy Wingo
On Fri 15 Jul 2016 12:52, Chris Vine writes: > On Thu, 14 Jul 2016 17:41:45 +0200 > Daniel Llorens wrote: > [snip] >> I think we'd want C89/C90 users to still be able to #include >> . Dunno. > > libguile.h can also at present be included

Re: Guile's DATAROOTDIR and DATADIR

2016-07-16 Thread Andy Wingo
On Fri 15 Jul 2016 19:46, Eli Zaretskii writes: > Is it possible to publish the list of ABI incompatibilities between > 2.0.11 and 2.0.12 specifically? Any incompatible change between 2.0.12 and a previous release in the 2.0.x series is a bug. It is impossible to make a list of

Re: [PATCH] doc: Do not gender the programmer.

2016-07-16 Thread Andy Wingo
On Fri 15 Jul 2016 09:41, Ricardo Wurmus writes: > * doc/ref/api-foreign.texi: Replace "his" with "their". > * doc/ref/sxml.texi: Likewise. Applied, thanks. Andy

Re: Update 'uname' emulation on MS-Windows

2016-07-16 Thread Andy Wingo
On Sat 16 Jul 2016 09:27, Eli Zaretskii writes: > 2016-07-16 Eli Zaretskii > > * libguile/posix-w32.c (uname): Update to modern processors (ia64 > and x86_64) and OS versions (Vista to Windows 10). Delete > trailing whitespace. Applied, thanks.

Re: Do-loop enigma with two variables

2016-07-16 Thread Taylan Ulrich Bayırlı/Kammer
Pierre Lairez writes: > Dear guile users, > > When running the following loop: > (do ((i 1 (+ 1 i)) > (j 0 i)) > ((> i 4) (newline)) > (display (list i j))) > > I expect without hesitation to read > (1 0)(2 1)(3 2)(4 3) > > To my surprise, I obtain > (1 0)(2

Re: Compilation warnings in net_db.c

2016-07-16 Thread Andy Wingo
Hi, On Fri 15 Jul 2016 21:23, Eli Zaretskii writes: > While compiling net_db.c from Guile 2.0.12 with MinGW, I get a bunch > of warnings such as this one: > >net_db.c:454:20: warning: 'sym_ai_passive' defined but not used > [-Wunused-variable] > SCM_VARIABLE_INIT

Re: Guile's DATAROOTDIR and DATADIR

2016-07-16 Thread Mark H Weaver
Eli Zaretskii writes: >> From: Mark H Weaver >> Cc: guile-devel@gnu.org >> Date: Fri, 15 Jul 2016 13:25:46 -0400 >> >> Having said this, I will admit that we've not maintained perfect ABI >> compatibility within 2.0.x, e.g. we've removed some obscure interfaces

Re: configure.ac needs a change for MinGW

2016-07-16 Thread Andy Wingo
On Fri 15 Jul 2016 21:10, Eli Zaretskii writes: > win32-uname.[ch] were renamed in Guile 2.0.12, but configure.ac still > references them: > > case $host in > *-*-mingw*) > AC_CHECK_HEADER(winsock2.h, [AC_DEFINE([HAVE_WINSOCK2_H], 1, > [Define if you have the

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-16 Thread Andy Wingo
Hi, On Fri 15 Jul 2016 21:04, Eli Zaretskii writes: > I built Guile 2.0.12 today with MinGW, and to my chagrin found that > some of the patches I sent long ago are still not in the repository. > > Below please find the list of those patches. > > The stime.c patch in this message

Re: Patchset related to array functions

2016-07-16 Thread Andy Wingo
On Fri 15 Jul 2016 19:41, Mark H Weaver writes: > Andy Wingo writes: > >> (2) Can we use C99 in our public interface, or just internally? If we >> use it publically, what should we change? No more scm_t_uint8 I >> hope, besides for back-compat?

Update 'uname' emulation on MS-Windows

2016-07-16 Thread Eli Zaretskii
The processors and OS versions of the emulated 'uname' need an update; the patch below does that: 2016-07-16 Eli Zaretskii * libguile/posix-w32.c (uname): Update to modern processors (ia64 and x86_64) and OS versions (Vista to Windows 10). Delete

Re: guile-lib - devel branch - patch 4 of 11

2016-07-16 Thread Eli Zaretskii
> Date: Fri, 15 Jul 2016 22:43:05 -0300 > From: David Pirotte > > * configure.ac: Adding a copyright; bumping prereq -> 2.69 Why is that a good idea? Are there any features Guile needs that older versions don't support? Thanks.