Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-05 Thread Mathieu Lirzin
Nils Gillmann writes: > I read through this, and I think I have to read the whole thread > again. So the new 0.9.1 way for writing $PN-$PV is no longer "-" > but "@" as in libreoffice@10.0.0 ? Or is this simply a hydra > / some other part of architecture thing? This new

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-05 Thread Alex Kost
Nils Gillmann (2016-03-05 04:28 +0300) wrote: > l...@gnu.org (Ludovic Courtès) writes: > >> Mathieu Lirzin skribis: >>> +*** New syntax for separating package names and version numbers >>> + >>> +Use ‘@’ instead of ‘-’ as a separator. This new separator is a reserved >>

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-05 Thread Alex Kost
Mathieu Lirzin (2016-03-05 02:03 +0300) wrote: > Alex Kost writes: > >> Mathieu Lirzin (2016-02-29 03:28 +0300) wrote: >> >> [...] >>> I have left the emacs interface untouched. >> >> Hm, I wonder why? You already had the required changes in your initial >> patch. Anyway,

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-04 Thread Nils Gillmann
l...@gnu.org (Ludovic Courtès) writes: > Mathieu Lirzin skribis: >> +*** New syntax for separating package names and version numbers >> + >> +Use ‘@’ instead of ‘-’ as a separator. This new separator is a reserved >^^ > Maybe add: “, as in

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-04 Thread Mathieu Lirzin
l...@gnu.org (Ludovic Courtès) writes: > Mathieu Lirzin skribis: > >> The concern of backward compability that Ludo raised, have made the work >> more challenging than changing things in place. As a consequence it was >> not clear to me what should/can change or not. To keep my

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-04 Thread Ludovic Courtès
Mathieu Lirzin skribis: > Alex Kost writes: > >> Mathieu Lirzin (2016-02-29 03:28 +0300) wrote: >> >> [...] >>> I have left the emacs interface untouched. >> >> Hm, I wonder why? You already had the required changes in your initial >> patch. Anyway, I'm

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-04 Thread Mathieu Lirzin
Hi, Alex Kost writes: > Mathieu Lirzin (2016-02-29 03:28 +0300) wrote: > > [...] >> I have left the emacs interface untouched. > > Hm, I wonder why? You already had the required changes in your initial > patch. Anyway, I'm attaching the patch with these changes. The only >

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-04 Thread Alex Kost
Ludovic Courtès (2016-03-03 19:55 +0300) wrote: > Alex Kost skribis: > >> Sorry if it was discussed but why 'package-full-name' from (guix >> packages) wasn't changed? > > I think I was afraid that existing uses in unexpected place would break, > such as when using the full

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-03 Thread Ludovic Courtès
Alex Kost skribis: > Sorry if it was discussed but why 'package-full-name' from (guix > packages) wasn't changed? I think I was afraid that existing uses in unexpected place would break, such as when using the full name as anchor names in HTML. But then I also remember a

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-03-03 Thread Alex Kost
Mathieu Lirzin (2016-02-29 03:28 +0300) wrote: [...] > I have left the emacs interface untouched. Hm, I wonder why? You already had the required changes in your initial patch. Anyway, I'm attaching the patch with these changes. The only difference from your original patch is replacing

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-02-29 Thread Ludovic Courtès
Mathieu Lirzin skribis: > However, I am not pleased by the current state of the > ‘specification/package-name->...’ procedures. They don't compose well, > and are obfuscated by being fragmented across a bunch of modules. I > don't know if there is much room for improvement but my

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-02-28 Thread Mathieu Lirzin
Hi, l...@gnu.org (Ludovic Courtès) writes: > What about this: > > 1. Put the new ‘package-name->name+version’ in (guix utils) and keep > it dumb (i.e., it insists on having an ‘@’, as is the case with the > patch you posted.) > > 2. Add the fallback case in ‘specification->package’

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-02-23 Thread Ludovic Courtès
Mathieu Lirzin skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> Mathieu Lirzin skribis: >> >>> From 7fef43249b704db3c4d511b2f1b62428740cfa73 Mon Sep 17 00:00:00 2001 >>> From: Mathieu Lirzin >>> Date: Sun, 24 Jan 2016 01:54:44 +0100 >>> Subject:

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-02-19 Thread Mathieu Lirzin
l...@gnu.org (Ludovic Courtès) writes: > Mathieu Lirzin skribis: > >> From 7fef43249b704db3c4d511b2f1b62428740cfa73 Mon Sep 17 00:00:00 2001 >> From: Mathieu Lirzin >> Date: Sun, 24 Jan 2016 01:54:44 +0100 >> Subject: [PATCH] utils: Use '@' for separating package

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-26 Thread Ludovic Courtès
Mathieu Lirzin skribis: > From 7fef43249b704db3c4d511b2f1b62428740cfa73 Mon Sep 17 00:00:00 2001 > From: Mathieu Lirzin > Date: Sun, 24 Jan 2016 01:54:44 +0100 > Subject: [PATCH] utils: Use '@' for separating package names and version > numbers. > > Fixes

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-26 Thread Mathieu Lirzin
Alex Kost writes: > Mathieu Lirzin (2016-01-26 00:41 +0300) wrote: > >> Finally, There is some code redundancy for the emacs UI but If I >> remember correctly there is a reason for that. (Alex?) > > If there is redundancy in the code, it should be removed. I didn't find > a

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-26 Thread Mathieu Lirzin
l...@gnu.org (Ludovic Courtès) writes: > Mathieu Lirzin skribis: > >> +++ b/guix/build/utils.scm >> >> (define (package-name->name+version name) >> - "Given NAME, a package name like \"foo-0.9.1b\", return two values: >> -\"foo\" and \"0.9.1b\". When the version part is

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-26 Thread Ludovic Courtès
Mathieu Lirzin skribis: > l...@gnu.org (Ludovic Courtès) writes: > >> Mathieu Lirzin skribis: >> >>> +++ b/guix/build/utils.scm >>> >>> (define (package-name->name+version name) >>> - "Given NAME, a package name like \"foo-0.9.1b\", return two values: >>> -\"foo\"

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-25 Thread Thompson, David
On Sun, Jan 24, 2016 at 3:19 PM, Mathieu Lirzin wrote: > > Fixes . > > * guix/build/utils.scm (package-name->name+version): Use '@' for > separating package names and version numbers instead of '-'. This > provides the ability to use numbers in package

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-25 Thread Mathieu Lirzin
Alex Kost writes: > Tremendous work! How did you manage to find all these occurrences? Thank you. In fact I haven't followed any methodic step. I have started editing the heart of the thing (meaning 'package-name->name+version') then look where it was used. adapt the

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-25 Thread Mathieu Lirzin
"Thompson, David" writes: > Does the fact that so many files needed to be edited indicate the need > for a single specification string constructor? If this had already > been the case, then this patch would have only needed to change 1 or 2 > procedures. I don't know

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-25 Thread Alex Kost
Mathieu Lirzin (2016-01-26 00:41 +0300) wrote: > "Thompson, David" writes: > >> Does the fact that so many files needed to be edited indicate the need >> for a single specification string constructor? If this had already >> been the case, then this patch would have

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-25 Thread Alex Kost
Mathieu Lirzin (2016-01-24 23:19 +0300) wrote: > Fixes . > > * guix/build/utils.scm (package-name->name+version): Use '@' for > separating package names and version numbers instead of '-'. This > provides the ability to use numbers in package names. > *

[PATCH 04/13] utils: Use '@' for separating package names and version numbers.

2016-01-24 Thread Mathieu Lirzin
Fixes . * guix/build/utils.scm (package-name->name+version): Use '@' for separating package names and version numbers instead of '-'. This provides the ability to use numbers in package names. * guix/packages.scm (package-full-name): Add an optional SEPARATOR argument