Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-28 Thread Ludovic Courtès
Alex Kost skribis: > ng0 (2016-09-24 20:00 +) wrote: > >> We should either be consistent with this in all files or remove this >> altogether in my opinion. >> >>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >>> gnu/build/vm.scm:323:;;; vm.scm ends

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-26 Thread Andy Wingo
On Mon 26 Sep 2016 10:32, Christopher Allan Webber writes: > It feels like cruft that nobody knows the reason for, or has a good > reason in this modern age. I'd rather they just be trimmed. > > But I also don't feel like it matters much, so whatever is decided is >

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-26 Thread Christopher Allan Webber
ng0 writes: > Alex Kost writes: > >> ng0 (2016-09-24 20:00 +) wrote: >> >>> We should either be consistent with this in all files or remove this >>> altogether in my opinion. >>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread John Darrington
On Sun, Sep 25, 2016 at 07:55:48PM +0200, Vincent Legoll wrote: On Sun, Sep 25, 2016 at 7:45 PM, Hartmut Goebel wrote: > Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic: >> That's probably enough reason to remove them. > > +1

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread Vincent Legoll
On Sun, Sep 25, 2016 at 7:45 PM, Hartmut Goebel wrote: > Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic: >> That's probably enough reason to remove them. > > +1 +1, but please do not post a patchbomb^Wseries for review on the ML, just script it and merge at the

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread Hartmut Goebel
Am 25.09.2016 um 11:38 schrieb Danny Milosavljevic: > That's probably enough reason to remove them. +1 -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread Danny Milosavljevic
Hi, On Sun, 25 Sep 2016 11:30:41 +0300 Alex Kost wrote: > I don't know what the original purpose of this convention is, That's probably enough reason to remove them. > it was > probably invented in those ancient times when dinosaurs walked by > streets, but I kinda like

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread John Darrington
On Sun, Sep 25, 2016 at 11:30:41AM +0300, Alex Kost wrote: ng0 (2016-09-24 20:00 +) wrote: > We should either be consistent with this in all files or remove this > altogether in my opinion. > >> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here"

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread ng0
Alex Kost writes: > ng0 (2016-09-24 20:00 +) wrote: > >> We should either be consistent with this in all files or remove this >> altogether in my opinion. >> >>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >>> gnu/build/vm.scm:323:;;; vm.scm ends

Re: Cosmetical change: remove inconsistent "$file ends here"?

2016-09-25 Thread Alex Kost
ng0 (2016-09-24 20:00 +) wrote: > We should either be consistent with this in all files or remove this > altogether in my opinion. > >> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >> gnu/build/vm.scm:323:;;; vm.scm ends here ... > What do you think? I don't know what