Hi Ricardo,
I have fixed the errors mentioned bellow, Please do check and notify me
for further modifications.
>>> The next steps are to fix the errors in the regular expressions that
>>> swallow certain space characters and to re-read the documentation of
>>> “make-soft-port” to make sure that
Hi Sahithi,
>> Do you see this too? (If not, can you tell us what terminal you are
>> using?) At the very least you should see that every line starts with a
>> dot.
> I am able to see the colours. I tested with the same hello package
> before sending you the patch. And yes "." for each line.
Hi
On Wednesday 13 June 2018 03:42 AM, Ricardo Wurmus wrote:
> Hi Sahithi,
>
> thank you for rebasing it.
>
> I have applied it successfully and I tested the output with this
> command:
>
> ./pre-inst-env guix build --no-grafts --check hello
>
> When I run this in the source directory I do
Hi Sahithi,
thank you for rebasing it.
I have applied it successfully and I tested the output with this
command:
./pre-inst-env guix build --no-grafts --check hello
When I run this in the source directory I do see colours and extra dots
on every new line, and I see a couple of missing
Hi Ricardo,
> I cannot seem to apply the patch onto either the “wip-sahithi” or
> “master” branches. Could you rebase your changes on top of the
> “wip-sahithi” branch, please? If that turns out to be too difficult,
> please rebase the changes on top of the current “master” branch after
>
Hi Sahithi,
> When I used "(colorize-string "hello" '(GREEN))" in REPL that gave me a
> error unbound variable colorize-string
This means that “colorize-string” was not defined in the REPL session.
You would need to re-evaluate the definition.
> When i used the same in attached file this gave
Hi Sahithi,
> Updated patch is attached.
>
>> Could you send an updated patch?
I cannot seem to apply the patch onto either the “wip-sahithi” or
“master” branches. Could you rebase your changes on top of the
“wip-sahithi” branch, please? If that turns out to be too difficult,
please rebase
Hi Ricardo,
Text file is attached with all changes I added including colorize module.
The changes added to build.scm is (/(parameterize
((current-build-output-port colorful-build-output-port)) /)
> Please send me the complete changes as a text file, so that I can apply
> it to my copy of the
Hi Gábor,
Updated patch is attached.
> Could you send an updated patch?
---
Thanks!!
Sahithi.
>From 765035232a43f09a5c3dbecf77c90499dd1473d4 Mon Sep 17 00:00:00 2001
From: Sahithi Yarlagadda
Date: Tue, 5 Jun 2018 00:08:32 +0530
Subject: [PATCH] guix: Add coloring soft port.
* guix/ui.scm
Hi Sahithi,
>> You should see the same as I did.
> This worked for me too.
That’s good.
>> To see what’s going on with your modifications to “(guix ui)” it would
>> help if you could go through your changes once more (use “git diff” to
>> be sure to inspect all the lines you have changed) and
2018-06-11 14:14 GMT+02:00 Sahitihi :
> Hi Ricardo,
>
> > You should see the same as I did.
> This worked for me too.
> > To see what’s going on with your modifications to “(guix ui)” it would
> > help if you could go through your changes once more (use “git diff” to
> > be sure to inspect all
Hi Ricardo,
> You should see the same as I did.
This worked for me too.
> To see what’s going on with your modifications to “(guix ui)” it would
> help if you could go through your changes once more (use “git diff” to
> be sure to inspect all the lines you have changed) and send your changes
> to
Hi Ricardo,
When I used "(colorize-string "hello" '(GREEN))" in REPL that gave me a
error unbound variable colorize-string
When i used the same in attached file this gave me a colorless output
However when I tried with "(colorize-string "hello" 'GREEN)" in same
file this gave me colored output
Hi Sahithi,
> As per discussion in irc, I tried using "pk str" and "(pk
> (string-append …))" to show values.
>
> I dint find any differences with and without pk.
That’s expected. “pk” only peeks at the value — it does not modify it.
The goal of using “pk” was to help you figure out if the
Hi Ricardo,
I used this command but even this result with the colorless output.
> You need to use “./pre-inst-env guix” to use your modified version of
> Guix.
>
As per discussion in irc, I tried using "pk str" and "(pk
(string-append …))" to show values.
I dint find any differences with and
Hi Sahithi,
> Error disappeared but when i tried to rebuild hello, there were no
> errors at same time no colorful output even.
> I have attached the screen shot.
>
> Can you please check where I went wrong.
Could you tell me the full command you used?
--
Ricardo
Hi Sahithi,
> Please find my changes in the patch file attached.
Thanks. Could you please squash these changes and the previous commit?
This is easier for me to review.
Thanks for fixing the commit message!
>> You have probably noticed that this looks rather repetitive at this
>> point.
Sahitihi writes:
> I used the following commands.
>
> 1. ./pre-inst-env guix build hello
> 2. guix build --check --no-grafts hello
>
>> Could you tell me the full command you used?
>>
> Earlier I got error with first command regarding display. After
> correction to soft port that was fine.
>
Hi Ricardo,
I used the following commands.
1. ./pre-inst-env guix build hello
2. guix build --check --no-grafts hello
> Could you tell me the full command you used?
>
Earlier I got error with first command regarding display. After
correction to soft port that was fine.
Second command
Hi Sahithi,
> Patch file is attached with changes.
thanks.
I believe the error you reported on IRC comes from your definition of
“colorful-build-output-port”, which uses “current-error-port” instead of
“(current-error-port)”. Please correct this and then try again. I
expect the error to
Hi Ricardo,
Patch file is attached with changes.
I modified guix/scripts/build.scm
/(parameterize ((current-build-output-port (if quiet?//
// (%make-void-port
"w")//
//
Hi Ricardo,
Please find my changes in the patch file attached.
> (Generally, you really shouldn’t be developing things as
> “root”.)
>
This time I din't do it as root.
> For this commit a message like this would be appropriate:
Added a appropriate commit message.
> Please always add a
Hello!
Ricardo Wurmus skribis:
> I think these are enough hints. I’d be happy if you could try to
> implement a bit more than a single “if” expression and send us your
> draft implementation within the next few days. If you have questions
> please feel free to ask for help on #guile or #guix.
Hi Sahithi,
> I used /cond/ conditional and gave a try. This worked out with
> following line.[…]
Good.
Currently, you have always the same code that runs for any match.
Looking at my example you might be able to figure out how to apply a
different colour to different parts of the strings,
Hi Ricardo,
I used /cond/ conditional and gave a try. This worked out with
following line.
I also included string-match which also worked.
All I need to look for next step is to use regular expressions instead
of string.
> You also see that “if” alone is not sufficient here, because you have
Hi Sahithi,
> Hi Ricardo,
>
> I have worked with different possibilities
>> Now all you need to do is work on the “handle-string” procedure.
>>
>> I suggest using simpler matching procedures at first. To get started
>> try “string-prefix?” and use it with the string “starting phase”. This
>>
Hi Ricardo,
I have worked with different possibilities
> Now all you need to do is work on the “handle-string” procedure.
>
> I suggest using simpler matching procedures at first. To get started
> try “string-prefix?” and use it with the string “starting phase”. This
> won’t work with regular
Hi Sahithi,
do you have any questions about the next steps outlined in the email
below?
Cheers,
Ricardo
Ricardo Wurmus writes:
> Hi Sahithi,
>
>>> Have you started on working on this yet? If so,could you please give us
>>> an update on your progress via email?
>>>
>> I have started out
Hi Sahithi,
>> Have you started on working on this yet? If so,could you please give us
>> an update on your progress via email?
>>
> I have started out using different functions like
>
> |1) regexp-match 2) ||string-contains which resulted same output for
> strings
The procedures tell you if
Hi Ricardo,
Sorry for delay. Next time I will make sure to run conversation via
email as well.
> Have you started on working on this yet? If so,could you please give us
> an update on your progress via email?
>
I have started out using different functions like
|1) regexp-match 2)
30 matches
Mail list logo
