Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Am 19.09.2016 um 23:42 schrieb Leo Famulari: > Our packaging guidelines say that we should use the "project name chosen > upstream" [0], which in this case appears to be quickswitch-for-i3 [1]. The project itself is not consistent about this. While the title of the readme says "quickswitch-for-i3" the remaining text of the redme says "quickswitch-i3". The Readme also says that at PyPI and AUR teh project is both called "quickswitch-i3" -- Schönen Gruß Hartmut Goebel Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Implementer Information Security Management, Security Governance, Secure Software Development Goebel Consult, Landshut http://www.goebel-consult.de Blog: http://www.goebel-consult.de/blog/warum-sie-nicht-perl-programmiern-sollten Kolumne: http://www.cissp-gefluester.de/2012-02-bring-your-own-life-glosse smime.p7s Description: S/MIME Cryptographic Signature
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Leo Famulari (2016-09-19 17:39:37 -0400) wrote: > On Mon, Sep 19, 2016 at 11:24:02AM +0200, Ivan Vilata i Balaguer wrote: > > Thanks Leo and Brendan for your comments, I'm writing new versions > > of the packages following your suggestions, unfortunately I found > > out that ``quickswitch.py`` makes use of the Debian-specific > > ``which`` tool, so I'm also working on including a small patch > > (which I've also [reported][1] for completeness). More things to > > learn!`;)` > > `which` is not a Debian tool, and we do sometimes have to add it as an > input to packages. Our package name is 'which'. It might be enough to > just add the 'which' package to quickswitch-for-i3's inputs (or > native-inputs, if `which` is only used while building). > > www.gnu.org/software/which/ Oh my, I missed the actual ``which`` package, sorry! Anyway it's only used to check that ``dmenu`` is there, and the function that does the check is pretty broken anyway, causing other errors (see [my PR][1]). However I found a [simpler PR][2] that fixes all the errors and also does away with the dependency on ``which``, so I closed my PR and will use the latter. [1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28 [2]: https://github.com/proxypoke/quickswitch-for-i3/pull/24 Leo Famulari (2016-09-19 17:42:18 -0400) wrote: > On Mon, Sep 19, 2016 at 08:20:26PM +1000, Brendan Tildesley wrote: > > I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a > > better solution is to ensure "i3-py" in the description or synopsis > > so that `guix package -s' finds it. As for quickswitch, isn't the > > upstream name also simply "quickswitch-i3"? > > Our packaging guidelines say that we should use the "project name chosen > upstream" [0], which in this case appears to be quickswitch-for-i3 [1]. The PyPi package, the ``setup(name=...)`` argument in ``setup.py`` and the content of the readme use ``quickswitch-i3`` as the project short name, while the GitHub URL and readme title use "quickswitch for i3" as a more descriptive name. In this case I consider the former name to be the "official" short name, also compatible with ``pip`` and others. Is there any other similar case already in Guix? > And python-i3-py does follow our conventions for naming Python modules > [2]. > > [0] > https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html > > [1] > https://github.com/proxypoke/quickswitch-for-i3 > > [2] > https://www.gnu.org/software/guix/manual/html_node/Python-Modules.html So I can do a third iteration with the PR#24 patch and package names ``python-i3-py`` and ``quickswitch-i3``. What do you think? One more time, thanks for your help and comments! -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
On Mon, Sep 19, 2016 at 08:20:26PM +1000, Brendan Tildesley wrote: > I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a > better solution is to ensure "i3-py" in the description or synopsis so > that `guix package -s' finds it. As for quickswitch, isn't the upstream > name also simply "quickswitch-i3"? Our packaging guidelines say that we should use the "project name chosen upstream" [0], which in this case appears to be quickswitch-for-i3 [1]. And python-i3-py does follow our conventions for naming Python modules [2]. [0] https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html [1] https://github.com/proxypoke/quickswitch-for-i3 [2] https://www.gnu.org/software/guix/manual/html_node/Python-Modules.html
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
On Mon, Sep 19, 2016 at 11:28:09AM +0200, Ivan Vilata i Balaguer wrote: > Ivan Vilata i Balaguer (2016-09-19 11:24:02 +0200) wrote: > > > Thanks Leo and Brendan for your comments, I'm writing new versions of > > the packages following your suggestions, unfortunately I found out > > that ``quickswitch.py`` makes use of the Debian-specific ``which`` > > tool, so I'm also working on including a small patch (which I've also > > [reported][1] for completeness). More things to learn!`;)` > > > > [1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28 > > BTW, I'm considering whether I should keep ``python-i3-py`` and > ``quickswitch-for-i3`` in ``(gnu packages python)`` or I should rather > move them to ``(gnu packages wm)``, since their sole use is strongly > bound to the i3 window manager. Any suggestions? I think it makes sense to put them in (gnu packages wm).
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
On Mon, Sep 19, 2016 at 11:24:02AM +0200, Ivan Vilata i Balaguer wrote: > Thanks Leo and Brendan for your comments, I'm writing new versions of > the packages following your suggestions, unfortunately I found out that > ``quickswitch.py`` makes use of the Debian-specific ``which`` tool, so > I'm also working on including a small patch (which I've also > [reported][1] for completeness). More things to learn!`;)` `which` is not a Debian tool, and we do sometimes have to add it as an input to packages. Our package name is 'which'. It might be enough to just add the 'which' package to quickswitch-for-i3's inputs (or native-inputs, if `which` is only used while building). www.gnu.org/software/which/
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Leo Famulari 於 2016-09-16 15:46 寫道: > On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote: >> Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch. >> >> * gnu/packages/python.scm (i3-quickswitch): New variable. > Cool, this works :) > >> +(define-public i3-quickswitch >> + (package >> +(name "i3-quickswitch") > Again, I think that we should stay closer to the upstream name, in this > case "quickswitch-for-i3". I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a better solution is to ensure "i3-py" in the description or synopsis so that `guix package -s' finds it. As for quickswitch, isn't the upstream name also simply "quickswitch-i3"? >> +(build-system python-build-system) > Also again, it would be nice to include README.rst.
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Ivan Vilata i Balaguer (2016-09-19 11:24:02 +0200) wrote: > Thanks Leo and Brendan for your comments, I'm writing new versions of > the packages following your suggestions, unfortunately I found out > that ``quickswitch.py`` makes use of the Debian-specific ``which`` > tool, so I'm also working on including a small patch (which I've also > [reported][1] for completeness). More things to learn!`;)` > > [1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28 BTW, I'm considering whether I should keep ``python-i3-py`` and ``quickswitch-for-i3`` in ``(gnu packages python)`` or I should rather move them to ``(gnu packages wm)``, since their sole use is strongly bound to the i3 window manager. Any suggestions? Thanks, -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Leo Famulari (2016-09-16 01:46:37 -0400) wrote: > On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote: > > Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch. > > > > * gnu/packages/python.scm (i3-quickswitch): New variable. > > Cool, this works :) > > > +(define-public i3-quickswitch > > + (package > > +(name "i3-quickswitch") > > Again, I think that we should stay closer to the upstream name, in this > case "quickswitch-for-i3". > > > +(build-system python-build-system) > > Also again, it would be nice to include README.rst. Thanks Leo and Brendan for your comments, I'm writing new versions of the packages following your suggestions, unfortunately I found out that ``quickswitch.py`` makes use of the Debian-specific ``which`` tool, so I'm also working on including a small patch (which I've also [reported][1] for completeness). More things to learn!`;)` [1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28 -- Ivan Vilata i Balaguer -- https://elvil.net/
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote: > Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch. > > * gnu/packages/python.scm (i3-quickswitch): New variable. Cool, this works :) > +(define-public i3-quickswitch > + (package > +(name "i3-quickswitch") Again, I think that we should stay closer to the upstream name, in this case "quickswitch-for-i3". > +(build-system python-build-system) Also again, it would be nice to include README.rst. signature.asc Description: PGP signature
Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
On 2016-09-14 19:17, Ivan Vilata i Balaguer wrote: Welcome to Guix. I tested this out in i3 and it works just fine. I may end up using it. the latest version seems to be 2.2, but I see you commented on that on the github, as it is not in pypi yet. Do we prefer to use pypi or directly source upstream for packages? With 80k+ packages in pypi, I'm unsure. Someone else will need to review this as I don't have commit access.
