Hello!
Eric Bavier skribis:
> My suggestion would be to move those procedures back into (guix import
> pypi). I don't think they are as generic as their inclusion in (guix
> import utils) might suggest. The strings they accept are specific to
> pypi.
I’m late, but
On 2016-09-16 02:29, David Craven wrote:
I just wanted to point out that this will not work for any cpan
modules
that are destined for (gnu packages perl) if they don't use the Perl
license.
I think that gnu/packages/perl.scm should be updated to use the
license: prefix. I think that the
> AFAIK we haven't established module-level global symbol prefixing as best
> practice. In gnu/packages/perl.scm it's unnecessary.
It's a fact that if we don't establish a best practice, the (generic)
importer code won't fit all importer implementations. Maybe you could
have been a bit more
> I just wanted to point out that this will not work for any cpan modules
> that are destined for (gnu packages perl) if they don't use the Perl
> license.
I think that gnu/packages/perl.scm should be updated to use the
license: prefix. I think that the importer should suggest a best
practice.
On Tue, 30 Aug 2016 14:07:48 -0500
Eric Bavier wrote:
> On Sat, 27 Aug 2016 10:31:44 +0200
> David Craven wrote:
>
> > > Is the purpose of this patch to make importers return licenses with this
> > > prefix or is there another use case?
> >
> >
On Sat, 27 Aug 2016 10:31:44 +0200
David Craven wrote:
> > Is the purpose of this patch to make importers return licenses with this
> > prefix or is there another use case?
>
> Yes that's the intention. I was only thinking about the python
> importer, but this will affect all
> Is the purpose of this patch to make importers return licenses with this
> prefix or is there another use case?
Yes that's the intention. I was only thinking about the python
importer, but this will affect all importers.
David Craven writes:
> * guix/import/utils.scm (define-module): guix licenses import uses a prefix.
> (string->licenses): Add license: prefix to licenses.
> (license->symbol): Add license: prefix to licenses. Return a symbol with the
> prefix license:.
Nitpick: please
* guix/import/utils.scm (define-module): guix licenses import uses a prefix.
(string->licenses): Add license: prefix to licenses.
(license->symbol): Add license: prefix to licenses. Return a symbol with the
prefix license:.
---
guix/import/utils.scm | 26 +-
1 file