Re: [bug#29708] Update s-shell

[ng0]

宋文武 transcribed 0.9K bytes:
> ng0  writes:
> 
> > Ludovic Courtès transcribed 0.4K bytes:
> >> ng0  skribis:
> >> 
> >> > From cf2cbe9e9e525aa9dd697fcedb255a0fbc194ac9 Mon Sep 17 00:00:00 2001
> >> > From: ng0 
> >> > Date: Thu, 14 Dec 2017 13:22:58 +
> >> > Subject: [PATCH] s-shell: Update to commit
> >> >  da2e5c20c0c5f477ec3426dc2584889a789b1659.
> >> >
> >> > * gnu/packages/shells.scm (s-shell): Update to commit 
> >> > da2e5c20c0c5f477ec3426dc2584889a789b1659.
> >> > (version): Use 'git-version'.
> >> 
> >> I adjusted the commit log and pushed.
> >
> > Why is it [version]? Shouldn't it be (version)?
> > Even though [version] now makes sense, I've seen
> > mostly [] when it followed a () - and that's why
> > I've been using ()[] and never(?) [] on its own.
> 
> Here the top level is the same as previous line, so it can be ommited:
> 
>   * ... (s-shell): ...
>   [version]: ...
> 
> is same as:
> 
>   * ... (s-shell): ...
>   (s-shell)[version]: ...
> 

Makes sense. Thank you.
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is


signature.asc
Description: PGP signature

Re: [bug#29708] Update s-shell

[宋文武]

ng0  writes:

> Ludovic Courtès transcribed 0.4K bytes:
>> ng0  skribis:
>> 
>> > From cf2cbe9e9e525aa9dd697fcedb255a0fbc194ac9 Mon Sep 17 00:00:00 2001
>> > From: ng0 
>> > Date: Thu, 14 Dec 2017 13:22:58 +
>> > Subject: [PATCH] s-shell: Update to commit
>> >  da2e5c20c0c5f477ec3426dc2584889a789b1659.
>> >
>> > * gnu/packages/shells.scm (s-shell): Update to commit 
>> > da2e5c20c0c5f477ec3426dc2584889a789b1659.
>> > (version): Use 'git-version'.
>> 
>> I adjusted the commit log and pushed.
>
> Why is it [version]? Shouldn't it be (version)?
> Even though [version] now makes sense, I've seen
> mostly [] when it followed a () - and that's why
> I've been using ()[] and never(?) [] on its own.

Here the top level is the same as previous line, so it can be ommited:

  * ... (s-shell): ...
  [version]: ...

is same as:

  * ... (s-shell): ...
  (s-shell)[version]: ...

Re: [bug#29708] Update s-shell

[ng0]

Ludovic Courtès transcribed 0.4K bytes:
> ng0  skribis:
> 
> > From cf2cbe9e9e525aa9dd697fcedb255a0fbc194ac9 Mon Sep 17 00:00:00 2001
> > From: ng0 
> > Date: Thu, 14 Dec 2017 13:22:58 +
> > Subject: [PATCH] s-shell: Update to commit
> >  da2e5c20c0c5f477ec3426dc2584889a789b1659.
> >
> > * gnu/packages/shells.scm (s-shell): Update to commit 
> > da2e5c20c0c5f477ec3426dc2584889a789b1659.
> > (version): Use 'git-version'.
> 
> I adjusted the commit log and pushed.

Why is it [version]? Shouldn't it be (version)?
Even though [version] now makes sense, I've seen
mostly [] when it followed a () - and that's why
I've been using ()[] and never(?) [] on its own.

I haven't read HACKING or the chapter 'Contributing' in a while,
so you might be describing something that's already in there. If
it isn't, does it matter to agree on a fixed grammar for this?
I've come to appreciate the strong QA and checks, but what matters
is the content of the brackets, not the chosen form of brackets.
For ()[] it makes sense.

> Thanks!
> 
> Ludo’.
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is


signature.asc
Description: PGP signature