Re: Status of Submitted Patches

Hi Ricardo, > Here you are reading a character from the current input port. The > result is fed to “char-upcase”, which turns it into an upper-case > variant, and then you write that character to the current default output > port. > > While this achieves the goal for a single character it does

Re: Status of Submitted Patches

Hi Ricardo, > As a first change, could you please add the relevant parts of “(ice-9 > colorized)” to a module in Guix? We probably don’t want to depend on > having users install this module separately. We also don’t need all of > it. Please prepare a patch that adds only the relevant parts to

Patch file for colorize module

Hi Ricardo, Please find the attachment.. > Please attach the file of that same name in an email. Also add any corrections that i need too and next steps to proceed further. :) Thanks! -- Sahithi >From 93f3c964250587d6272065d555fa07e9bdd47325 Mon Sep 17 00:00:00 2001 From: root

Re: Patch file for colorize module

Sorry, Please find patch file attached to this mail. Kindly ignore the previous one. I have made a small change to Copyrights line to that of previous. > Hi Ricardo, > > Please find the attachment.. > >> Please attach the file of that same name in an email. > Also add any corrections that i need

Re: Patch file for colorize module

Hi Ricardo, Please find the attachment. Hope I made it correct this time. :) On Saturday 26 May 2018 03:05 PM, Ricardo Wurmus wrote: > git rebase -i > $start_commit >From 1bd9eaca576e7d958062197b9931d64c0882484e Mon Sep 17 00:00:00 2001 From: root Date: Sat, 26 May

Re: Status of Submitted Patches

Hi Ricardo, > Another note about style: I think it would be better to use > “alist->hash-table” instead of “make-hash-table” followed by repeated > modifications to the hash table with “hashq-set!”. We prefer to avoid > mutation of values when possible. I have made all necessary modifications.

Re: Status of Submitted Patches

Hi Ricardo, Done with changes and local commit > When you’re done with these changes, please make a local commit and send > the output of “git format-patch -1”. the following is the output of  “git format-patch -1” */0001-Added-Colorize-module-to-Guix-ui.scm.patch/* Can you please check and

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, When I used "(colorize-string "hello" '(GREEN))" in REPL that gave me a error unbound variable colorize-string When i used the same in attached file this gave me a colorless output However when I tried with "(colorize-string "hello" 'GREEN)" in same file this gave me colored output

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, > You should see the same as I did. This worked for me too. > To see what’s going on with your modifications to “(guix ui)” it would > help if you could go through your changes once more (use “git diff” to > be sure to inspect all the lines you have changed) and send your changes > to

Re: Fwd: Re: Patch file for colorize module

Hi Gábor, Updated patch is attached. > Could you send an updated patch? --- Thanks!! Sahithi. >From 765035232a43f09a5c3dbecf77c90499dd1473d4 Mon Sep 17 00:00:00 2001 From: Sahithi Yarlagadda Date: Tue, 5 Jun 2018 00:08:32 +0530 Subject: [PATCH] guix: Add coloring soft port. * guix/ui.scm

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, Text file is attached with all changes I added including colorize module. The changes added to build.scm is (/(parameterize ((current-build-output-port  colorful-build-output-port)) /) > Please send me the complete changes as a text file, so that I can apply > it to my copy of the

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, I used this command but even this result with the colorless output. > You need to use “./pre-inst-env guix” to use your modified version of > Guix. > As per discussion in irc, I tried using "pk str" and  "(pk (string-append …))" to show values. I dint find any differences with and

Re: Next steps

Hi Ricardo, Patch file is attached with the following changes. > Excellent, this looks better. Unfortunately, your patch includes a > couple of unrelated indentation changes. Please remove those. > > 2) Fixing the other soft port procedures As described I will proceed on with next steps and

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, > I cannot seem to apply the patch onto either the “wip-sahithi” or > “master” branches. Could you rebase your changes on top of the > “wip-sahithi” branch, please? If that turns out to be too difficult, > please rebase the changes on top of the current “master” branch after >

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, I have fixed the errors mentioned bellow, Please do check and notify me for further modifications. >>> The next steps are to fix the errors in the regular expressions that >>> swallow certain space characters and to re-read the documentation of >>> “make-soft-port” to make sure that

Re: Patch file for colorize module

I went wrong in squashing. Please check the current attachment. > Hi Ricardo, > >> I’d be happy if you could make these changes quickly and send an updated >> patch. Once I receive it I’ll push it to a branch “wip-sahithi” in the >> repository. >> > I have made the above changes. Please notify

Re: Patch file for colorize module

Hi Ricardo, > I’d be happy if you could make these changes quickly and send an updated > patch. Once I receive it I’ll push it to a branch “wip-sahithi” in the > repository. > I have made the above changes. Please notify if i have to make further changes. I mean while, I will be trying out

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, Sorry for delay. Next time I will make sure to run conversation via email as well. > Have you started on working on this yet? If so,could you please give us > an update on your progress via email? > I have started out using different functions like |1) regexp-match 2)

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, I have worked with different possibilities > Now all you need to do is work on the “handle-string” procedure. > > I suggest using simpler matching procedures at first. To get started > try “string-prefix?” and use it with the string “starting phase”. This > won’t work with regular

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, I used /cond/ conditional  and gave a try. This worked out with following line. I also included string-match which also worked. All I need to look for next step is to use regular expressions instead of string. > You also see that “if” alone is not sufficient here, because you have

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, I used the following commands. 1.  ./pre-inst-env guix build hello 2.  guix build --check --no-grafts hello > Could you tell me the full command you used? > Earlier I got error with first command regarding display. After correction to soft port that was fine. Second command

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, Please find my changes in the patch file attached. > (Generally, you really shouldn’t be developing things as > “root”.) > This time I din't do it as root. > For this commit a message like this would be appropriate: Added a appropriate commit message. > Please always add a

Re: Fwd: Re: Patch file for colorize module

Hi Ricardo, Patch file is attached with changes. I modified guix/scripts/build.scm    /(parameterize ((current-build-output-port (if quiet?// // (%make-void-port "w")// // 

Introducing myself as an Outreachy Intern

Hi all, I Sahithi Yarlagadda, a Free Software enthusiast. I am from India, pursuing my under graduation final semester in Computer Science. I will be working as an Outreachy Intern for May-August 2018. I am glad to be part of Guix Community. I have been working with Ricardo Wurmus during the