Giovanni Biscuolo writes:
> [[PGP Signed Part:Signature made by expired key D37D0EA7CECC3912 Giovanni
> Biscuolo (Xelera) ]]
> Hi,
>
> Giovanni Biscuolo writes:
>
> [...]
>
The first thing we need is a server side git post-receive hook on
Savannah, I've opened the sr#110928 support
Hi Vagrant,
Vagrant Cascadian writes:
[...]
> This is why I think it is important for projects to have some sort of
> namespacing for this sort of thing; I am not really opinionated on the
> exact details, other than it not conflicting with Debian's terribly
> generic entirely un-namespaced
On 2023-09-14, Giovanni Biscuolo wrote:
> Maxim Cournoyer writes:
>> I like the 'Closes: ' trailer idea; it's simple. However, it'd need to
>> be something added locally, either the user typing it out (unlikely for
>> most contributors) or via some mumi wizardry (it's unlikely that all
>> users
On 2023-09-15, Liliana Marie Prikler wrote:
> Am Donnerstag, dem 14.09.2023 um 15:51 -0700 schrieb Vagrant Cascadian:
>> On 2023-09-10, Liliana Marie Prikler wrote:
>> > Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant
>> > Cascadian:
>> > > I am much more comfortable with the "Fixes"
Hi Giovanni,
Before commenting, let me repeat. ;-)
That’s said, I am not against the proposal. I just have mixed
feelings and before deploying I strongly suggest to review if
the proposal covers the intent.
On Fri, 15 Sep 2023 at 09:16, Giovanni Biscuolo wrote:
>
Hello Simon,
thank you for havig listed possible troubles.
Before commenting, just let me repeat that we are _copying_ the
'Change-Id' idea (and related possible implementation issues) from
Gerrit:
https://gerrit-review.googlesource.com/Documentation/user-changeid.html
This means that
Am Donnerstag, dem 14.09.2023 um 15:51 -0700 schrieb Vagrant Cascadian:
> On 2023-09-10, Liliana Marie Prikler wrote:
> > Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant
> > Cascadian:
> > > I am much more comfortable with the "Fixes" convention of:
> > >
> > > Fixes:
On 2023-09-10, Liliana Marie Prikler wrote:
> Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant Cascadian:
>> I am much more comfortable with the "Fixes" convention of:
>>
>> Fixes: https://issues.guix.gnu.org/NNN
> I like the idea, but we should also consider the bugs.gnu.org
Hello,
Le 14 septembre 2023 12:30:41 GMT-04:00, Vagrant Cascadian
a écrit :
[…]
>> I doubt the Change-Id idea would help much closing *bugs* on the
>> bug-guix tracker, but I'd expect it to be useful to close already merged
>> (but forgotten on the guix-patches tracker) *patches*.
>
>Well,
Am Donnerstag, dem 14.09.2023 um 11:42 +0200 schrieb Giovanni Biscuolo:
> OK! :-) Let's see how this relates to the 2 use cases we are talking
> about:
>
> 1. Use "Fixes:" (et al) in commit msg to tell "the hook" to close the
> bug.
>
> This "action" implies that the commit we are pushing
Hi,
On Thu, 14 Sep 2023 at 12:27, Giovanni Biscuolo wrote:
> Please can you expand what troubles do you see in automatically adding
> 'Change-Id:' using a hook-commit-msg like
> https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html
> ?
1. The hook must be installed.
2.
On 2023-09-13, Maxim Cournoyer wrote:
> Vagrant Cascadian writes:
>> On 2023-09-09, Maxim Cournoyer wrote:
>>> The Change-Id stays the same unless you manually edit it out of your
>>> commit message when amending / rebasing, so the commit hash may change
>>> while the Change-Id stays the same.
Maxim Cournoyer writes:
[...]
> I like the 'Closes: ' trailer idea; it's simple. However, it'd need to
> be something added locally, either the user typing it out (unlikely for
> most contributors) or via some mumi wizardry (it's unlikely that all
> users will use mumi), which means its usage
Simon Tournier writes:
[...]
>> maybe ChangeIds really trump the explicit tags proposed by Giovanni
>> or myself here. Whether that justifies the cognitive overhead of
>> juggling them around on every submission remains to be shown or
>> disproven.
>
> I agree. I am not convinced by the
Hi Liliana
Liliana Marie Prikler writes:
> Am Mittwoch, dem 13.09.2023 um 11:27 -0400 schrieb Maxim Cournoyer:
[...]
> I do wonder how the ChangeId would work in practice.
It's a «tag to track commits across cherry-picks and rebases.»
It is used by Gerrit to identify commits that belong to
Hi Maxim and Vagrant,
I'm sorry for some of the inconprehensions.
Finally I think we got a useful design overall for the _two_ user cases
and the related pieces of metadata and algorithms, now it's time for
_two_ implementations proposals, that also means _code_...
If nihil obstat, I'm going to
Hello,
Am Wed, Sep 13, 2023 at 09:14:52PM +0200 schrieb Liliana Marie Prikler:
> I do wonder how the ChangeId would work in practice. Since it's not
> really assigned by the committer, it would have to be generated "on the
> fly" and attached to the mail in between, which could result in all
>
Hi,
Simon Tournier writes:
> Hi,
>
> On Wed, 13 Sep 2023 at 21:14, Liliana Marie Prikler
> wrote:
>
>> I do wonder how the ChangeId would work in practice. Since it's not
>> really assigned by the committer, it would have to be generated "on the
>> fly" and attached to the mail in between,
Hi,
On Wed, 13 Sep 2023 at 21:14, Liliana Marie Prikler
wrote:
> I do wonder how the ChangeId would work in practice. Since it's not
> really assigned by the committer, it would have to be generated "on the
> fly" and attached to the mail in between, which could result in all
> kinds of nasty
Am Mittwoch, dem 13.09.2023 um 11:27 -0400 schrieb Maxim Cournoyer:
> For just closing cross-referenced bugs, I agree. For closing
> forgotten, already merged issues on guix-patches we'd need the
> Change-Id and a tool able to map Change-Ids -> issue number (mumi is
> in the best place to do so).
Hi,
Vagrant Cascadian writes:
> On 2023-09-09, Maxim Cournoyer wrote:
>> Vagrant Cascadian writes:
Did you see my message about integrating a commit-hook similar to what
Gerrit uses? It produces unique ID such as:
--8<---cut
Hi Liliana,
Liliana Marie Prikler writes:
> Hi Maxim,
>
> Am Montag, dem 11.09.2023 um 16:41 -0400 schrieb Maxim Cournoyer:
>> [...]
>> Perhaps both approach[es] could be combined. I still see value in a
>> general scheme to automate closing applied series that linger on in
>> Debbugs.
>>
>>
Hi Giovanni,
Giovanni Biscuolo writes:
[...]
Liliana Marie Prikler writes:
>
> WDYT about the following
> Applies: [patch]
> Closes: [patch]
> Resolves: [patch]
> Done: [patch]
[...]
> Anyway, I agree with Liliana that having more keyworks will help
Hi Liliana and Maxim,
Liliana Marie Prikler writes:
[...]
> The thing is, we're discussing the same basic workflow
No, we are discussing two (complementary) workflows:
1. the one I suggested to add a "footer-metadata-field" named
Fix/Fixes/Close/Closes/whatever that will allow people pushing
On 2023-09-09, Maxim Cournoyer wrote:
> Vagrant Cascadian writes:
>>> Did you see my message about integrating a commit-hook similar to what
>>> Gerrit uses? It produces unique ID such as:
>>>
>>> --8<---cut here---start->8---
>>> Change-Id:
Hi Maxim,
Am Montag, dem 11.09.2023 um 16:41 -0400 schrieb Maxim Cournoyer:
> [...]
> Perhaps both approach[es] could be combined. I still see value in a
> general scheme to automate closing applied series that linger on in
> Debbugs.
>
> [0]
>
Hi Maxim and Liliana,
Maxim Cournoyer writes:
>>> Liliana Marie Prikler writes:
>>> > WDYT about the following
>>> > Applies: [patch]
>>> > Closes: [patch]
>>> > Resolves: [patch]
>>> > Done: [patch]
[...]
>> I'm just asking which wording you prefer. For the tracker, they'd
Hi Liliana,
Liliana Marie Prikler writes:
> Am Montag, dem 11.09.2023 um 14:36 -0400 schrieb Maxim Cournoyer:
>> Hi,
>>
>> Liliana Marie Prikler writes:
>>
>> [...]
>>
>> > Maybe make that bug-guix so that it matches with the mailing list
>> > name,
>> > though we also need a wording for when
Am Montag, dem 11.09.2023 um 14:36 -0400 schrieb Maxim Cournoyer:
> Hi,
>
> Liliana Marie Prikler writes:
>
> [...]
>
> > Maybe make that bug-guix so that it matches with the mailing list
> > name,
> > though we also need a wording for when a patch is not a bug, e.g. a
> > simple package
Hi,
Liliana Marie Prikler writes:
[...]
> Maybe make that bug-guix so that it matches with the mailing list name,
> though we also need a wording for when a patch is not a bug, e.g. a
> simple package upgrade.
>
> WDYT about the following
> Applies: [patch]
> Closes: [patch]
>
Am Montag, dem 11.09.2023 um 10:09 +0200 schrieb Giovanni Biscuolo:
> Hi!
>
> Liliana Marie Prikler writes:
>
> > Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant
> > Cascadian:
> > > I am much more comfortable with the "Fixes" convention of:
> > >
> > > Fixes:
Hi Maxim,
Maxim Cournoyer writes:
[...]
>> If there is enough consensus I volunteer to collect ideas and send a
>> feature request to the mumi and/or Debbugs devels (if we need Debbugs
>> patches I guess it will be a long term goal)
>
> I don't think any changes to Debbugs would be necessary.
Hi,
Simon Tournier writes:
> Hi Maxim,
>
> Thanks for the explanations.
>
> On Mon, 11 Sept 2023 at 15:47, Maxim Cournoyer
> wrote:
>
>> > 2. How is Change-Id linked to #65280?
>>
>> Each patch submission ("issue") can have one or multiple commits. We'd
>> know for sure the series was merged
Hi Maxim,
Thanks for the explanations.
On Mon, 11 Sept 2023 at 15:47, Maxim Cournoyer
wrote:
> > 2. How is Change-Id linked to #65280?
>
> Each patch submission ("issue") can have one or multiple commits. We'd
> know for sure the series was merged (and thus can be closed) when the
> set of
Hi Giovanni,
Giovanni Biscuolo writes:
> Hi Maxim,
>
> Maxim Cournoyer writes:
>
> [...]
>
>>> c. how do we get the issue number of a patch containing "Change-Id"? [1]
>>
>> We'd have to search through the currently opened patches issues; I
>> assume using a tool like the 'mumi' command we
Hi Giovanni,
Giovanni Biscuolo writes:
> Hi!
>
> Liliana Marie Prikler writes:
>
>> Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant Cascadian:
>>> I am much more comfortable with the "Fixes" convention of:
>>>
>>> Fixes: https://issues.guix.gnu.org/NNN
>
> OK, I understand
Hi Simon,
Simon Tournier writes:
> Hi Maxim,
>
> On Sat, 09 Sep 2023 at 19:50, Maxim Cournoyer
> wrote:
>
--8<---cut here---start->8---
random=$({ git var GIT_COMMITTER_IDENT ; echo "$refhash" ; cat "$1"; } |
git hash-object --stdin)
Hi Maxim,
On Sat, 09 Sep 2023 at 19:50, Maxim Cournoyer wrote:
>>> --8<---cut here---start->8---
>>> random=$({ git var GIT_COMMITTER_IDENT ; echo "$refhash" ; cat "$1"; } |
>>> git hash-object --stdin)
>>> --8<---cut
Hi!
Liliana Marie Prikler writes:
> Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant Cascadian:
>> I am much more comfortable with the "Fixes" convention of:
>>
>> Fixes: https://issues.guix.gnu.org/NNN
OK, I understand Vagrant's concerns: we need a _namespaced_ URI, but
there
Hi Maxim,
Maxim Cournoyer writes:
[...]
>> c. how do we get the issue number of a patch containing "Change-Id"? [1]
>
> We'd have to search through the currently opened patches issues; I
> assume using a tool like the 'mumi' command we already have could do
> that.
It would be fantastic if we
Am Donnerstag, dem 07.09.2023 um 09:12 -0700 schrieb Vagrant Cascadian:
> I am much more comfortable with the "Fixes" convention of:
>
> Fixes: https://issues.guix.gnu.org/NNN
I like the idea, but we should also consider the bugs.gnu.org address
here as well as the convention of putting it into
Hi Vagrant,
Vagrant Cascadian writes:
[...]
>> Did you see my message about integrating a commit-hook similar to what
>> Gerrit uses? It produces unique ID such as:
>>
>> --8<---cut here---start->8---
>> Change-Id: I9b86781869d80eda347659f0c009b8dfe09bdfd0
Hi Simon,
Simon Tournier writes:
> Hi,
>
> On Wed, 06 Sep 2023 at 22:01, Maxim Cournoyer
> wrote:
>
>> We could use Gerrit's commit hook that adds a unique ID as a git
>> trailer. Then it should become possible to
>
> Do we still already have Gerrit running?
I was not suggesting to host
Hi Giovanni,
Giovanni Biscuolo writes:
[...]
>> We could use Gerrit's commit hook that adds a unique ID as a git
>> trailer.
>
> Do you mean "commit-msg" hook as documented here:
> https://gerrit-review.googlesource.com/Documentation/cmd-hook-commit-msg.html
> ?
>
>
> The Gerrit Code Review
Hi Vagrant!
On Thu, Sep 7, 2023 at 9:13 AM Vagrant Cascadian wrote:
>
> So... I maintain the guix package in Debian, and want to make sure
> that whatever bug-closing indicator guix upstream uses, does not end up
> triggering when I push new upstream versions to salsa.debian.org ... and
>
On 2023-09-07, Giovanni Biscuolo wrote:
> Hi Maxim and Ludovic,
> Maxim Cournoyer writes:
>> Giovanni Biscuolo writes:
..
>>> When I asket I though the best way would be to scan for a string like
>>> "Close #" in the commit message (the committer should add
>>> such a string) but probably this
On 2023-09-07, Maxim Cournoyer wrote:
> Felix Lechner writes:
>> On Thu, Sep 7, 2023 at 4:08 AM Giovanni Biscuolo wrote:
>>>
>>> close the bugs that are listed in
>>> the commit message
...
> Did you see my message about integrating a commit-hook similar to what
> Gerrit uses? It produces
Hi,
On Wed, 06 Sep 2023 at 22:01, Maxim Cournoyer wrote:
> We could use Gerrit's commit hook that adds a unique ID as a git
> trailer. Then it should become possible to
Do we still already have Gerrit running?
Cheers,
simon
Hi,
Giovanni Biscuolo writes:
[...]
>>> The first thing we need is a server side git post-receive hook on
>>> Savannah, I've opened the sr#110928 support request:
>>> https://savannah.nongnu.org/support/index.php?110928
>>
>> It's something that the Savannah folks would need to maintain
>>
Hi Felix,
Felix Lechner writes:
> Hi Gio',
>
> On Thu, Sep 7, 2023 at 4:08 AM Giovanni Biscuolo wrote:
>>
>> close the bugs that are listed in
>> the commit message
>
> Perhaps you'd like to see Debian's hook [1] for the Salsa web forge
> (which is controversially based on Gitlab).
[...]
Hi Maxim,
Maxim Cournoyer writes:
> Simon Tournier writes:
[...]
>> Maybe patchwork already running (I think) could help, trying to
>> regularly rebase the branch dedicated to the submission on the top of
>> master, then if all is fine, somehow the two heads from the master
>> branch and the
Hi,
Felix Lechner writes:
> Hi Gio',
>
> On Thu, Sep 7, 2023 at 4:08 AM Giovanni Biscuolo wrote:
>>
>> close the bugs that are listed in
>> the commit message
>
> Perhaps you'd like to see Debian's hook [1] for the Salsa web forge
> (which is controversially based on Gitlab).
>
> The regex
Hi Gio',
On Thu, Sep 7, 2023 at 4:08 AM Giovanni Biscuolo wrote:
>
> close the bugs that are listed in
> the commit message
Perhaps you'd like to see Debian's hook [1] for the Salsa web forge
(which is controversially based on Gitlab).
The regex does not work properly for more than two bugs,
Hi Simon,
Simon Tournier writes:
> On Wed, 06 Sep 2023 at 12:14, Maxim Cournoyer
> wrote:
>
>>> Let's avoid manual gardening as much as possible! :-)
>>
>> I like the idea!
>
> I think that automatizing is not trivial. Sadly.
If we "restrict" the automation to "close the bugs that are
Hi Maxim and Ludovic,
I'm including you, Ludovic, becaus in the past you requested a similar
git hook installation for Guix and maybe you have more info
Maxim Cournoyer writes:
> Giovanni Biscuolo writes:
[...]
OK, I really found the wrong examples as Christopher pointed out, but my
Hi,
Simon Tournier writes:
> Hi,
>
> On Wed, 06 Sep 2023 at 12:14, Maxim Cournoyer
> wrote:
>
>>> Let's avoid manual gardening as much as possible! :-)
>>
>> I like the idea!
>
> I think that automatizing is not trivial. Sadly.
>
> There are many corner cases:
>
> 1. series as attachement
>
Hi,
On Wed, 06 Sep 2023 at 12:14, Maxim Cournoyer wrote:
>> Let's avoid manual gardening as much as possible! :-)
>
> I like the idea!
I think that automatizing is not trivial. Sadly.
There are many corner cases:
1. series as attachement
2. not all the series is applied
3. commit message
Hi Giovanni,
Giovanni Biscuolo writes:
> Hello,
>
> often bug reports related to patches are left open even after the
> patch/patchset have been applied, the last example is a batch of Debbugs
> manual gardening from Vagrant last Fri and Sat when he closed more than
> 20 bugs with messages
Giovanni Biscuolo writes:
> Hello,
>
> often bug reports related to patches are left open even after the
> patch/patchset have been applied, the last example is a batch of Debbugs
> manual gardening from Vagrant last Fri and Sat when he closed more than
> 20 bugs with messages similar to this
59 matches
Mail list logo
