Re: [hackers] [dwm][PATCH] grabkeys: Avoid missing events when a keysym maps to multiple keycodes

2022-12-07 Thread Chris Down
Hiltjo Posthuma writes: Thanks for the patch, I will probably look at it further this weekend. Thanks for looking! :-) Should syms be checked before XFree(syms) or can the return value not be NULL? I was going to say that it's not possible even with a race with a new mapping, since XDispla

Re: [hackers] [dwm][PATCH] grabkeys: Avoid missing events when a keysym maps to multiple keycodes

2022-12-07 Thread Hiltjo Posthuma
On Mon, Dec 05, 2022 at 11:01:12PM +, Chris Down wrote: > It's not uncommon for one keysym to map to multiple keycodes. For > example, the "play" button on my keyboard sends keycode 172, but my > bluetooth headphones send keycode 208, both of which map back to > XF86AudioPlay: > > % xmodma

[hackers] [dwm][PATCH] grabkeys: Avoid missing events when a keysym maps to multiple keycodes

2022-12-05 Thread Chris Down
It's not uncommon for one keysym to map to multiple keycodes. For example, the "play" button on my keyboard sends keycode 172, but my bluetooth headphones send keycode 208, both of which map back to XF86AudioPlay: % xmodmap -pke | grep XF86AudioPlay keycode 172 = XF86AudioPlay XF86AudioPau