Re: [hackers] [quark] Initial commit of quark rewrite || FRIGN

2016-09-02 Thread Hiltjo Posthuma
On Fri, Sep 02, 2016 at 12:37:00PM +0100, Nick wrote: > Hi FRIGN, > > I don't have time to look at this closely now, but one little thing > that jumped out at me: > > > +static const struct { > > + char *ext; > > + char *type; > > +} mimes[] = { > > ... > > Why are you defining the struct

Re: [hackers] [quark] Initial commit of quark rewrite || FRIGN

2016-09-02 Thread Nick
Hi FRIGN, I don't have time to look at this closely now, but one little thing that jumped out at me: > +static const struct { > + char *ext; > + char *type; > +} mimes[] = { > ... Why are you defining the struct in config.def.h? Shouldn't it be defined in quark.c, and then just

[hackers] [quark] Initial commit of quark rewrite || FRIGN

2016-09-02 Thread git
commit 0ce86bba1549408a490f2ac8f97fc948323a9418 Author: FRIGN AuthorDate: Fri Sep 2 09:59:02 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 09:59:02 2016 +0200 Initial commit of quark rewrite Roughly 700 LOC (half of the old quark on the Hiltjo