Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Roberto E. Vargas Caballero
> > Does it seem reasonable? > > Yup. Indeed -- Roberto E. Vargas Caballero

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Dimitris Papastamos
On Tue, Jun 03, 2014 at 07:44:49PM +0200, Roberto E. Vargas Caballero wrote: > > but -p is specifically used to tell login whether to preserve or discard > > the parent environment. What happens if -p is not set? I decided to put > > TERM=linux because ubase is linux specific. > > I think -p is

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread FRIGN
On Tue, 3 Jun 2014 18:51:19 +0100 Dimitris Papastamos wrote: > Does it seem reasonable? Yup. -- FRIGN

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Roberto E. Vargas Caballero
> but -p is specifically used to tell login whether to preserve or discard > the parent environment. What happens if -p is not set? I decided to put > TERM=linux because ubase is linux specific. I think -p is only suitable for values that can be obtained from /etc/passwd, for example HOME or SHE

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread FRIGN
On Tue, 3 Jun 2014 19:35:22 +0200 "Roberto E. Vargas Caballero" wrote: > login takes the value of TERM from its parent. If you executed login > in a telnet session, the telnet daemon will put the value. If you > have a SystemV inittab, then you configure in it the correct value of > TERM for ever

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Dimitris Papastamos
On Tue, Jun 03, 2014 at 07:35:22PM +0200, Roberto E. Vargas Caballero wrote: > > Would vt100 be more sensible? Thing is if preserve == 0 we'll end up > > with TERM unset (for login specifically). > > login takes the value of TERM from its parent. If you executed login > in a telnet session, the t

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Roberto E. Vargas Caballero
> Would vt100 be more sensible? Thing is if preserve == 0 we'll end up > with TERM unset (for login specifically). login takes the value of TERM from its parent. If you executed login in a telnet session, the telnet daemon will put the value. If you have a SystemV inittab, then you configure in i

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Dimitris Papastamos
On Tue, Jun 03, 2014 at 07:25:39PM +0200, Roberto E. Vargas Caballero wrote: > > Set TERM to linux if needed for su and login > > I think this is incorrect. If you don't have a value of TERM, then > you should don't put anything, or put dumb, but why linux?, you > expect login will be executed

Re: [hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread Roberto E. Vargas Caballero
> Set TERM to linux if needed for su and login I think this is incorrect. If you don't have a value of TERM, then you should don't put anything, or put dumb, but why linux?, you expect login will be executed only in virtual terminals?. Regards, -- Roberto E. Vargas Caballero

[hackers] [ubase] Set TERM to linux if needed for su and login || sin

2014-06-03 Thread git
commit 916b7fed1e5575792a5db6a9340a56ce014b1ecb Author: sin Date: Tue Jun 3 18:19:31 2014 +0100 Set TERM to linux if needed for su and login diff --git a/login.c b/login.c index 4d74dd1..fa01371 100644 --- a/login.c +++ b/login.c @@ -117,6 +117,7 @@ dologin(struct passwd *pw, int preserve)