Re: [hackers] [dwm][patch] uselessgap fix

2021-11-21 Thread Hiltjo Posthuma
This doesn't below here, but on the wiki. You can push it yourself to the wiki repository as described on the wiki page. On Sun, Nov 21, 2021 at 11:42:05AM +0100, thim wrote: > The inner gap between the master and slave stack is currently double of > whatever the gappx variable is. This should

Re: [hackers] [sbase][PATCH] nohup: Open nohup.out WRONLY

2021-10-23 Thread Michael Forney
Thanks for the patch, and sorry for the delay. Applied now.

Re: [hackers] [sbase][PATCH] nohup: Open nohup.out WRONLY

2021-10-23 Thread Quentin Rameau
Hi Arthur, > Open nohup.out write-only instead of not specifying the access permissions > instead of getting undefined behavior (which probably results in stdout > not being writable). > > - if ((fd = open("nohup.out", O_APPEND | O_CREAT, S_IRUSR | > S_IWUSR)) < 0) > +

Re: [hackers] Re: [PATCH sxmo-utils 2/2] added some systemctl commands to doas.conf for compatibility with systemd distros like Arch

2021-10-22 Thread NRK
On Fri, Oct 22, 2021 at 05:34:16PM +0200, Maarten van Gompel wrote: > Please ignore... https://i.postimg.cc/66cm9f5t/image.png - NRK

Re: [hackers] [surf][patch] Use signed chars for webext messages.

2021-10-18 Thread Quentin Rameau
Hello Noah, > Plain chars are currently used for messaging, but sometimes negative values > are sent, e.g. in scrollv. on x86 this doesn't cause a problem but chars are > unsigned on my arm computer. Thanks, I'll apply that soon.

Re: [hackers] [PATCH svkbd] Fix color scheme editing on smiley with Xresources

2021-10-09 Thread Hiltjo Posthuma
On Fri, Oct 08, 2021 at 09:38:22PM +0200, Maarten van Gompel wrote: > From: Justin Torres > > Fixes a small oversight that was preventing the colors of the smiley on q > from changing with Xresources. > > Signed-off-by: Maarten van Gompel > --- > svkbd.c | 8 > 1 file changed, 4

Re: [hackers] [svkbd][PATCH] create layout-dependent object files

2021-10-01 Thread Hiltjo Posthuma
On Thu, Sep 30, 2021 at 09:36:53PM +0200, Max Schillinger wrote: > When you build svkbd with different layouts, you get one binary per > layout but all binaries are identical: > > $ make LAYOUT=mobile-plain > $ make LAYOUT=mobile-simple > $ diff -s svkbd-mobile-plain

Re: [hackers] [quark][PATCH 1/7] arg.h: visual separation for blocks

2021-09-13 Thread Laslo Hunhold
On Sun, 4 Jul 2021 20:54:53 +0500 Nikita Zlobin wrote: Dear Nikita, > thanks for your patchset, but I will not merge it, given it just consists of style changes which I do not approve of. Regarding NULL, using it would require importing something like stddef.h, which can be avoided by just

Re: [hackers] [st][PATCH 1/1] fix a problem that the standard streams are unexpectedly closed

2021-08-24 Thread Hiltjo Posthuma
On Tue, Aug 24, 2021 at 06:25:05AM +0900, Koichi Murase wrote: > In the current implementation, the slave PTY (assigned to the variable > `s') is always closed after duplicating it to file descriptors of > standard streams (0, 1, and 2). However, when the allocated slave PTY > `s' is already one

Re: [hackers] [st][PATCH] fix a problem that the standard streams are unexpectedly closed

2021-08-23 Thread Koichi Murase
Alex, Thank you for your advice! 2021年8月20日(金) 10:56 Alex Pilon : > > Fix: > > > > I attach a patch file: > > > > - st-DontCloseStandardStreamsUnexpectedly-20210819-2ec571a.diff > > Normally people are expected to git send-email or compatible, just like > on the Linux kernel ML, not attach

Re: [hackers] [dwm][PATCH] Fix wrong computation in drw_text

2021-08-19 Thread Viktor Grigorov
This results in 1-character elements being unrendered. I was wondering why two of my surfraw elvi were blank, they just were getting drawn. Aug 16, 2021, 20:17 by suckl...@jochen.sprickerhof.de: > From: Jochen Sprickerhof > > In case lpad * 2 > w, w - lpad * 2 wraps around and comparing it

Re: [hackers] [dwm][PATCH] Fix wrong computation in drw_text

2021-08-19 Thread Hiltjo Posthuma
On Thu, Aug 19, 2021 at 05:30:14AM +0200, Viktor Grigorov wrote: > This results in 1-character elements being unrendered. > I was wondering why two of my surfraw elvi were blank, they just were getting > drawn. > > Aug 16, 2021, 20:17 by suckl...@jochen.sprickerhof.de: > > > From: Jochen

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Mon, 16 Aug 2021 19:30:03 +0600 NRK wrote: Dear NRK, > Fair enough. I suppose it should be better fit as a user patch in the > wiki then? I personally don't think that this makes sense as a user-patch, given there's maintenance involved and such a change usually just leads to failed hunks

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread NRK
On Mon, Aug 16, 2021 at 10:28:36AM +0200, Hiltjo Posthuma wrote: > Thanks for the patch. I'd rather not add another option for it. > > I think if the default is not changed it still makes sense. Either way the > option works as documented. Fair enough. I suppose it should be better fit as a user

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Mon, 16 Aug 2021 10:28:36 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > Thanks for the patch. I'd rather not add another option for it. > > I think if the default is not changed it still makes sense. Either > way the option works as documented. I understand, it's your call as the maintainer.

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Hiltjo Posthuma
On Sun, Aug 15, 2021 at 11:44:58PM +0600, NRK wrote: > currently config.h allows users to set the value of topbar to 0. > however if one does that, there's no way for him to get a topbar again. > it makes more sense to have -b as a toggle instead. > > - NRK Hi, Thanks for the patch. I'd rather

Re: [hackers] [dmenu][PATCH] turn -b into a toggle

2021-08-16 Thread Laslo Hunhold
On Sun, 15 Aug 2021 23:44:58 +0600 NRK wrote: Dear NRK, > currently config.h allows users to set the value of topbar to 0. > however if one does that, there's no way for him to get a topbar > again. it makes more sense to have -b as a toggle instead. this trades one problem for another given

Re: [hackers] A very unconventional unit testing library

2021-08-11 Thread Mattias Andrée
Hi Thomas, On Wed, 11 Aug 2021 13:42:25 +0200 Thomas Oltmann wrote: > Hi Andrée, > > Am Mi., 11. Aug. 2021 um 13:12 Uhr schrieb Mattias Andrée : > > This looks like a very neat test framework. I would however like > > the file name to be printed in addition to line number as the > > test can

Re: [hackers] A very unconventional unit testing library

2021-08-11 Thread Thomas Oltmann
Hi Andrée, Am Mi., 11. Aug. 2021 um 13:12 Uhr schrieb Mattias Andrée : > This looks like a very neat test framework. I would however like > the file name to be printed in addition to line number as the > test can cover multiple files: the file with the tests and files > with utilities functions,

Re: [hackers] Re: [dmenu][patch] Improve speed of drw_text when provided with large strings

2021-08-09 Thread Hiltjo Posthuma
On Sat, Aug 07, 2021 at 09:39:44PM -0400, Miles Alan wrote: > On Sat, Aug 7, 2021, at 9:34 PM, m...@milesalan.com wrote: > > - for (len = MIN(utf8strlen, sizeof(buf) - 1); len && ew > > > w; len--) > > - drw_font_getexts(usedfont, utf8str, len, , > >

Re: [hackers] [dwm] [patch] Tab patch alone for dwm from the git master branch.

2021-08-07 Thread Sebastian LaVine
On 8/7/21 6:47 PM, Raghav Gururajan wrote: Hello Folks! The existing patch for tab (https://dwm.suckless.org/patches/tab/) doesn't cleanly apply on current master, so I have generated a new patch. Please find the patch attached with this email. Regards, RG. The correct way to update this

Re: [hackers] [dwm][floatrules] patch bugfix

2021-08-02 Thread Hiltjo Posthuma
On Sun, Aug 01, 2021 at 10:39:27PM -0300, Natanael Rabello wrote: > The following is a new diff revision for the dwm patch floatrules. > It contains bug fixes and adds support for allowing float x,y,w,h to > be unspecified (-1); that is for floating windows that already set the > geometry hints to

Re: [hackers] [PATCH svkbd] Version bump prior to release

2021-07-30 Thread Maarten van Gompel
Hi Hiltjo, > I made a new 0.4 release and some small fix for printing the version I > noticed. > > Thank you and the other people of sxmo for improving it. Thanks for the quick release! -- Maarten van Gompel proy...@anaproy.nl https://proycon.anaproy.nl https://github.com/proycon GnuPG key:

Re: [hackers] [PATCH svkbd] Version bump prior to release

2021-07-30 Thread Hiltjo Posthuma
On Fri, Jul 30, 2021 at 02:07:19PM +0200, Maarten van Gompel wrote: > This is also a release request, could you tag and release svkbd 0.4? > We're planning packaging and a release of Sxmo 1.5.0 this weekend > that includes it. > > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [hackers] [sbase] tar: check if reallocarray failed

2021-07-18 Thread Laslo Hunhold
On Sat, 17 Jul 2021 21:04:04 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > The patch below is for sbase tar: > > From 2eec3e07a5bd1ed1fa41ca02865297ab7d8b5fa8 Mon Sep 17 00:00:00 2001 > From: Hiltjo Posthuma > Date: Sat, 17 Jul 2021 21:03:27 +0200 > Subject: [PATCH] tar: check if reallocarray

Re: [hackers] [st][PATCH] Add 14th bit to XK_SWITCH_MOD bitmask

2021-07-18 Thread Hiltjo Posthuma
On Sun, Jul 18, 2021 at 12:14:00AM +0200, petarkap...@firemail.cc wrote: > From: Petar Kapriš > > The bits of uint signal in an XKeyEvent which concern the key group (keyboard > layout) are bits 13 and 14, as documented here: >

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-14 Thread Sebastian LaVine
On 7/14/21 7:41 AM, Chris Down wrote: Hey folks, Laslo Hunhold writes: count me in in that regard. If an application (most likely a game) wants exclusive fullscreen, it can capture the mouse in the window. I always set it like this in wine and have had no problems with that, and it still

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-14 Thread Quentin Rameau
> Hey folks, Hello Cris, > Looking at the conversation, it seems like the concern is about interaction > with the fakefullscreen[0] patch, if I understand correctly. No it's not.

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-14 Thread Chris Down
Hey folks, Laslo Hunhold writes: count me in in that regard. If an application (most likely a game) wants exclusive fullscreen, it can capture the mouse in the window. I always set it like this in wine and have had no problems with that, and it still allows workspace-switching. For what it's

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-14 Thread Laslo Hunhold
On Tue, 13 Jul 2021 14:33:31 -0400 Sebastian LaVine wrote: Dear Sebastian, > I am the "some people" that Quentin mentioned above :) > > I brought this up in the #suckless channel yesterday, when I was > having a problem with Firefox: When I entered into fullscreen mode, I > could no longer

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-14 Thread Hiltjo Posthuma
On Tue, Jul 13, 2021 at 08:04:19PM +0200, Hiltjo Posthuma wrote: > On Mon, Jul 12, 2021 at 11:44:16PM +0200, Quentin Rameau wrote: > > Some people are annoyed to have this new behaviour forced for some > > application which use fake fullscreen. > > --- > > config.def.h | 1 + > > dwm.c| 2

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-13 Thread Christopher Witt
On 7/13/21 8:33 PM, Sebastian LaVine wrote: On 7/13/21 2:04 PM, Hiltjo Posthuma wrote: On Mon, Jul 12, 2021 at 11:44:16PM +0200, Quentin Rameau wrote: Some people are annoyed to have this new behaviour forced for some application which use fake fullscreen. ---   config.def.h | 1 +   dwm.c 

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-13 Thread Sebastian LaVine
On 7/13/21 2:04 PM, Hiltjo Posthuma wrote: On Mon, Jul 12, 2021 at 11:44:16PM +0200, Quentin Rameau wrote: Some people are annoyed to have this new behaviour forced for some application which use fake fullscreen. --- config.def.h | 1 + dwm.c| 2 +- 2 files changed, 2 insertions(+),

Re: [hackers] [PATCH] Add a configuration option for fullscreen locking

2021-07-13 Thread Hiltjo Posthuma
On Mon, Jul 12, 2021 at 11:44:16PM +0200, Quentin Rameau wrote: > Some people are annoyed to have this new behaviour forced for some > application which use fake fullscreen. > --- > config.def.h | 1 + > dwm.c| 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Nikita Zlobin
In Sun, 4 Jul 2021 12:34:54 +0200 Laslo Hunhold wrote: > the arg.h in st has some "low-hanging" fruits regarding improvements, > and I modified it accordingly in quark and farbfeld back in 2017 (see > [0]) to fix some issues. > > One example is that in my modified form, you can actually access

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Nikita Zlobin
In Sun, 4 Jul 2021 11:55:53 +0200 Hiltjo Posthuma wrote: > Hi, > > Thanks, but I prefer the current style one. > > I'm not confident this patch doesn't modify any behaviour. > For example I see the `i` variable was removed, but it is actually > important to not modify argv as this causes

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Laslo Hunhold
On Sun, 4 Jul 2021 11:55:53 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > Thanks, but I prefer the current style one. > > I'm not confident this patch doesn't modify any behaviour. > For example I see the `i` variable was removed, but it is actually > important to not modify argv as this causes

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Nikita Zlobin
В Sun, 4 Jul 2021 11:55:53 +0200 Hiltjo Posthuma пишет: > On Sun, Jul 04, 2021 at 12:30:27PM +0500, Nikita Zlobin wrote: > > - improved code readability > > - cleaned redundant variables and checks > > - isolated reusable part for (E)ARGF > > --- > > arg.h | 65 > >

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Nikita Zlobin
In Sun, 4 Jul 2021 11:55:53 +0200 Hiltjo Posthuma wrote: > On Sun, Jul 04, 2021 at 12:30:27PM +0500, Nikita Zlobin wrote: > > - improved code readability > > - cleaned redundant variables and checks > > - isolated reusable part for (E)ARGF > > --- > > arg.h | 65 > >

Re: [hackers] [st][PATCH] arg.h: optimize & style

2021-07-04 Thread Hiltjo Posthuma
On Sun, Jul 04, 2021 at 12:30:27PM +0500, Nikita Zlobin wrote: > - improved code readability > - cleaned redundant variables and checks > - isolated reusable part for (E)ARGF > --- > arg.h | 65 +-- > 1 file changed, 32 insertions(+), 33

Re: [hackers] [sites][PATCH] Fixed the title of the page

2021-05-28 Thread Hiltjo Posthuma
On Thu, May 27, 2021 at 05:38:24PM +0100, The-Repo-Club wrote: > --- > tools.suckless.org/dmenu/patches/emoji-highlight/index.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools.suckless.org/dmenu/patches/emoji-highlight/index.md >

Re: [hackers] dvtm: add a comma at the end of kf22 entry in dvtm.info

2021-05-21 Thread Quentin Rameau
Hi Greg, > > I see. I wrote to this list because of these instructions from > > https://github.com/martanne/dvtm: "If you have comments, suggestions, > > ideas, a bug report, a patch or something else related to dvtm then write > > to the suckless developer mailing list or contact me

Re: [hackers] dvtm: add a comma at the end of kf22 entry in dvtm.info

2021-05-21 Thread Hiltjo Posthuma
On Fri, May 21, 2021 at 11:05:25AM -0400, Greg Reagle wrote: > On Fri, May 21, 2021, at 04:50, Hiltjo Posthuma wrote: > > dvtm is not a project on suckless.org (minor detail) ;) > > I see. I wrote to this list because of these instructions from > https://github.com/martanne/dvtm: "If you have

Re: [hackers] dvtm: add a comma at the end of kf22 entry in dvtm.info

2021-05-21 Thread Hiltjo Posthuma
On Thu, May 20, 2021 at 05:01:44PM -0400, Greg Reagle wrote: > Patch attached. Sending an email seems a *lot* easier than a pull request on > github, which would require me to clone and update (unless I am missing > something, which is not unlikely). dvtm is not a project on suckless.org

Re: [hackers] [slstatus][PATCH] Fixed bugs in FreeBSD's ram_* functions. Added appropriate FreeBSD config.mk options. Coding style fixes across all files.

2021-05-18 Thread Steve Ward
On Sat, May 8, 2021 at 5:04 PM Christos Margiolis wrote: > > The FreeBSD `ram_*' functions in `components/ram.c' were printing > completely wrong results (especially `ram_perc'). This was fixed > by changing the `active' and `npages' variables' data types from > `long' to `int'. > > `config.mk'

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-12 Thread Hiltjo Posthuma
On Tue, May 11, 2021 at 09:21:32PM -0400, Steve Ward wrote: > On Mon, May 10, 2021 at 5:31 AM Christos Margiolis > wrote: > > > > Hello Steve, > > > > On Sun, May 09, 2021 at 10:31:49PM -0400, Steve Ward wrote: > > > Do these commands give the desired output on FreeBSD? > > > `pkg-config --cflags

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-11 Thread Steve Ward
On Mon, May 10, 2021 at 5:31 AM Christos Margiolis wrote: > > Hello Steve, > > On Sun, May 09, 2021 at 10:31:49PM -0400, Steve Ward wrote: > > Do these commands give the desired output on FreeBSD? > > `pkg-config --cflags x11` > > `pkg-config --libs x11` > > I guess it's right, althought I'm

Re: [hackers] [st][PATCH] Restore cursor when exiting alt mode.

2021-05-11 Thread Stein Gunnar Bakkeby
Hi Hijito, I think it's more likely that I am the one missing something. I found that I had this in my .vimrc file: if has("autocmd") au VimEnter,InsertLeave * silent execute '!echo -ne "\e[2 q"' | redraw! au InsertEnter,InsertChange * \ if v:insertmode == 'i' | \ silent execute '!echo

Re: [hackers] [st][PATCH] Restore cursor when exiting alt mode.

2021-05-11 Thread Hiltjo Posthuma
On Tue, May 11, 2021 at 10:41:29AM +0200, Stein Gunnar Bakkeby wrote: > From 7fa0a12281f4b595b75e40e497919076497281e8 Mon Sep 17 00:00:00 2001 > From: bakkeby > Date: Tue, 11 May 2021 10:20:23 +0200 > Subject: [PATCH] Restore cursor when exiting alt mode. > > If the mouse cursor is changed to a

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-10 Thread Christos Margiolis
Hello Steve, On Sun, May 09, 2021 at 10:31:49PM -0400, Steve Ward wrote: > Do these commands give the desired output on FreeBSD? > `pkg-config --cflags x11` > `pkg-config --libs x11` I guess it's right, althought I'm not sure about `pthread`, so I'm posting it here too: $ pkg-config --cflags

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-09 Thread Steve Ward
On Sun, May 9, 2021 at 1:54 PM Christos Margiolis wrote: > > Hello Hiltjo, > > On Sun, May 09, 2021 at 07:49:28PM +0200, Hiltjo Posthuma wrote: > > I know there is an example OpenBSD comment too, but I don't want to add > > FreeBSD > > or any more platforms. > > Understood. I just thought it'd

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-09 Thread Christos Margiolis
Hello Hiltjo, On Sun, May 09, 2021 at 07:49:28PM +0200, Hiltjo Posthuma wrote: > I know there is an example OpenBSD comment too, but I don't want to add > FreeBSD > or any more platforms. Understood. I just thought it'd be good to have it since the OpenBSD comment doesn't work on FreeBSD. --

Re: [hackers] [dwm][PATCH] config.mk: added build options for FreeBSD

2021-05-09 Thread Hiltjo Posthuma
On Sun, May 09, 2021 at 08:29:56PM +0300, Christos Margiolis wrote: > `config.mk' didn't have the appropriate `X11INC', `X11LIB', > `FREETYPEINC' options for dwm to build on FreeBSD, so I added > them. > > -- > Kind regards, > Christos > From afc59913952b5c38119bbcbf1aa17fe3498c8766 Mon Sep 17

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 17:48:33 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > The patch looks fine. I'm not in favor of some of the const changes, > but I think it makes sense to make function parameters like for > xstrdup() const. > > I'll review and push it later. const-correctness saved me from

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Hiltjo Posthuma
On Thu, May 06, 2021 at 04:33:35PM +0200, Markus F.X.J. Oberhumer wrote: > Hi Laslo, > > On 2021-05-06 16:19, Laslo Hunhold wrote: > > On Thu, 6 May 2021 16:11:33 +0200 > > "Markus F.X.J. Oberhumer" wrote: > > > > Dear Markus, > > > >> this is my first post to this list, so I hope I got the

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Markus F.X.J. Oberhumer
Hi Laslo, On 2021-05-06 16:19, Laslo Hunhold wrote: > On Thu, 6 May 2021 16:11:33 +0200 > "Markus F.X.J. Oberhumer" wrote: > > Dear Markus, > >> this is my first post to this list, so I hope I got the email patch >> right. >> >> GitHub repo is at >>

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 16:11:33 +0200 "Markus F.X.J. Oberhumer" wrote: Dear Markus, > this is my first post to this list, so I hope I got the email patch > right. > > GitHub repo is at > https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements thanks for your

Re: [hackers] [st][PATCH] fix pointer to one before object UB

2021-05-05 Thread Guilherme Janczak
On Thu, May 06, 2021 at 01:50:48AM +0200, Hiltjo Posthuma wrote: > I think if the condition is reversed then it is fine: > > > - while(isspace(*e) && e > s) > > to: > > > - while(e > s && isspace(*e)) While it is true reversing the condition solves a single-byte read at one before s,

Re: [hackers] [st][PATCH] fix pointer to one before object UB

2021-05-05 Thread Hiltjo Posthuma
On Wed, May 05, 2021 at 09:34:15PM +, Guilherme Janczak wrote: > The expression "s + strlen(s) - 1" can create a pointer to one before > *s if strlen(s) is 0. > > --- > util.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/util.c b/util.c > index

Re: [hackers] [st][PATCH] fix pointer to one before object UB

2021-05-05 Thread Guilherme Janczak
On Wed, May 05, 2021 at 09:34:15PM +, Guilherme Janczak wrote: > The expression "s + strlen(s) - 1" can create a pointer to one before > *s if strlen(s) is 0. > ... A heads up, this is actually a patch to [sic] not [st], I managed to get the subject wrong.

Re: [hackers] [svkbd][PATCH] allow neutralizing a key modifier by applying the same modifier again

2021-04-23 Thread Maarten van Gompel
On 21-04-18 05:08, Hiltjo Posthuma wrote: > On Sun, Apr 18, 2021 at 04:26:05PM +0200, Max Schillinger wrote: > > svkbd allows you to create keys for symbols of the second (=shift) layer by > > defining them with a modifier included, like: > > > > { "|", "|", XK_backslash, 1, XK_Shift_L }, > >

Re: [hackers] [svkbd][PATCH] allow neutralizing a key modifier by applying the same modifier again

2021-04-18 Thread Hiltjo Posthuma
On Sun, Apr 18, 2021 at 04:26:05PM +0200, Max Schillinger wrote: > svkbd allows you to create keys for symbols of the second (=shift) layer by > defining them with a modifier included, like: > > { "|", "|", XK_backslash, 1, XK_Shift_L }, > > This key creates a pipe symbol by sending shift +

Re: [hackers] [dwm][PATCH] Support for different tags when there is a client inside

2021-04-13 Thread Hiltjo Posthuma
On Tue, Apr 13, 2021 at 01:10:20PM +0300, Yigit Colakoglu wrote: > This patch allows the user to provide a second set of tags which are > displayed when there is a client in that tag. > > --- > config.def.h | 5 - > dwm.c| 36 +--- > 2 files changed,

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Sebastian LaVine
On 4/2/21 9:12 AM, Hiltjo Posthuma wrote: On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? Myes I see, thank you for the correction. Should quotes be *added* to the

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Fri, Apr 02, 2021 at 02:05:05PM +0200, Laslo Hunhold wrote: > On Fri, 2 Apr 2021 11:03:05 +0200 > Hiltjo Posthuma wrote: > > Dear Hiltjo, > > > I prefer with quotes. You can still do make PREFIX=~/.local or > > whatever. Otherwise you could use $HOME. > > aren't the quotes also necessary in

Re: [hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Laslo Hunhold
On Fri, 2 Apr 2021 07:42:24 + Subhaditya Nath wrote: Dear Subhaditya, > From 79e69338725563e1bdba32e856726e8fa5151e4c Mon Sep 17 00:00:00 2001 > From: Subhaditya Nath > Date: Thu, 1 Apr 2021 19:42:51 +0530 > Subject: [PATCH] Set custom environment variables in config.h > > This patch

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Laslo Hunhold
On Fri, 2 Apr 2021 11:03:05 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > I prefer with quotes. You can still do make PREFIX=~/.local or > whatever. Otherwise you could use $HOME. aren't the quotes also necessary in case one of the variables (DESTDIR, MANPREFIX, etc.) contains spaces? With best

Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

2021-04-02 Thread Hiltjo Posthuma
On Thu, Apr 01, 2021 at 08:53:35PM -0400, Sebastian LaVine wrote: > Previously, if you had changed your PREFIX in config.mk to something > like ~/.local, then instead of installing to /home/user/.local, a > directory called '~' would be created in the project directory. Commands > are also

Re: [hackers] [st][PATCH] Set custom environment variables in config.h

2021-04-02 Thread Hiltjo Posthuma
On Fri, Apr 02, 2021 at 07:42:24AM +, Subhaditya Nath wrote: > From 79e69338725563e1bdba32e856726e8fa5151e4c Mon Sep 17 00:00:00 2001 > From: Subhaditya Nath > Date: Thu, 1 Apr 2021 19:42:51 +0530 > Subject: [PATCH] Set custom environment variables in config.h > > This patch enables setting

Re: [hackers] [tabbed] Urgency Hint

2021-03-29 Thread Mikau
The recent messages about contributions with no reply reminded my of my own. I'd really like to know the maintainers' opinion on it. For convenience, I've squashed the commits (including a newer one that fixed a memory leak in my code) and made the message a bit more concise:

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-28 Thread Maarten van Gompel
Hi Hiltjo, > layout.mobile-intl.h:387: warning: 'keys_functions' defined but not used > > Should it be added to the layer definitions, removed or left as-is for now? That can be left as-is for now yes, I took the layer out of the defaults as it didn't add much, but perhaps someone still wants

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-28 Thread Hiltjo Posthuma
Hi Maarten, Thanks for the patch and the work on svkbd and sxmo. I have a question about a warning in the code (gcc with compiled with CFLAGS -Wall): layout.mobile-intl.h:387: warning: 'keys_functions' defined but not used Should it be added to the layer definitions, removed or left as-is for

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-28 Thread Maarten van Gompel
Hi Hiltjo, Thanks for the merge and the extra cleanup you did, looks good! I just submitted one last patch (a modification to one of the other layouts, fell outside the earlier batch) and then I think we're good to go for release of svkbd 0.3.0 if you're satisfied too. Regards, -- Maarten van

Re: [hackers] [PATCH] [dwm] [patch] livereload-xresources

2021-03-28 Thread Hiltjo Posthuma
Wiki patches should not be sent to this list, please read: https://suckless.org/community/ The wiki is public to push to. Thanks On Sun, Mar 28, 2021 at 01:34:53PM +0300, ser...@ekmekci.me wrote: > From: Serhan Ekmekçi > > --- > .../dwm-livereload-xresources-20210328.diff | 275

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Maarten van Gompel
Hi Hiltjo, > They arrived properly. I've read most of the patches. It's a bulk of patches > so please give me some time to review it. Sure, no problem! > Some quick notes (will write it more detailed later): Thanks, I already picked these up, I'll submit 4 new patches that address these (on

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Hiltjo Posthuma
On Sat, Mar 27, 2021 at 02:03:05PM +0100, Maarten van Gompel wrote: > On 21-03-19 09:23, Maarten van Gompel wrote: > > > Thanks for the work. > > > > > > I've reviewed the patches. In general it looks good, but I've found a few > > > issues. Can you resend them to the mailinglist, then me (and

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Laslo Hunhold
On Sat, 27 Mar 2021 14:03:05 +0100 Maarten van Gompel wrote: Dear Maarten, > I wonder if the svkbd patches I submitted last week arrived properly > and if you have the opportunity to look at them soon? > > (I only see 2 of the 24(!) patches in the mailing list archives, there > may be some

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-27 Thread Maarten van Gompel
On 21-03-19 09:23, Maarten van Gompel wrote: > > Thanks for the work. > > > > I've reviewed the patches. In general it looks good, but I've found a few > > issues. Can you resend them to the mailinglist, then me (and possibly others > > too of course) can respond inline which is the way we like to

Re: [hackers] [PATCH sxmo-dwm] close window on long voldown press, kill window on triple press

2021-03-21 Thread Maarten van Gompel
Sorry, this patch (and the other I just sent) were not meant for the suckless mailing list but for another! I got the recipients messed up! -- Maarten van Gompel (proycon) https://proycon.anaproy.nl

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-19 Thread Maarten van Gompel
> Thanks for the work. > > I've reviewed the patches. In general it looks good, but I've found a few > issues. Can you resend them to the mailinglist, then me (and possibly others > too of course) can respond inline which is the way we like to manage and > review Thanks! Sure, no problem. I'll

Re: [hackers] [svkbd] [merge request] various patches for svkbd

2021-03-18 Thread Hiltjo Posthuma
On Mon, Mar 15, 2021 at 05:46:32PM +0100, Maarten van Gompel wrote: > Hi, > > We have done some considerable work on svkbd in the scope of the sxmo > project and would like to again merge these changes upstream to > suckless, like before. Before I inundate your mailing list with a series > of 22

Re: [hackers] Re: [dwm][PATCH] Proper restart function

2021-03-09 Thread Hiltjo Posthuma
On Mon, Mar 08, 2021 at 05:12:50PM +, toluschr wrote: > On Monday, March 8, 2021 2:49 PM, Hiltjo Posthuma > wrote: > > > On Mon, Mar 08, 2021 at 11:29:12AM +, Tolu2 wrote: > > > > > On Saturday, March 6, 2021 4:59 PM toluschr wrote: > > > > > > > The currently available patch reads

Re: [hackers] Re: [dwm][PATCH] Proper restart function

2021-03-08 Thread toluschr
On Monday, March 8, 2021 2:49 PM, Hiltjo Posthuma wrote: > On Mon, Mar 08, 2021 at 11:29:12AM +, Tolu2 wrote: > > > On Saturday, March 6, 2021 4:59 PM toluschr wrote: > > > > > The currently available patch reads /proc/self/exe, which fails when > > > recompiling (Why else would I want to

Re: [hackers] Re: [dwm][PATCH] Proper restart function

2021-03-08 Thread Hiltjo Posthuma
On Mon, Mar 08, 2021 at 11:29:12AM +, Tolu2 wrote: > On Saturday, March 6, 2021 4:59 PM toluschr wrote: > > > The currently available patch reads /proc/self/exe, which fails when > > recompiling (Why else would I want to restart dwm?) > > This patch simply saves the commandline arguments on

Re: [hackers] [svkbd][PATCH] Force installing executable

2021-02-25 Thread Hiltjo Posthuma
On Thu, Feb 25, 2021 at 05:28:16PM +0100, Jochen Sprickerhof wrote: > So we don't fail if it is executed at the same time. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 076c8b0..e82704e 100644 > --- a/Makefile > +++

Re: [hackers] [quark] Apply (D)DoS-Hardening || Laslo Hunhold

2021-02-08 Thread Laslo Hunhold
On Sun, 07 Feb 2021 21:41:58 +0300 Greg Minshall wrote: Dear Greg, > thanks for your reply and detailed explanation, which i should have > understood from your earlier e-mail (and, if not, from looking at the > code). don't worry about it; the algorithm-code is a bit convoluted given the two

Re: [hackers] [quark] Apply (D)DoS-Hardening || Laslo Hunhold

2021-02-07 Thread Greg Minshall
Laslo, thanks for your reply and detailed explanation, which i should have understood from your earlier e-mail (and, if not, from looking at the code). cheers, Greg

Re: [hackers] [quark] Apply (D)DoS-Hardening || Laslo Hunhold

2021-02-07 Thread Laslo Hunhold
On Sun, 07 Feb 2021 17:07:24 +0300 Greg Minshall wrote: Dear Greg, > just a comment from the outside. > > if i read get_connection_to_drop_candidate() correctly, your algorithm > selects the first, in terms of location in 'connection' array, "best" > (lowest state) candidate to drop. > > you

Re: [hackers] [quark] Apply (D)DoS-Hardening || Laslo Hunhold

2021-02-07 Thread Greg Minshall
Laslo, just a comment from the outside. if i read get_connection_to_drop_candidate() correctly, your algorithm selects the first, in terms of location in 'connection' array, "best" (lowest state) candidate to drop. you might think of, when finding an *equally* "best" candidate, flipping some

Re: [hackers] [quark][PATCH] Return -1 in case of errors in queue event wrapper functions.

2021-01-30 Thread Laslo Hunhold
On Sat, 30 Jan 2021 13:54:58 +0100 Rainer Holzner wrote: Dear Rainer, > Use same data type for nready (number of events) as returned by > queue_wait(). --- > [...] > - int qfd, nready, fd; > + int qfd, fd; > + ssize_t nready; > [...] > + return -1; thanks for

Re: [hackers] [quark] Ignore queries and fragments in URIs || Laslo Hunhold

2021-01-30 Thread Laslo Hunhold
On Sat, 30 Jan 2021 14:30:12 +0100 Hiltjo Posthuma wrote: > Cool story, bro. To be continued ;)

Re: [hackers] [quark] Ignore queries and fragments in URIs || Laslo Hunhold

2021-01-30 Thread Hiltjo Posthuma
On Sat, Jan 30, 2021 at 01:11:17PM +0100, g...@suckless.org wrote: > commit 319ba7083fdde836d6614c6b8b228bf3a9849e95 > Author: Laslo Hunhold > AuthorDate: Sat Jan 30 12:53:00 2021 +0100 > Commit: Laslo Hunhold > CommitDate: Sat Jan 30 13:10:32 2021 +0100 > > Ignore queries and

Re: [hackers] [lchat][PATCH] Makefile: provides an uninstall target

2021-01-29 Thread shirenn
Signed-off-by: shirenn --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ea45200..cc24402 100644 --- a/Makefile +++ b/Makefile @@ -1,14 +1,17 @@ include config.mk -.PHONY: all install filter clean test +.PHONY: all install

Re: [hackers] [lchat][PATCH] Point that libutf is available in the sbase

2021-01-29 Thread Jan Klemkow
On Fri, Jan 29, 2021 at 11:31:31AM +0100, Laslo Hunhold wrote: > On Thu, 28 Jan 2021 16:06:28 -0300 > Pedro Lucas Porcellis wrote: > > > --- > > README.md | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.md b/README.md > > index 6ece4c0..d3a815f 100644 > >

Re: [hackers] [lchat][PATCH] Makefile: provides an uninstall target

2021-01-29 Thread Hiltjo Posthuma
On Thu, Jan 28, 2021 at 08:39:40PM +0100, shirenn wrote: > On Thu, 2021-01-28 at 17:56 +0100, Hiltjo Posthuma wrote: > > > > It would be nice if the Makefile respects $DESTDIR also (can be a separate > > patch). > > > > Curently the destination directories are determined by these variables >

Re: [hackers] [lchat][PATCH] Point that libutf is available in the sbase

2021-01-29 Thread Laslo Hunhold
On Thu, 28 Jan 2021 16:06:28 -0300 Pedro Lucas Porcellis wrote: > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 6ece4c0..d3a815f 100644 > --- a/README.md > +++ b/README.md > @@ -18,7 +18,7 @@ Programs you can use lchat as

Re: [hackers] [lchat][PATCH] Makefile: provides an uninstall target

2021-01-28 Thread Jan Klemkow
On Thu, Jan 28, 2021 at 04:55:58PM +0100, shirenn wrote: > +uninstall: > + rm ${BINDIR}/lchat ${MAN1DIR}/lchat.1 > + Please, add '-f' option, or it will fail if one of the files not exist. Thanks, Jan

Re: [hackers] [lchat][PATCH] Makefile: provides an uninstall target

2021-01-28 Thread shirenn
On Thu, 2021-01-28 at 17:56 +0100, Hiltjo Posthuma wrote: > > It would be nice if the Makefile respects $DESTDIR also (can be a separate > patch). > Curently the destination directories are determined by these variables located in the config.mk file : PREFIX = /usr/local BINDIR =

Re: [hackers] [lchat][PATCH] Makefile: provides an uninstall target

2021-01-28 Thread Hiltjo Posthuma
On Thu, Jan 28, 2021 at 04:55:58PM +0100, shirenn wrote: > Signed-off-by: shirenn > --- > Makefile | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index ea45200..675ac76 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,6 +1,6 @@ > include

Re: [hackers] [quark][PATCH] Add a config switch to enable/disable NPROC limit

2021-01-25 Thread Laslo Hunhold
On Mon, 25 Jan 2021 14:17:17 +0100 Giulio Picierro wrote: Dear Giulio, > sorry for the late reply, I had a really busy week (course to teach) > :/. don't worry about it! This is a mailing list and meant to be asynchronous. Don't feel pressured to response and rather take your time; it's a

<    2   3   4   5   6   7   8   9   10   11   >