Re: [hackers] [ii] add OpenBSD pledge support - thanks Gleydson Soares || Nico Golde

Would be helpful if you provided error string for pledge(), I have also provided a pledge patch for sic and I submitted it a while ago to the mailing list (maybe you did not notice it). Raiz diff --git a/sic.c b/sic.c index ce6d216..6e37c60 100644 --- a/sic.c +++ b/sic.c @@ -182,6 +182,10 @@

[hackers] [ii] fix double backslash || Nico Golde

commit a4434536cd80325016309edbb02cbd27cd43b42d Author: Nico Golde AuthorDate: Fri Sep 2 18:43:08 2016 +0200 Commit: Nico Golde CommitDate: Fri Sep 2 18:43:08 2016 +0200 fix double backslash diff --git a/ii.c b/ii.c index 19f1b4c..3c6c3c7 100644 ---

Re: [hackers] [quark] missing newline

sorry, wrong patch On 2016-09-02 17:21, Ali H. Fardan wrote: diff --git a/quark.c b/quark.c index 6ff50f5..f69ed59 100644 --- a/quark.cdiff --git a/quark.c b/quark.c index 6ff50f5..7e6530f 100644 --- a/quark.c +++ b/quark.c @@ -694,7 +694,7 @@ main(int argc, char *argv[]) /* raise

[hackers] [quark] missing newline

diff --git a/quark.c b/quark.c index 6ff50f5..f69ed59 100644 --- a/quark.c +++ b/quark.c @@ -686,7 +686,7 @@ main(int argc, char *argv[]) /* reap children automatically */ if (signal(SIGCHLD, SIG_IGN) == SIG_ERR) { - fprintf(stderr, "%s: signal: Failed to set

[hackers] [ii] add OpenBSD pledge support - thanks Gleydson Soares || Nico Golde

commit 18580a159febc9c9658d82d73b90b53895c1ec00 Author: Nico Golde AuthorDate: Fri Sep 2 16:13:43 2016 +0200 Commit: Nico Golde CommitDate: Fri Sep 2 16:13:43 2016 +0200 add OpenBSD pledge support - thanks Gleydson Soares diff --git a/config.mk

Re: [hackers] [quark] Initial commit of quark rewrite || FRIGN

On Fri, Sep 02, 2016 at 12:37:00PM +0100, Nick wrote: > Hi FRIGN, > > I don't have time to look at this closely now, but one little thing > that jumped out at me: > > > +static const struct { > > + char *ext; > > + char *type; > > +} mimes[] = { > > ... > > Why are you defining the struct

Re: [hackers] [slock] Fix my previous commit and some light refactoring

> Heyho Quentin, Yo Markus, > After some reconsidering, I merged the patch as you proposed it. The > other three are merged as well. Thanks for the contribution. Thanks!

Re: [hackers] [quark] Initial commit of quark rewrite || FRIGN

Hi FRIGN, I don't have time to look at this closely now, but one little thing that jumped out at me: > +static const struct { > + char *ext; > + char *type; > +} mimes[] = { > ... Why are you defining the struct in config.def.h? Shouldn't it be defined in quark.c, and then just

Re: [hackers] [slock] Fix my previous commit and some light refactoring

Heyho Quentin, Quentin Rameau wrote: > What I mean is if it makes sense to have a timeout in one case, it's > valable for all other cases too. > Also that's a (maximum) timeout, not a strict delay. So when nothing > gets in the way of grabbing input, slock is automatically started > anyway

[hackers] [slock] Move screen unlocking inside cleanup() || Quentin Rameau

commit 39fb855aa100c5a5a8b7f3b6cc1fbb2135fe7dde Author: Quentin Rameau AuthorDate: Thu Sep 1 13:47:05 2016 +0200 Commit: Markus Teich CommitDate: Fri Sep 2 10:50:32 2016 +0200 Move screen unlocking inside cleanup() diff --git a/slock.c

[hackers] [slock] Localize running and failure inside readpw() || Quentin Rameau

commit 03a87179919eebab7d38c548e3ff8e2911512468 Author: Quentin Rameau AuthorDate: Thu Sep 1 13:47:19 2016 +0200 Commit: Markus Teich CommitDate: Fri Sep 2 10:50:32 2016 +0200 Localize running and failure inside readpw() They

[hackers] [slock] Add cleanup() to do free(locks) + XCloseDisplay() || Quentin Rameau

commit 1f66885fbf36c726b7615060d3c98cbf74218d13 Author: Quentin Rameau AuthorDate: Thu Sep 1 13:46:19 2016 +0200 Commit: Markus Teich CommitDate: Fri Sep 2 10:50:32 2016 +0200 Add cleanup() to do free(locks) + XCloseDisplay() diff

[hackers] [slock] increasing for loops are idiomatic || Markus Teich

commit a55594fdd69fcfcc10b8c9624d5aba298969d713 Author: Markus Teich AuthorDate: Fri Sep 2 11:49:02 2016 +0200 Commit: Markus Teich CommitDate: Fri Sep 2 11:49:02 2016 +0200 increasing for loops are idiomatic diff --git

[hackers] [slock] Re-introduce the waiting loop for input grabbing || Quentin Rameau

commit e378f735d857f7da124177e3540912d920be5022 Author: Quentin Rameau AuthorDate: Thu Sep 1 13:46:51 2016 +0200 Commit: Markus Teich CommitDate: Fri Sep 2 10:50:32 2016 +0200 Re-introduce the waiting loop for input grabbing We

[hackers] [quark] Add a few more mime types || FRIGN

commit f04929e729992dcc435370a60b5e92bcd5bdfe81 Author: FRIGN AuthorDate: Fri Sep 2 11:08:54 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 11:09:49 2016 +0200 Add a few more mime types diff --git a/config.def.h b/config.def.h index d7237af..fe74ced

[hackers] [quark] Stop hiding what we're doing in the Makefile || FRIGN

commit cd2893965f901310e44466a53c19a703b0ece107 Author: FRIGN AuthorDate: Fri Sep 2 10:49:42 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 10:49:42 2016 +0200 Stop hiding what we're doing in the Makefile On Gentoo for instance they are

Re: [hackers] [slock] [PATCH] simplify fix for CVE-2016-6866

Heyho, Can someone with such a weird network authentication setup check if my updated version fixes the bug as well befor I apply it? Eric, hiro, you both seem to have access to such systems. --Markus

[hackers] [quark] Simplify Makefile and package properly || FRIGN

commit 11481ed250a4ff4e9585a35cbe46fb695e45c8dd Author: FRIGN AuthorDate: Fri Sep 2 10:43:27 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 10:44:43 2016 +0200 Simplify Makefile and package properly diff --git a/Makefile b/Makefile index

[hackers] [quark] Initial commit of quark rewrite || FRIGN

commit 0ce86bba1549408a490f2ac8f97fc948323a9418 Author: FRIGN AuthorDate: Fri Sep 2 09:59:02 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 09:59:02 2016 +0200 Initial commit of quark rewrite Roughly 700 LOC (half of the old quark on the Hiltjo

[hackers] [quark] Prepare repository for rewrite || FRIGN

commit 0e8cac1ee4e2f4a76ea7417d9dc727694c8b69da Author: FRIGN AuthorDate: Fri Sep 2 09:46:01 2016 +0200 Commit: FRIGN CommitDate: Fri Sep 2 09:46:01 2016 +0200 Prepare repository for rewrite It was sad to see that quark never got the attention