On 2018-10-01, David Phillips wrote:
> On Mon, Oct 01, 2018 at 06:35:13PM -0700, Michael Forney wrote:
>> Rather than the if-else, I think we should always include sys/types.h,
>> and also sys/sysmacros.h on glibc. I also think the comment is
>> unnecessary. Do you mind if I apply with those two
On 2018-10-01, David Phillips wrote:
> Hi,
>
> Bumping this patch since sbase master now fails to build against
> glibc 2.28
>
> Let me know if there are any improvements that could be made.
>
> Thanks,
> David
I wish the #ifdef wasn't necessary, but it seems like the only way to
use major/minor
On Mon, Jul 02, 2018 at 11:58:54PM +1200, David Phillips wrote:
> On Mon, Jul 02, 2018 at 01:20:42PM +0200, Quentin Rameau wrote:
> > Ok, the makedev(3) manpage from the man-pages states this indeed:
> >
> > The BSDs expose the definitions for these macros via .
> > Depending on the version,
On Mon, Jul 02, 2018 at 01:20:42PM +0200, Quentin Rameau wrote:
> Ok, the makedev(3) manpage from the man-pages states this indeed:
>
> The BSDs expose the definitions for these macros via .
> Depending on the version, glibc also exposes definitions for these
> macros from that header file if
> > On glibc, major, minor, and makedev are all defined in
> > sys/sysmacros.h with types.h only including this for historical
> > reasons. A future release of glibc will remove this behaviour,
> > meaning that major, minor, and makedev will no longer be defined
> > for us without including
On Mon, Jul 02, 2018 at 10:16:50AM +0200, Quentin Rameau wrote:
> > On glibc, major, minor, and makedev are all defined in
> > sys/sysmacros.h with types.h only including this for historical
> > reasons. A future release of glibc will remove this behaviour,
> > meaning that major, minor, and
On Mon, Jul 02, 2018 at 10:02:09AM +0200, Hiltjo Posthuma wrote:
>
> Did you test it with musl too and preferably other platforms?
Unfortunately not; I don't currently have access to non-glibc Linux
installations at the moment, nor BSDs. Perhaps users of those systems
might be able to chime in at
> On glibc, major, minor, and makedev are all defined in
> sys/sysmacros.h with types.h only including this for historical
> reasons. A future release of glibc will remove this behaviour,
> meaning that major, minor, and makedev will no longer be defined
> for us without including sysmacros.h.
On Mon, Jul 02, 2018 at 07:48:03PM +1200, David Phillips wrote:
> On glibc, major, minor, and makedev are all defined in
> sys/sysmacros.h with types.h only including this for historical
> reasons. A future release of glibc will remove this behaviour,
> meaning that major, minor, and makedev will
