Unable to log into Hail Wiki

2012-01-25 Thread Pete Zaitcev
Jeff, looks like the wiki rots. The login points to this URL https://hail.wiki.kernel.org/articles/u/s/e/Special%7EUserLogin_94cd.html It returns 404. HALP? -- Pete -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More

[patch hail 1/1] Plug leak in hstor_parse_key

2011-10-14 Thread Pete Zaitcev
Signed-off-by: Pete Zaitcev zait...@kotori.zaitcev.us --- lib/hstor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hstor.c b/lib/hstor.c index cb9c4da..5ce9b76 100644 --- a/lib/hstor.c +++ b/lib/hstor.c @@ -761,7 +761,7 @@ void hstor_free_keylist(struct

Hail git tree location

2011-10-04 Thread Pete Zaitcev
Are we going to have a git tree somewhere? It looks like our old one was purged from git.kernel.org. -- P -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: FYI, rpc/ is gone from Fedora 15

2011-05-05 Thread Pete Zaitcev
On Thu, 05 May 2011 11:34:42 -0400 Jeff Garzik j...@garzik.org wrote: On 05/05/2011 10:14 AM, Jim Meyering wrote: FYI, /usr/include/rpc/ no longer exists, as of F15's glibc-headers-2.13.90-10, so hail's lib/cld_msg_rpc.h will have to do something about this #include: $ grep

Crash with db5

2011-01-02 Thread Pete Zaitcev
Looks like Rawhide throws this if libdb-devel is in use: make check-TESTS make[3]: Entering directory `/q/zaitcev/hail/hail-tip/test/cld' PASS: prep-db DB_ENV-lsn_reset: method not permitted before handle's open method DB_ENV-dbremove: method not permitted before handle's open method cld[11548]:

Re: Crash with db5

2011-01-02 Thread Pete Zaitcev
-aids it: commit 42d083416656e195baa79a924df0f11a3f0681c2 Author: Pete Zaitcev zait...@yahoo.com Date: Sun Jan 2 20:28:39 2011 -0700 Accept db-5.1. diff --git a/configure.ac b/configure.ac index 9cfad23..abc9330 100644 --- a/configure.ac +++ b/configure.ac @@ -75,7 +75,8 @@ dnl AC_TYPE_PID_T

Re: [patch tabled 6/8] Add filesystem back-end

2010-12-13 Thread Pete Zaitcev
On Mon, 13 Dec 2010 16:30:59 -0500 Jeff Garzik j...@garzik.org wrote: Current chunkd intentionally prevents two random users from put'ing the same object. The FS backend should do the same. Ouch, I completely forgot about it. Back then I hoped the DB4 transaction would do the job, but

Re: [patch hail 1/2] Add subdomain calling format

2010-12-07 Thread Pete Zaitcev
On Tue, 07 Dec 2010 05:05:38 -0500 Jeff Garzik j...@garzik.org wrote: On 12/05/2010 10:53 PM, Pete Zaitcev wrote: Amazon appears to give up on forcing users to migrate and bucket-in-path format is going to stay. However, they still refuse to list buckets from other regions on the default

AC_CONFIG_MACRO_DIR([m4])

2010-12-05 Thread Pete Zaitcev
Hi, Jim: Autoconf printed a warning when reconfiguting Hail, so I gave up and added this: diff --git a/configure.ac b/configure.ac index 9cfad23..d378854 100644 --- a/configure.ac +++ b/configure.ac @@ -62,6 +62,8 @@ AC_PROG_GCC_TRADITIONAL AM_PROG_CC_C_O AM_PROG_LIBTOOL

[patch hail 1/2] Add subdomain calling format

2010-12-05 Thread Pete Zaitcev
the subdomain format in one invocation. Signed-off-by: Pete Zaitcev zait...@redhat.com --- include/hstor.h |6 + lib/hstor.c | 178 +- 2 files changed, 106 insertions(+), 78 deletions(-) diff --git a/include/hstor.h b/include/hstor.h index b47387b

[patch tabled 1/8] Shuffle fields of storage nodes

2010-11-28 Thread Pete Zaitcev
This helps copy-paste safer later, mostly. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/object.c |2 - server/storage.c | 79 ++--- server/tabled.h | 12 +++--- 3 files changed, 53 insertions(+), 40 deletions(-) commit

[patch tabled 2/8] Comment storage.c

2010-11-28 Thread Pete Zaitcev
I have a vague memory that It should be ok to return meant something related to the way our event dispatch worked, but I cannot recall any details. Ergo, useless comment. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/storage.c |6 +++--- 1 file changed, 3 insertions(+), 3

[patch tabled 5/8] Rename in_storage to in_socket

2010-11-28 Thread Pete Zaitcev
The clause is called Socket, so the old name was confusing. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/storparse.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) commit 6536a193f1befcf3eed8b18535990e8566518479 Author: Pete Zaitcev zait...@yahoo.com Date

[patch tabled 4/8] Split out chunk back-end

2010-11-28 Thread Pete Zaitcev
This patch is careful not to change anything but the strictly necessary parts in the actual code. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/Makefile.am |3 server/stor_chunk.c | 409 ++ server/storage.c| 377

[patch tabled 6/8] Add filesystem back-end

2010-11-28 Thread Pete Zaitcev
coverage in any given run. Therefore, we test two back-end types sequentially now. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/Makefile.am |2 server/stor_chunk.c | 21 - server/stor_fs.c | 498 + server/storage.c | 157

[patch tabled 8/8] Add Swift back-end

2010-11-28 Thread Pete Zaitcev
Swift authorizes by plaintext passwords, support for SSL is essential, but is currently missing. There is no build-time test for this, because it would require us to depend on OpenStack, which is untenable. Signed-off-by: Pete Zaitcev zait...@redhat.com --- doc/etc.tabled.conf |5 server

[patch tabled 7/8] Clenaup stor_chunk.c

2010-11-28 Thread Pete Zaitcev
Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/stor_chunk.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) commit ca0920cfe5978839ee1a35d6096754a87db6f9ac Author: Pete Zaitcev zait...@yahoo.com Date: Sun Nov 28 18:01:24 2010 -0700 Cleanup stor_chunk. diff

[patch hail 1/2] use hail_log.h

2010-11-10 Thread Pete Zaitcev
I think forward declarations are not needed if we have a nice leaf header. Signed-off-by: Pete Zaitcev zait...@redhat.com --- include/cld_common.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 12f0fd5e0c6925299617082d834220396fae252e Author: Pete Zaitcev zait...@yahoo.com

[patch hail 2/2] add -i to cldcli

2010-11-10 Thread Pete Zaitcev
This is purely cosmetic so that tabled build logs do not show useless prompts. The way -i works copies common shells: one cannot force non-interactive session. Signed-off-by: Pete Zaitcev zait...@redhat.com --- tools/cldcli.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion

[patch hail] remove duplicated stc_readport

2010-10-26 Thread Pete Zaitcev
specific version in RPM headers (e.g. no Requires: cld = 0.8.2). Also, get rid of g_file_get_contents. Talk about pointless: it requires caller to free memory, and it's not like code is any more compact or easier to understand. Signed-off-by: Pete Zaitcev zait...@redhat.com --- chunkd/config.c

[patch tabled] distribute the sample tabled.conf

2010-10-15 Thread Pete Zaitcev
The doc/etc.tabled.conf is a vital piece of documentation but we forgot to include it into the actual distribution. It was only available for those pulling the git tree, not tarballs. Also update the sample spec. Signed-off-by: Pete Zaitcev zait...@redhat.com --- doc/Makefile.am |1 + pkg

[hail patch 1/2] Change cfgfile.txt into a real config file

2010-10-05 Thread Pete Zaitcev
Not many people read Recipies page at the wiki, so let's change the in-tree cfgfile.txt so that it can be copied into /etc. Signed-off-by: Pete Zaitcev zait...@redhat.com --- doc/cfgfile.txt | 57 +++--- 1 file changed, 19 insertions(+), 38 deletions

Autostart

2010-09-29 Thread Pete Zaitcev
Jeff et.al.: I am working on a feature called autostart in Image Warehouse. It amounts to iwhd starting with a certain default configuration, but is a bit more: it also launches services necessary to support said default, e.g. tabled. Naturally, tabled needs cld and chunkd. An interesting

Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam

2010-09-27 Thread Pete Zaitcev
On Mon, 27 Sep 2010 10:53:06 +0200 Jim Meyering j...@meyering.net wrote: - stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK); + v = strdup(val); + stmp = huri_field_escape(v, QUERY_ESCAPE_MASK); str = g_string_append(str, stmp); free(stmp); + free(v); I

Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam

2010-09-27 Thread Pete Zaitcev
On Mon, 27 Sep 2010 12:53:48 -0400 Jeff Garzik j...@garzik.org wrote: - stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK); + v = strdup(val); + stmp = huri_field_escape(v, QUERY_ESCAPE_MASK); str = g_string_append(str, stmp); free(stmp); + free(v); applied

Re: On licensing and libhail

2010-09-21 Thread Pete Zaitcev
On Tue, 21 Sep 2010 17:04:41 -0400 Jeff Garzik j...@garzik.org wrote: Occasionally I receive a ping about libhail licensing. GPL is probably less convenient than LGPL, so I was wondering what existing copyright holders thought about changing libhail to LGPL, while leaving the remaining bits

Re: stor_obj_test

2010-08-16 Thread Pete Zaitcev
On Wed, 07 Jul 2010 00:02:02 -0400 Jeff Garzik j...@garzik.org wrote: This function seems to be missing the meat. It retrieves then disposes of a keylist. bool stor_obj_test(struct open_chunk *cep, uint64_t key) I do not understand what kind of meat you expect stor_obj_test to have. In

[tabled patch 3/5] cleanup a call to closelog()

2010-08-12 Thread Pete Zaitcev
Since we're on it, only call closelog() if openlog() was called. There is no crash if we do that, but still it's not very correct. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/server.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit

[tabled patch 4/5] Support auto replicaton port

2010-08-12 Thread Pete Zaitcev
port, we do not need to write any accessor files, because we already report the host and port through CLD. Listening on random ports has security implications. Signed-off-by: Pete Zaitcev zait...@redhat.com --- doc/etc.tabled.conf | 16 ++- server/cldu.c | 166

Re: [tabled patch 3/3] Fix metadata replication

2010-08-10 Thread Pete Zaitcev
On Tue, 10 Aug 2010 18:43:37 -0400 Jeff Garzik j...@garzik.org wrote: On 08/10/2010 05:19 PM, Pete Zaitcev wrote: Unfortunately this is getting a little behind, because I started working on the tests and they require some changes (e.g. the listening host and port may be unknown

Re: [hail patch 2/3] fix 32/64 wire interoperability

2010-08-05 Thread Pete Zaitcev
On Thu, 05 Aug 2010 17:25:30 -0400 Jeff Garzik j...@garzik.org wrote: I wonder if we shouldn't switch to attribute(packed) for safety, though. I dunno, as long as we test this... I irrationally hate the gcc attributes, although probably any viable competitor will have to support them. Talk

[tabled patch 2/3] Fix the flood of read obj(N)

2010-08-05 Thread Pete Zaitcev
, but leaves any potential ones. I want to see if they ever hit. Also, fix up messages a bit. In a redundant environment it is necessary to know NIDs so that a broken Chunk can be isolated, so add that. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/object.c | 32

[hail patch 3/3] Use a constant like elsewhere

2010-08-04 Thread Pete Zaitcev
Actually a competent compiler should replace this strlen with a constant expression, so a performance win is unlikely, but why bother if we already have this constant and use it in similar cases? Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/chunkdc.c |4 ++-- 1 file changed, 2

Re: [hail patch 1/1] Make host, url, orig_path dynamic

2010-07-29 Thread Pete Zaitcev
On Tue, 20 Jul 2010 16:34:19 -0400 Jeff Garzik j...@garzik.org wrote: lib/hstor.c | 147 +++--- 1 file changed, 104 insertions(+), 43 deletions(-) applied It's not in the git repo. Check this URL:

[hail patch 2/7] Cleanup some in tdb.c

2010-07-29 Thread Pete Zaitcev
Some syntax sugar, but also make messages consistent. I removed dbenv- prefix because it looked pretty goofy in logs. Plus, make all messages so that they are unique and correspond exactly to the failed function, for grepping. Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/tdb.c | 27

[hail patch 4/7] Go to 64K chunkd buffers

2010-07-29 Thread Pete Zaitcev
never trips. - Not exactly sure if I ever saw a hang due to half-buffer write and a lost notification. Maybe. But thinking about it it's obvious that we want a notification if any write is outstanding (rc nonzero). Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/object.c |2

[hail patch 5/7] Drop a per-key message

2010-07-29 Thread Pete Zaitcev
Not a good idea on a working server with thousands of keys. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/replica.c |7 --- 1 file changed, 7 deletions(-) commit cc860ab6272571320f6be4651107da90141dcfb8 Author: Pete Zaitcev zait...@yahoo.com Date: Thu Jul 29 19:38:38 2010

[hail patch 6/7] byteswap sin_port

2010-07-29 Thread Pete Zaitcev
Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/server.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9d8c7992b91f969930643dd9ea94b6ba4f8aa6eb Author: Pete Zaitcev zait...@yahoo.com Date: Thu Jul 29 19:51:28 2010 -0600 Byteswap port. diff --git a/server

[hail patch 7/7] Listen on status earlier

2010-07-29 Thread Pete Zaitcev
working. But this fix is better than nothing. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/server.c | 48 ++ 1 file changed, 40 insertions(+), 8 deletions(-) commit d41bf1bab507111aac01e971928f4c8a7c876b2b Author: Pete Zaitcev zait

Re: Amazon bucket-policy API extensions

2010-07-09 Thread Pete Zaitcev
On Thu, 08 Jul 2010 07:17:28 -0400 Jeff Darcy jda...@redhat.com wrote: Yet another thing for the to-do list, I guess. Yeah... Versions, too. -- Pete -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info

[hail patch 1/1] fix hstor crashes

2010-07-07 Thread Pete Zaitcev
of , thus segfault in strdup. This is not easy to accomplish with Boto, but our own httpstor can do it. Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/hstor.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This patch was actually tested on httpstor, I've not switched

Re: [PATCH] tabled: use httpstor API from libhail

2010-07-07 Thread Pete Zaitcev
On Wed, 7 Jul 2010 21:05:09 -0400 Jeff Garzik j...@garzik.org wrote: If anybody wants to recover the pre-libhail tabled.git tree, it can easily be done with Naah, I hate git branches (except the mandatory ones, of course). -- Pete -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] chunkd: add cp command, for local intra-table copies

2010-07-06 Thread Pete Zaitcev
On Tue, 6 Jul 2010 03:24:29 -0400 Jeff Garzik j...@garzik.org wrote: The following patch, against current hail.git, adds the CP command to chunkd, permitting copying from object-object inside a single table. What is it for? -- Pete -- To unsubscribe from this list: send the line unsubscribe

Re: New 'hail' repository created, with major packaging rework

2010-07-05 Thread Pete Zaitcev
On Fri, 02 Jul 2010 02:59:20 -0400 Jeff Garzik j...@garzik.org wrote: 4) ./autogen.sh 5) ./autogen.sh One worked for me. Trying to pretend it's nothing :-) 11) rpmbuild -ba SPECS/hail.spec Seems working perfectly, but there's one thing: Wrote:

Re: New 'hail' repository created, with major packaging rework

2010-07-05 Thread Pete Zaitcev
On Mon, 05 Jul 2010 14:37:48 -0400 Jeff Garzik j...@garzik.org wrote: Wrote: /q/zaitcev/rpms/RPMS/x86_64/hail-debuginfo-0.8-0.1.z1.fc13.x86_64.rpm The debuginfos for cld and chunkd are not produced for some reason. Not produced... or simply contained within hail-debuginfo? Typically

Re: New 'hail' repository created, with major packaging rework

2010-07-05 Thread Pete Zaitcev
On Fri, 02 Jul 2010 02:59:20 -0400 Jeff Garzik j...@garzik.org wrote: git://git.kernel.org/pub/scm/daemon/distsrv/hail.git libhail is a single shared library binary, linking together cldc, ncld, libtimer, and chunkdc modules. In other words, libhail at present is a simplistic

Re: New 'hail' repository created, with major packaging rework

2010-07-05 Thread Pete Zaitcev
On Mon, 05 Jul 2010 15:22:40 -0400 Jeff Garzik j...@garzik.org wrote: What has happened to the plan to include httpstor into libhail? Still planned, and can easily be done. Important first step was getting the foundation laid -- creating hail.git, and synchronizing hail.git and

Re: [RFC] new structure: hail pkg instead of cld, chunkd

2010-07-01 Thread Pete Zaitcev
On Thu, 1 Jul 2010 18:58:18 -0400 Jeff Garzik jgar...@pobox.com wrote: To clarify my proposal, and taking into account your comments and some refinements, I think the following should occur at the git repository + source tarball level:     cld/* - hail     chunkd/* - hail Thus you would

Re: [RFC] new structure: hail pkg instead of cld, chunkd

2010-06-30 Thread Pete Zaitcev
On Tue, 29 Jun 2010 16:56:52 -0400 Jeff Garzik j...@garzik.org wrote: I've been thinking about a new structure for the projects, namely having a single hail or hail-core package, that includes cld and chunkd services, and associated client libraries inside a new libhail. It seems a little

Re: Metadata replication in tabled

2010-06-28 Thread Pete Zaitcev
On Mon, 28 Jun 2010 08:37:51 -0400 Jeff Darcy jda...@redhat.com wrote: First, it seems like trying to do stuff under BDB replication, letting them control the flow, is proving to be rather painful - over a thousand lines in metarep.c plus other bits elsewhere, all constrained by their

Re: [tabled patch 2/4] fix the selection of chunk

2010-05-25 Thread Pete Zaitcev
On Tue, 25 May 2010 18:44:11 -0400 Jeff Garzik j...@garzik.org wrote: On 05/21/2010 10:19 PM, Pete Zaitcev wrote: +static int object_node_select(int *nx, struct db_obj_ent *obj) +{ + struct storage_node *stnode; + if (stnode-up

[tabled patch 3/4] remove a per-key printout

2010-05-21 Thread Pete Zaitcev
We still have a few other per-key printouts in replication code that a) are clearly marked as temporary, and b) only appear when keys are replicated. This one was popping on every rescan and thus filling the logs with useless garbage. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server

[chunkd patch 4/6] Print client port

2010-05-20 Thread Pete Zaitcev
The originating port is interesting when the same client contacts the chunkserver several times and we, for example, look at that with tcpdump. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/chunkd.h |1 + server/server.c | 11 --- 2 files changed, 9 insertions(+), 3

[chunkd patch 5/6] Drop fd from struct server_poll

2010-05-20 Thread Pete Zaitcev
This field seems completely unnecessary. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/chunkd.h |1 - server/cldu.c |7 --- server/server.c |4 +--- 3 files changed, 5 insertions(+), 7 deletions(-) commit 0f030f2d37a7d868752429632b98041821e1f57d Author: Master

[cld patch 1/1] fix crash in cldc_close due to array reallocations

2010-05-15 Thread Pete Zaitcev
globally visible structures, we only replace one ostensibly opaque pointer type (GArray) with another one (GList), so applications need not be rebuilt. Signed-off-by: Pete Zaitcev zait...@redhat.com --- include/cldc.h |2 - lib/cldc.c | 56 +++ 2

Re: iSCSI front-end for Hail

2010-05-01 Thread Pete Zaitcev
On Sat, 01 May 2010 18:28:42 -0400 Jeff Garzik j...@garzik.org wrote: As I write this email, I am borrowing a lot of networking code from tabled, to convert from GNet over to the more-flexible TCP server codebase found in tabled -- notably the asynchronous background TCP writing code in

[chunkd patch 2/2] cleanup: use srv_poll_lookup

2010-04-30 Thread Pete Zaitcev
No, we did not mean anything in particular by using a naked hash lookup here, just forgot to convert. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/server.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/server.c b/server/server.c index f367676

[chunkd patch 1/2] eradicate last vestiges of libevent

2010-04-30 Thread Pete Zaitcev
We stopped using libevent in Chunk a while ago, but for some reason not all references were removed. I tested this patch by building on a fresh Fedora 13 system without libevent. Signed-off-by: Pete Zaitcev zait...@redhat.com --- configure.ac |3 --- pkg/chunkd.spec|2

Re: [Patch 01/12] CLD: fix crash in retransmissions

2010-04-18 Thread Pete Zaitcev
On Sun, 18 Apr 2010 23:46:07 -0400 Jeff Garzik j...@garzik.org wrote: [tabled patch 1/1] update Makefile.am or [cld patch 1/1] libcldc: add nncld API, the new new CLD API That looks simple enough. -- Pete -- To unsubscribe from this list: send the line unsubscribe

Trivial Q about chunkd's main_loop

2010-04-17 Thread Pete Zaitcev
Is there a reason why the main_loop in chunkd uses a naked g_hash_table_lookup instead of srv_poll_lookup? Performance? @@ -1681,8 +1681,7 @@ static int main_loop(void) fired++; - sp = g_hash_table_lookup(chunkd_srv.fd_info, -

[Patch 01/12] CLD: fix crash in retransmissions

2010-04-17 Thread Pete Zaitcev
. No execution list is kept. The integrity of the main list is assured by never walking it and always referring to the head anew at each iteration. This patch appears to fix the problem and stands up to use that crashed the old code. Signed-off-by: Pete Zaitcev zait...@redhat.com --- include

[Patch 03/12] CLD: fix commentary

2010-04-17 Thread Pete Zaitcev
Add and fix some comments regarding the reasons behind the pipe etc. No code changes. Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/cldc.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) commit e675f2f316bbb24ca84c1bc23e4d1c6d53b029de Author

[Patch 06/12] Chunk: do not call timer_add from event context

2010-04-17 Thread Pete Zaitcev
. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/cldu.c | 77 +++- 1 file changed, 69 insertions(+), 8 deletions(-) commit d30028b4c681e99f7934ca264a175548c827ff04 Author: Master zait...@lembas.zaitcev.lan Date: Sat Apr 17 19:46:35 2010

[Patch 07/12] Chunk: retry initial CLD session open

2010-04-17 Thread Pete Zaitcev
be a bad idea, or may be not. We may yet change the retries to be infinite, but for now it's better if builds terminate somehow in case of unexpected problems. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/cldu.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

[Patch 08/12] Chunk: fix wrong message

2010-04-17 Thread Pete Zaitcev
The message makes no sense. It was a carry-over from cldc where there were many failure modes (fh is NULL, fh-valid false, etc.). Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/cldu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit

[Patch 09/12] tabled: drop double prefixing

2010-04-17 Thread Pete Zaitcev
wastes screen space. Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/tdb.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) commit eb60e6e5c97fe316d23b9b21ba020bca924e879e Author: Master zait...@lembas.zaitcev.lan Date: Sat Apr 17 20:31:56 2010 -0600 Fix double tagging

[Patch 11/12] tabled: check argument of -D better

2010-04-17 Thread Pete Zaitcev
-by: Pete Zaitcev zait...@redhat.com --- server/server.c |4 1 file changed, 4 insertions(+) commit b340bd6bbf9d7a82b69ad620f43799b616348a45 Author: Master zait...@lembas.zaitcev.lan Date: Sat Apr 17 20:40:12 2010 -0600 Deconfuse -D -E. diff --git a/server/server.c b/server/server.c

[Patch 12/12] tabled: print hostname always

2010-04-17 Thread Pete Zaitcev
This code clearly was obsolete and wishful thinking. Let's just be simple. Most importantly print something that tells the sysadmin what node is the problem. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/storage.c | 19 +++ server/tabled.h |2 +- 2 files

Re: tabled RPM build fails before it succeeds

2010-04-16 Thread Pete Zaitcev
On Fri, 16 Apr 2010 13:16:56 -0400 Jeff Garzik j...@garzik.org wrote: Build #1 (fails on x86_64): http://koji.fedoraproject.org/koji/taskinfo?taskID=2119825 PASS: prep-db chunkd[17774]: Waiting for CLD PortFile cld.port cld[17773]: databases up cld[17773]: Listening on port 34671 cld[17773]:

[Patch 4/8] CLD: cleanup: add #include

2010-04-14 Thread Pete Zaitcev
A prototype is not included again. Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/common.c |1 + 1 file changed, 1 insertion(+) diff --git a/lib/common.c b/lib/common.c index fb0aae6..e399ec9 100644 --- a/lib/common.c +++ b/lib/common.c @@ -26,6 +26,7 @@ #include errno.h #include

[Patch 6/8] CLD: cleanup: add a event stub just to test

2010-04-14 Thread Pete Zaitcev
-off-by: Pete Zaitcev zait...@redhat.com --- test/lock-file.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/test/lock-file.c b/test/lock-file.c index 36cc62c..3bbe49b 100644 --- a/test/lock-file.c +++ b/test/lock-file.c @@ -31,6 +31,15 @@ #include ncld.h

[Patch 5/8] CLD: cleanup: wrap a line

2010-04-14 Thread Pete Zaitcev
Signed-off-by: Pete Zaitcev zait...@redhat.com --- lib/cldc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Looks like I confused myself with patch numbering. This one is out of order, or maybe a duplicate? Sending on the premise that it's easier to drop. diff --git b/lib/cldc.c

[Patch 0/3] End-to-end verbosity v3

2010-04-13 Thread Pete Zaitcev
Here's yet another take on the precice verbosity control, this time with -D 2 replacing -v. Everywhere, not just in CLD. Uniformity! BTW, someone forgot to update all the examples when -D with an argument was introduced, so this patch does it now. These patches have an API change, so as usual CLD

Re: [Patch 1/7] tabled: make two dump displays uniform

2010-04-06 Thread Pete Zaitcev
On Tue, 06 Apr 2010 12:57:57 -0400 Jeff Garzik j...@garzik.org wrote: applied, thanks. I will endeavor to make the stats dump more like nfs4d in the future, FWIW. I was going to look into it too, but there's now some stuff I urgently need to address in Darcy's report on tabled's faults. So I

Re: [Patch 1/3] CLD: End-to-end verbosity

2010-04-06 Thread Pete Zaitcev
On Wed, 07 Apr 2010 00:36:32 -0400 Jeff Garzik j...@garzik.org wrote: On 04/06/2010 11:32 PM, Pete Zaitcev wrote: On Tue, 06 Apr 2010 10:40:33 -0400 Jeff Garzikj...@garzik.org wrote: The debug levels are 0: key messages affecting server operation, only 1: debugging output

Re: CLD doesn't build on db-4.3

2010-04-01 Thread Pete Zaitcev
On Thu, 01 Apr 2010 19:01:59 +0800 Samba - BoYang boy...@samba.org wrote: CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated structure members DBC-c_xxx(c_close(), etc) instead of DBC-xxx. :-) That's unexpected. Jeff is our portability expert, but he's busy with the baby,

[Patch 1/7] tabled: make two dump displays uniform

2010-04-01 Thread Pete Zaitcev
version of output, but failed to add the new stats to the standard stat dump facility. Your wish is my command. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/replica.c | 28 + server/server.c | 47 ++ server

[Patch 2/7] tabled: fix the endless recusion when reading long objects

2010-04-01 Thread Pete Zaitcev
every source of events. In other words, every function that is passed to event_set must invoke cli_write_run_compl. Mind that storage.c contains calls to event_set. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/object.c |4 +++ server/server.c | 52

[Patch 3/7] tabled: Stub NULL session in events

2010-04-01 Thread Pete Zaitcev
, but is pre-empted before ncld_sess_open returns, the same situation may occur legitimately. So this check is still needed, unless we radically change the locking strategy. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/cldu.c |7 +-- 1 file changed, 5 insertions(+), 2

[Patch 5/7] tabled: make unnecesserily global functions static

2010-04-01 Thread Pete Zaitcev
Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/object.c |9 + server/server.c |4 ++-- server/status.c |2 +- server/tdbadm.c |2 +- 4 files changed, 9 insertions(+), 8 deletions(-) commit f21ca8985bc7ba2b6e02fb0e58c79bcb96ab844f Author: Pete Zaitcev zait

[Patch 6/7] tabled: unsigned 0

2010-04-01 Thread Pete Zaitcev
Enums and sizeofs are unsigned. V. annoying because of int i;. Signed-off-by: Pete Zaitcev zait...@redhat.com --- server/status.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -urp -X dontdiff tabled-m/server/status.c tabled-tip/server/status.c --- tabled-m/server/status.c

[Patch 7/7] tabled: kill unused stor_get_enable

2010-04-01 Thread Pete Zaitcev
server/storage.c |9 - 1 file changed, 9 deletions(-) Signed-off-by: Pete Zaitcev zait...@redhat.com --- commit 32b1a2e9d8c481dfbf31222464aa2b6ef937ec4f Author: Pete Zaitcev zait...@yahoo.com Date: Thu Apr 1 19:20:09 2010 -0600 Dead function. diff --git a/server/storage.c b

[Patch 3/3] tabled: End-to-end verbosity

2010-03-31 Thread Pete Zaitcev
Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/cldu.c |9 ++--- server/server.c | 11 --- server/tabled.h |3 +-- 3 files changed, 15 insertions(+), 8 deletions(-) commit 820e53ea5ec85a69f6e1648e8d445a0d87ea6a72 Author: Master zait...@lembas.zaitcev.lan Date

Re: [PATCHv2] cld: use XDR for all messages

2010-02-09 Thread Pete Zaitcev
On Tue, 09 Feb 2010 04:38:21 -0500 Jeff Garzik j...@garzik.org wrote: On 02/09/2010 04:20 AM, Jeff Garzik wrote: Useful per-packet cld [the daemon] verbose output seems to have disappeared? Or did I miss a knob somewhere? cldcli no longers dumps per-packet debug info at maximum verbosity,

Does this work on BSD too?

2010-02-08 Thread Pete Zaitcev
When I run autogen.sh, this message is printed: lib/Makefile.am:13: `%'-style pattern rules are a GNU make extension It's because of this: %_rpc.h: %_rpc.x rpcgen -h $ $@ Is the above a concern? -- Pete -- To unsubscribe from this list: send the line unsubscribe hail-devel in the

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 21:06:17 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb, ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op

[Patch 1/1] tabled: switch to ncld

2010-02-08 Thread Pete Zaitcev
No new function just yet, only a switch-over. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/cldu.c | 789 +--- 1 file changed, 215 insertions(+), 574 deletions(-) diff --git a/server/cldu.c b/server/cldu.c index 7e176d4..aecf336 100644

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 23:55:03 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb,ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op

Post-XDR CLD cannot keep session up

2010-02-06 Thread Pete Zaitcev
Hi, Jeff Colin: It looks like you broke something in CLD, not sure if server or client. There are two possibly related bugs. But first, here's the messages (The chunkd is run with -D). Note that I have 2 servers listed in DNS (both on port 4499), but only one is up. Feb 6 23:36:10 hitlain

Re: the evils of the CLD api

2010-01-16 Thread Pete Zaitcev
On Sat, 16 Jan 2010 17:54:36 -0800 Colin McCabe cmcc...@alumni.cmu.edu wrote: On Sat, Jan 16, 2010 at 3:21 PM, Pete Zaitcev zait...@redhat.com wrote: Shouldn't ncld_unlock and ncld_close return an error code rather than just eating all errors? The server certainly does sometimes send back

[Patch 1/2] CLD: export a common timer implementation

2010-01-15 Thread Pete Zaitcev
-By: Pete Zaitcev zait...@redhat.com --- include/libtimer.h | 19 --- lib/Makefile.am|4 ++-- lib/libtimer.c | 25 ++--- server/Makefile.am |4 ++-- server/cld.h |8 server/server.c| 20

[Patch 1/7] tabled: cleanup tabled.conf

2010-01-14 Thread Pete Zaitcev
The lib/ is a vestige of days when we stored files in a local filesystem, not Chunk. Just kill it. And as for CLD, it's a last resort configuration, not something we should encourage. So comment it out. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- doc/etc.tabled.conf |8 +--- 1

[Patch 2/7] tabled: add Cell element

2010-01-14 Thread Pete Zaitcev
Make the cell configurable. Among other things we need this for is that you cannot migrate a tabled over when DB format changes, short of running 2 CLDs. We also add a few thoughts to the documentation, prompted by re-reading of the document while adding the clause for Cell. Signed-Off-By: Pete

[Patch 4/7] tabled: retry conflicting locks

2010-01-14 Thread Pete Zaitcev
. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/cldu.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) commit fa910aacff5118664177f988029cc5f8e6ef886d Author: Master zait...@lembas.zaitcev.lan Date: Thu Jan 14 19:56:13 2010 -0700

[Patch 6/7] tabled: cleanup tabled.h

2010-01-14 Thread Pete Zaitcev
The structure server_socket is not even referenced anywhere in tabled.h. Some kind of atavism, apparently. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/tabled.h |1 - 1 file changed, 1 deletion(-) commit ffcd630f41450d37493b6cad52a6ee11e5db7965 Author: Master zait

[Patch 7/7] tabled: cleanup config.c re. empty elements

2010-01-14 Thread Pete Zaitcev
I was changing it one by one, but honestly it was just stupid. Let us change over to the sane checking once and for all. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/config.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) commit

Re: [PATCH] cld: use XDR for all messages

2010-01-13 Thread Pete Zaitcev
On Wed, 13 Jan 2010 16:03:45 -0500 Jeff Garzik j...@garzik.org wrote: Well, this definitely does not build as-is. lib/Makefile.am needs BUILT_SOURCES = cld_msg_rpc.h otherwise nothing builds at all, because cld_msg_rpc.h does not exist. test/Makefile.am and

Re: [Patch 4/4] chunkd: add self-checking

2010-01-12 Thread Pete Zaitcev
On Tue, 12 Jan 2010 09:21:24 -0500 Jeff Garzik j...@garzik.org wrote: sleep(n) self_check() algorithm seems less useful to the average admin than a slightly more complex one that solves the problem defined as guarantee an object is checked at least every N days. Because, as

Re: [Patch 1/2] tabled: fix bugs in streaming of data

2010-01-07 Thread Pete Zaitcev
On Thu, 07 Jan 2010 17:10:49 -0500 Jeff Garzik j...@garzik.org wrote: I was thinking specifically that chunkd may want the in-progress xfer codes changes in your patch. chunkd, tabled, nfs4d (and ancient storaged) all share the same basic write-in-progress and TCP data xfer code. I'll

Re: [Patch 2/2] tabled: add a test for larger objects

2010-01-05 Thread Pete Zaitcev
On Tue, 05 Jan 2010 04:14:08 -0500 Jeff Garzik j...@garzik.org wrote: a follow-up patch that checks the checksums of the data sent/received would be nice... That would require more coding than using single check bytes because a checksum can span a block boundary. But ok, you're right, I'll do

  1   2   >