Re: [PATCH] BUG/MINOR: tools: fix parsing "us" unit for timers

2021-04-05 Thread Christopher Faulet
Le 02/04/2021 à 22:12, Thayne McCombs a écrit : Commit c20ad0d8dbd1bb5707bbfe23632415c3062e046c (BUG/MINOR: tools: make parse_time_err() more strict on the timer validity) broke parsing the "us" unit in timers. It caused `parse_time_err()` to return the string "s", which indicates an error. Now

Re: [PATCH] JWT payloads break b64dec convertor

2021-04-05 Thread Moemen MHEDHBI
Thanks Willy and Tim for your feedback. You can find attached the updated patches with fixed coding style (now set correctly in my editor), updated commit message, entry doc in sorted order, size_t instead of int in both enc/dec and corresponding reg-test. Only part unclear: On 02/04/2021 15:04,

[PATCH 0/3] Additional ist functions

2021-04-05 Thread Tim Duesterhus
Willy, some more `ist` helper functions that allows consumers to avoid directly operating on the raw pointer, instead using safe high level functions. These will be used in a future series of mine. I'm sending them for early review and integration, because I believe their existence is useful on i

[PATCH 1/3] MINOR: ist: Add `istappend(struct ist, char)`

2021-04-05 Thread Tim Duesterhus
This function appends the given char to the given `ist` and returns the resulting `ist`. --- include/import/ist.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/import/ist.h b/include/import/ist.h index 1262e8f59..3f63ed2dd 100644 --- a/include/import/ist.h +++ b/include/i

[PATCH 2/3] MINOR: ist: Add `istshift(struct ist*)`

2021-04-05 Thread Tim Duesterhus
istshift() returns the first character and advances the ist by 1. --- include/import/ist.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/import/ist.h b/include/import/ist.h index 3f63ed2dd..6ece7cdf9 100644 --- a/include/import/ist.h +++ b/include/import/ist.h @@ -24

[PATCH 3/3] MINOR: ist: Add `istsplit(struct ist*, char)`

2021-04-05 Thread Tim Duesterhus
istsplit is a combination of iststop + istadv. --- include/import/ist.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/import/ist.h b/include/import/ist.h index 6ece7cdf9..daf23d552 100644 --- a/include/import/ist.h +++ b/include/import/ist.h @@ -801,6 +801,20 @@ stati