Re: [PATCH] DEV: coccinelle: Add realloc_leak.cocci

2021-10-27 Thread Willy Tarreau
On Sat, Oct 23, 2021 at 07:53:35PM +0200, Tim Duesterhus wrote: > This coccinelle patch finds locations where the return value of `realloc()` is > assigned to the pointer passed to `realloc()`. This calls will leak memory if > `realloc()` returns `NULL`. Thanks. This and the hlua_alloc() patch wer

Re: [PATCH 1/2] CLEANUP: jwt: Remove the use of a trash buffer in jwt_jwsverify_hmac()

2021-10-27 Thread Willy Tarreau
On Mon, Oct 18, 2021 at 06:40:28PM +0200, Tim Duesterhus wrote: > The OpenSSL documentation > (https://www.openssl.org/docs/man1.1.0/man3/HMAC.html) > specifies: > > > It places the result in md (which must have space for the output of the hash > > function, which is no more than EVP_MAX_MD_SIZE

Re: [PATCH] MINOR: halog: Add -qry parameter allowing to preserve the query string in -uX

2021-10-27 Thread Willy Tarreau
On Mon, Oct 18, 2021 at 12:16:11PM +0200, Tim Düsterhus, WoltLab GmbH wrote: > From 6095a454dee425487083674ec9d35be7a59f7ef6 Mon Sep 17 00:00:00 2001 > From: Tim Duesterhus > Date: Mon, 18 Oct 2021 12:12:02 +0200 > Subject: [PATCH] MINOR: halog: Add -qry parameter allowing to preserve the > query

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-27 Thread Lukas Tribus
Hi, On Thursday, 28 October 2021, Shawn Heisey wrote: > On 10/27/2021 2:54 PM, Lukas Tribus wrote: > >> I'd be surprised if the OpenSSL API calls we are using doesn't support >> AES-NI. >> > > Honestly that would surprise me too. But I have no idea how to find out > whether it's using the accel

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-27 Thread Christopher Cox
On 10/27/21 5:47 PM, Shawn Heisey wrote: On 10/27/2021 2:54 PM, Lukas Tribus wrote: I'd be surprised if the OpenSSL API calls we are using doesn't support AES-NI. Honestly that would surprise me too.  But I have no idea how to find out whether it's using the acceleration or not, and the limit

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-27 Thread Shawn Heisey
On 10/27/2021 2:54 PM, Lukas Tribus wrote: I'd be surprised if the OpenSSL API calls we are using doesn't support AES-NI. Honestly that would surprise me too. But I have no idea how to find out whether it's using the acceleration or not, and the limited (and possibly incorrect) evidence I ha

Re: Does haproxy utlize openssl with AES-NI if present?

2021-10-27 Thread Lukas Tribus
Hello, On Wed, 27 Oct 2021 at 22:17, Shawn Heisey wrote: > > I am building haproxy from source. > > For some load balancers that I used to manage, I also built openssl from > source, statically linked, and compiled haproxy against that, because > the openssl included with the OS (CentOS 6 if I r

Does haproxy utlize openssl with AES-NI if present?

2021-10-27 Thread Shawn Heisey
I am building haproxy from source. For some load balancers that I used to manage, I also built openssl from source, statically linked, and compiled haproxy against that, because the openssl included with the OS (CentOS 6 if I recall correctly) was ANCIENT.  I don't know how to get haproxy to u

Re: Problem with the var() sample fetch function

2021-10-27 Thread Willy Tarreau
On Wed, Oct 27, 2021 at 07:04:31PM +0200, Tim Düsterhus wrote: > Personally I'd prefer to see my config loudly rejected if it is incorrect > than it silently working incorrectly. It's not like I'm going to roll out > 2.5 in my fleet without testing the config at least once. > > So: +1 to make this

Re: Problem with the var() sample fetch function

2021-10-27 Thread Willy Tarreau
On Wed, Oct 27, 2021 at 08:46:23PM +0200, Christopher Faulet wrote: > Le 10/27/21 à 18:32, Willy Tarreau a écrit : > > Christopher also found that the set-var() converter already mandates a > > matching method, as the following will be rejected: > > > > ... if { int(12),set-var(txn.truc) 12

Re: Problem with the var() sample fetch function

2021-10-27 Thread Christopher Faulet
Le 10/27/21 à 18:32, Willy Tarreau a écrit : Christopher also found that the set-var() converter already mandates a matching method, as the following will be rejected: ... if { int(12),set-var(txn.truc) 12 } while this one will work: ... if { int(12),set-var(txn.truc) eq 12 } Just

Re: Problem with the var() sample fetch function

2021-10-27 Thread Tim Düsterhus
Willy, On 10/27/21 6:32 PM, Willy Tarreau wrote: So the question is (as you see me coming), is it acceptable to fix this in 2.5+ by making var() match the doc, returning the type "any", and mandathing the matching method, implying that this bogus config which does not work: http-request s

Problem with the var() sample fetch function

2021-10-27 Thread Willy Tarreau
Hi all, Among the current pending issues, Christopher and I have been scratching our heads on an issue involving the var() sample fetch function. It started in issue 1215 but is more generalized: https://github.com/haproxy/haproxy/issues/1215 In short, var() was initially internally declare

HashiCorp

2021-10-27 Thread Kara Louis
Hi, Are you interested in reaching "HashiCorp users" or any other "CyberArk" users? If yes, we can assist you in reaching companies and decision makers. Expand your reach and increase sales growth. By acquiring these users email list, you're expanding your potential audience and fill your lea