Re: [PATCH] BUG/MEDIUM: buffers: Fix how input/output data are injected into buffers

2017-03-31 Thread Willy Tarreau
On Fri, Mar 31, 2017 at 02:45:15PM +0200, Christopher Faulet wrote: > > These situations cause trouble when not using the proper arithmetics. Either > > all the computations are made without wrapping, or all are made with > > wrapping. > > Any mix of the two causes issues. > > > > Yes, of

Re: [PATCH] BUG/MEDIUM: buffers: Fix how input/output data are injected into buffers

2017-03-31 Thread Christopher Faulet
Le 31/03/2017 à 14:26, Willy Tarreau a écrit : On Fri, Mar 31, 2017 at 11:29:43AM +0200, Christopher Faulet wrote: Willy, I tagged this patch as a bug. But I don't found a way to hit it for now. It can be backported or not, as you wish. Thanks Christopher. I don't know either how to trigger

[PATCH] BUG/MEDIUM: buffers: Fix how input/output data are injected into buffers

2017-03-31 Thread Christopher Faulet
017 11:58:28 +0200 Subject: [PATCH] BUG/MEDIUM: buffers: Fix how input/output data are injected into buffers The function buffer_contig_space is buggy and could lead to pernicious bugs (never hitted until now, AFAIK). This function should return the number of bytes that can be written into the buffe