Re: [PATCH] BUG/MINOR: ssl_sock.c: use PATH_MAX only when defined

2013-08-13 Thread Willy Tarreau
On Mon, Aug 12, 2013 at 01:47:02PM +0300, Apollon Oikonomopoulos wrote: > > Anyway I'd prefer something simpler : let's define PATH_MAX in compat.h > > if it is not defined. > > Yes, that's probably a cleaner solution. Finally I switched to MAXPATHLEN which is already handled in compat.h if it is

Re: [PATCH] BUG/MINOR: ssl_sock.c: use PATH_MAX only when defined

2013-08-12 Thread Apollon Oikonomopoulos
On 12:34 Mon 12 Aug , Willy Tarreau wrote: > Hi Apollon, > > Unfortunately, this patch introduces a memory leak. Since the path > variable is just a temporary one, better use alloca() instead in > order to dynamically allocate on the stack. Ooops, completely forgot to free(). Never submit pat

Re: [PATCH] BUG/MINOR: ssl_sock.c: use PATH_MAX only when defined

2013-08-12 Thread Willy Tarreau
Hi Apollon, On Mon, Aug 12, 2013 at 01:07:57PM +0300, Apollon Oikonomopoulos wrote: > Hi Willy, > > We are seeing build failures of 1.5 w/ SSL on Debian's Hurd builder machines > due to the use of PATH_MAX (which is undefined in Hurd) when loading SSL > certificates. You can see the build log her

[PATCH] BUG/MINOR: ssl_sock.c: use PATH_MAX only when defined

2013-08-12 Thread Apollon Oikonomopoulos
ollon Oikonomopoulos Date: Mon, 12 Aug 2013 12:22:26 +0300 Subject: [PATCH] BUG/MINOR: ssl_sock.c: use PATH_MAX only when defined bind_parse_crt() unconditionally uses PATH_MAX, which is not guaranteed to be defined by POSIX. In fact, GNU Hurd does not have a limit on path sizes and thus leave