Re: [PATCH] BUILD: improve reproducibility by filtering BUILD_CFLAGS

2021-10-22 Thread Willy Tarreau
On Fri, Oct 22, 2021 at 10:22:17PM +0200, Vincent Bernat wrote: > > I'm just thinking, we have a SILENT_DEFINE macro that should already > > address this. Could you please try to pass your -f... there ? If it > > works it would just be a matter of improving the SILENT_DEFINE > > description to

Re: [PATCH] BUILD: improve reproducibility by filtering BUILD_CFLAGS

2021-10-22 Thread Vincent Bernat
❦ 22 October 2021 21:08 +02, Willy Tarreau: >> ? 19 October 2021 09:22 +02, Vincent Bernat: >> >> > This could be backported to 2.4. Older versions do not display CFLAGS. >> >> Note that if you find this too ugly, I have no problem to maintain this >> as an OOT patch. > > I don't find it

Re: [PATCH] BUILD: improve reproducibility by filtering BUILD_CFLAGS

2021-10-22 Thread Willy Tarreau
Hi Vincent, On Tue, Oct 19, 2021 at 09:23:25AM +0200, Vincent Bernat wrote: > ? 19 October 2021 09:22 +02, Vincent Bernat: > > > This could be backported to 2.4. Older versions do not display CFLAGS. > > Note that if you find this too ugly, I have no problem to maintain this > as an OOT patch.

Re: [PATCH] BUILD: improve reproducibility by filtering BUILD_CFLAGS

2021-10-19 Thread Vincent Bernat
❦ 19 October 2021 09:22 +02, Vincent Bernat: > This could be backported to 2.4. Older versions do not display CFLAGS. Note that if you find this too ugly, I have no problem to maintain this as an OOT patch. -- Avoid unnecessary branches. - The Elements of Programming Style

[PATCH] BUILD: improve reproducibility by filtering BUILD_CFLAGS

2021-10-19 Thread Vincent Bernat
Some distributions (Debian) adds `-ffile-prefix-map=/current/pwd=` to CFLAGS in an attempt to make the package more reproducible when source code is using `__FILE__`. Unfortunately, this makes HAProxy build not reproducible since CFLAGS is recorded to be displayed in `haproxy --version`. To solve