Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Willy Tarreau
On Fri, Dec 15, 2017 at 06:23:21AM +0100, Etienne Carrière wrote: > I agree that my first intent "strlen" is not coherent with the other > converter name. "length" is better in the logic of the name of other > converters. OK now renamed and pushed. Thanks! Willy

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Etienne Carrière
Hi, 2017-12-14 22:49 GMT+01:00 Willy Tarreau : > > On Thu, Dec 14, 2017 at 10:18:27PM +0100, Cyril Bonté wrote: > > Le 14/12/2017 à 19:24, Willy Tarreau a écrit : > > Or maybe "length" then ? After all it could even work on binary samples if > needed, thus avoiding "str" could avoid

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Willy Tarreau
On Thu, Dec 14, 2017 at 10:18:27PM +0100, Cyril Bonté wrote: > Le 14/12/2017 à 19:24, Willy Tarreau a écrit : > > So I think we have two action plans for now : > >1) find another (ideally short) name for "len" which doesn't match "len" > > nor "id" nor "table" nor "if" nor "unless".

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Cyril Bonté
Le 14/12/2017 à 19:10, Willy Tarreau a écrit : If you want to make a patch for this one, in parallel I'm checking sample_parse_expr(). Yes, I was ready to provide the patch but I failed to reproduce the issue today. After some hours, I realized that there was a recent (well, 10 days ago)

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Cyril Bonté
Le 14/12/2017 à 19:24, Willy Tarreau a écrit : So I think we have two action plans for now : 1) find another (ideally short) name for "len" which doesn't match "len" nor "id" nor "table" nor "if" nor "unless". Etienne initially proposed "strlen" but I thought that it's a bit long

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Willy Tarreau
Hi Cyril, On Thu, Dec 14, 2017 at 06:48:28PM +0100, Cyril Bonté wrote: > It's embarrassing, I was working on a patch for a nasty bug I've seen > several times last week (randomly haproxy won't start), but now I've updated > to the current master branch, it's even worse with this specific patch. >

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Cyril Bonté
Hi Willy, Le 14/12/2017 à 14:36, Willy Tarreau a écrit : On Wed, Dec 13, 2017 at 02:56:34PM +0100, Etienne Carrière wrote: Hi, You will find attached a patch to add a converter that can returns the len of a string. Thank you Etienne, now applied. It's embarrassing, I was working on a

Re: [PATCH] Minor : converter: Add len converter

2017-12-14 Thread Willy Tarreau
On Wed, Dec 13, 2017 at 02:56:34PM +0100, Etienne Carrière wrote: > Hi, > > You will find attached a patch to add a converter that can returns the > len of a string. Thank you Etienne, now applied. Willy