Re: [PATCH] "include" configuration directive for haproxy 1.5-dev3

2010-12-20 Thread Brane F. Gračnar
On Wednesday 15 of December 2010 23:55:16 you wrote: > Hi Brane, > > I don't know if you saw that but you can already have a "conf.d" > configuration style in haproxy without any modification of code : haproxy > accepts several "-f" parameters. I wasn't aware of that, but i think that patch is no

Re: [PATCH] "include" configuration directive for haproxy 1.5-dev3

2010-12-15 Thread Cyril Bonté
Hi Brane, Le mardi 14 décembre 2010 20:30:06, Brane F. Gračnar a écrit : > Hello :) > > This patch (applies to 1.5-dev3) adds "include" configuration statement to > haproxy configuration parser. I wrote this patch becouse my haproxy > configuration became too big to be simply maintainable and bec

Re: [PATCH] "include" configuration directive for haproxy 1.5-dev3

2010-12-15 Thread Brane F. Gračnar
On Wednesday 15 of December 2010 15:18:55 L. Alberto Giménez wrote: > On 14/12/2010 20:30, Brane F. Gračnar wrote: > > Hello :) > > Hi Brane, > > I haven't had time to test your patch, but after a "visual" review made > some doubts to come up. It also applies to 1.4.10. > @@ -5343,6 +5440,40 @

Re: [PATCH] "include" configuration directive for haproxy 1.5-dev3

2010-12-15 Thread L. Alberto Giménez
On 14/12/2010 20:30, Brane F. Gračnar wrote: Hello :) Hi Brane, I haven't had time to test your patch, but after a "visual" review made some doubts to come up. And, please, post your patches inline, they are easier to review :) @@ -5343,6 +5440,40 @@ int readcfgfile(const char *file)

[PATCH] "include" configuration directive for haproxy 1.5-dev3

2010-12-14 Thread Brane F. Gračnar
Hello :) This patch (applies to 1.5-dev3) adds "include" configuration statement to haproxy configuration parser. I wrote this patch becouse my haproxy configuration became too big to be simply maintainable and becouse i really like "conf.d" configuration style. Usage: include glob_pattern I