Re: Failures on "Generate Build Matrix"

William, On 12/22/22 18:20, William Lallemand wrote: You need to be logged to see the logs of the CI, I don't know if it is only accessible to the people in the haproxy group or if it only need to be logged to github. Logs are visible to every logged-in user, no matter if they are part of

Re: Failures on "Generate Build Matrix"

Willy, On 12/22/22 19:01, Willy Tarreau wrote: On Thu, Dec 22, 2022 at 11:56:24PM +0600, ??? wrote: you can limit token scope to read repo information. But the request you're making with it concerns a different project (openssl), will this work ? Just to confirm: Yes, this works.

Re: Failures on "Generate Build Matrix"

Hi y'all, On 12/23/22 15:24, William Lallemand wrote: I passed some time doing tests and reading the github configuration, in fact we don't need to generate a token ourselves and to add it to the secret configuration. Github has a GITHUB_TOKEN which is generated at the beginning of the job and

Re: Failures on "Generate Build Matrix"

On Fri, Dec 23, 2022 at 03:24:47PM +0100, William Lallemand wrote: > On Fri, Dec 23, 2022 at 12:14:15AM +0600, ??? wrote: > > haproxy/vtest.yml at master · chipitsine/haproxy (github.com) > > > > > >

Re: Failures on "Generate Build Matrix"

On Fri, Dec 23, 2022 at 12:14:15AM +0600, Илья Шипицин wrote: > haproxy/vtest.yml at master · chipitsine/haproxy (github.com) > > > secret name can be arbitrary, for example "TOKEN". > env variable is

Re: Failures on "Generate Build Matrix"

haproxy/vtest.yml at master · chipitsine/haproxy (github.com) secret name can be arbitrary, for example "TOKEN". env variable is GITHUB_API_TOKEN пт, 23 дек. 2022 г. в 00:12, Willy Tarreau : > On Fri, Dec

Re: Failures on "Generate Build Matrix"

On Fri, Dec 23, 2022 at 12:08:29AM +0600, ??? wrote: > not perfect, but it works Can you please elaborate ? You sent a two-line screenshot of something I have no idea what this is nor what to do with it. Are you suggesting to rename the token or something else ? I'm sorry but your

Re: Failures on "Generate Build Matrix"

not perfect, but it works [image: image.png] from github point of view, if token is bad, you'll get 401. as long as I'm getting 200, I assume it works for "openssl" org as well :) пт, 23 дек. 2022 г. в 00:04, Willy Tarreau : > On Thu, Dec 22, 2022 at 11:56:24PM +0600, ??? wrote: > >

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 11:56:24PM +0600, ??? wrote: > you can limit token scope to read repo information. I tried anyway, it created one and failed with: Failed to add secret. Secret names must not start with GITHUB_. So I guess we should have tried it before committing the entry

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 11:56:24PM +0600, ??? wrote: > you can limit token scope to read repo information. But the request you're making with it concerns a different project (openssl), will this work ? Willy

Re: Failures on "Generate Build Matrix"

you can limit token scope to read repo information. [image: image.png] чт, 22 дек. 2022 г. в 23:49, Willy Tarreau : > On Thu, Dec 22, 2022 at 11:35:35PM +0600, ??? wrote: > > here's how it works > > > > (unfortunately, github does not allow secret named GITHUB_ , so I created > >

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 11:35:35PM +0600, ??? wrote: > here's how it works > > (unfortunately, github does not allow secret named GITHUB_ , so I created > secret "TOKEN" and assigned it to variable GITHUB_API_TOKEN) > > I also added "env" to print all variables, you can value of >

Re: Failures on "Generate Build Matrix"

here's how it works (unfortunately, github does not allow secret named GITHUB_ , so I created secret "TOKEN" and assigned it to variable GITHUB_API_TOKEN) I also added "env" to print all variables, you can value of GITHUB_API_TOKEN is masked. is it set to wrong value, so api call failed:

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 06:20:26PM +0100, William Lallemand wrote: > On Thu, Dec 22, 2022 at 06:12:46PM +0100, Willy Tarreau wrote: > > On Thu, Dec 22, 2022 at 11:00:26PM +0600, ??? wrote: > > > I'm not sure if it possible to issue organization based token (not a > > > personal one). > >

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 06:12:46PM +0100, Willy Tarreau wrote: > On Thu, Dec 22, 2022 at 11:00:26PM +0600, ??? wrote: > > I'm not sure if it possible to issue organization based token (not a > > personal one). > > > > As for visibility, secrets are not visible for pull requests. > > My

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 11:00:26PM +0600, ??? wrote: > I'm not sure if it possible to issue organization based token (not a > personal one). > > As for visibility, secrets are not visible for pull requests. My concern is not that they are in PR or any such thing, but they're passed in

Re: Failures on "Generate Build Matrix"

I'm not sure if it possible to issue organization based token (not a personal one). As for visibility, secrets are not visible for pull requests. чт, 22 дек. 2022 г. в 22:57, Илья Шипицин : > there are couple of steps left (no hurry, because "matrix.py" is backward > compatible) > > 1. issue

Re: Failures on "Generate Build Matrix"

there are couple of steps left (no hurry, because "matrix.py" is backward compatible) 1. issue "some kind of token". either Personal Access Tokens (Classic) (github.com) (no time limit) or Fine-grained Personal Access Tokens (github.com)

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 05:37:59PM +0100, William Lallemand wrote: > On Thu, Dec 22, 2022 at 10:32:22PM +0600, Илья Шипицин wrote: > > I attached a patch. It keeps current behaviour and is safe to apply. > > > > in order to make a difference, github token must be issued and set via > > github ci

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 10:32:22PM +0600, ??? wrote: > I attached a patch. It keeps current behaviour and is safe to apply. > > in order to make a difference, github token must be issued and set via > github ci settings. OK I understand better now, thanks! I didn't know that there was a

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 10:32:22PM +0600, Илья Шипицин wrote: > I attached a patch. It keeps current behaviour and is safe to apply. > > in order to make a difference, github token must be issued and set via > github ci settings. > > Ilya > I just pushed it, thank you. -- William Lallemand

Re: Failures on "Generate Build Matrix"

I attached a patch. It keeps current behaviour and is safe to apply. in order to make a difference, github token must be issued and set via github ci settings. Ilya чт, 22 дек. 2022 г. в 16:57, Willy Tarreau : > On Thu, Dec 22, 2022 at 04:47:09PM +0600, ??? wrote: > > what if I make

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 04:47:09PM +0600, ??? wrote: > what if I make it conditional, i.e. if github token is defined via env, > make non anonymous api call, I'm sorry, Ilya, but I have no idea what this means :-) Willy

Re: Failures on "Generate Build Matrix"

what if I make it conditional, i.e. if github token is defined via env, make non anonymous api call, чт, 22 дек. 2022 г. в 16:27, Willy Tarreau : > On Thu, Dec 22, 2022 at 03:49:34PM +0600, ??? wrote: > > it is something I was afraid of "HTTP Error 403: rate limit exceeded". > > ok,

Re: Failures on "Generate Build Matrix"

On Thu, Dec 22, 2022 at 03:49:34PM +0600, ??? wrote: > it is something I was afraid of "HTTP Error 403: rate limit exceeded". > ok, I'll try to deal with that Yep I've also seen a 429 this morning, indicating we were making too many requests to clone a repo. I think this is purely a

Re: Failures on "Generate Build Matrix"

it is something I was afraid of "HTTP Error 403: rate limit exceeded". ok, I'll try to deal with that чт, 22 дек. 2022 г. в 15:41, William Lallemand : > Hi Guys, > > Since a few days I'm seeing some failure on the "Generate Build Matrix" > part of > the CI, the request.urlopen() seems to fail

Failures on "Generate Build Matrix"

Hi Guys, Since a few days I'm seeing some failure on the "Generate Build Matrix" part of the CI, the request.urlopen() seems to fail the urlopen(), it's easy to restart it manually but it happened to me a few times recently. Do you think that would be possible to cache these values so the script