Re: Proposal about libslz integration into haproxy

2021-04-22 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 08:04:08AM +0200, Willy Tarreau wrote: > Does anyone have any opinion, objection or suggestion on this (especially > those in CC who participated to the first discussion or who could have > packaging concerns) ? Barring any comment I think I'm going to do this > tomorrow so

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 10:03:16AM +0200, William Lallemand wrote: > Hello, > > On Wed, Apr 21, 2021 at 08:04:08AM +0200, Willy Tarreau wrote: > > [...] > > > > So after changing my mind, I would go with the following approach: > > > > - building with USE_SLZ=1 => always use the embedded one

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread William Lallemand
Hello, On Wed, Apr 21, 2021 at 08:04:08AM +0200, Willy Tarreau wrote: > [...] > > So after changing my mind, I would go with the following approach: > > - building with USE_SLZ=1 => always use the embedded one > - building with USE_ZLIB=1 => always build using the user-provided zlib > >

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 09:36:52AM +0200, Tim Düsterhus wrote: > Willy, > > [cleaning CC List] > > On 4/21/21 8:04 AM, Willy Tarreau wrote: > > Does anyone have any opinion, objection or suggestion on this (especially > > those in CC who participated to the first discussion or who could have > >

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Tim Düsterhus
Willy, [cleaning CC List] On 4/21/21 8:04 AM, Willy Tarreau wrote: Does anyone have any opinion, objection or suggestion on this (especially those in CC who participated to the first discussion or who could have packaging concerns) ? Barring any comment I think I'm going to do this tomorrow so

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Willy Tarreau
On Wed, Apr 21, 2021 at 08:13:57AM +0200, Vincent Bernat wrote: > From a distribution point of view, we don't like bundled dependencies. > However, as I see it, libslz is an internal lib (like ebtree), so I > don't think this is really a problem. Moreover, we don't have the > external lib in

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Dinko Korunic
On 21.04.2021., at 08:04, Willy Tarreau wrote: > > Hi all, > […] > So after changing my mind, I would go with the following approach: > > - building with USE_SLZ=1 => always use the embedded one > - building with USE_ZLIB=1 => always build using the user-provided zlib > > We'd enable

Re: Proposal about libslz integration into haproxy

2021-04-21 Thread Vincent Bernat
❦ 21 avril 2021 08:04 +02, Willy Tarreau: > William suggested that I was needlessly seeking for trouble and that it > was pointless to keep compatibility for *both* an external version and > an internal one. While I initially wanted to demonstrate him he was wrong, > I realized that I was the

Proposal about libslz integration into haproxy

2021-04-21 Thread Willy Tarreau
Hi all, After Lukas and Ilya's comments on the difficulty to use libslz, last week I tried to find a way to cleanly import libslz into haproxy (that's only 2 files basically), *and* at the same time keep the ability to use an external one for those who want. It resulted in a configuration mess