Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-14 Thread Aleksandar Lazic
Am 13-02-2017 23:10, schrieb Willy Tarreau: On Mon, Feb 13, 2017 at 10:50:36PM +0100, Aleksandar Lazic wrote: What I mean is that. haproxy have already a config parser. Why not use this config parser and add new keyword for error files. With this approach the customers can reuse there

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2017 at 10:50:36PM +0100, Aleksandar Lazic wrote: > What I mean is that. > > haproxy have already a config parser. > > Why not use this config parser and add new keyword for error files. > > With this approach the customers can reuse there config without problems. But I don't

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Aleksandar Lazic
Am 13-02-2017 14:47, schrieb Willy Tarreau: Hi Aleks, On Mon, Feb 13, 2017 at 01:19:54PM +0100, Aleksandar Lazic wrote: Hi. Am 13-02-2017 12:15, schrieb Willy Tarreau: > On Mon, Feb 13, 2017 at 11:33:53AM +0100, Michael Hamburger wrote: > > > Willy wrote: [snipp] > > > Maybe you're

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2017 at 05:19:42PM +0100, Michael Hamburger wrote: > I started working on the changes. To discuss the changes I forked unofficial > HAProxy repository. I know it's not synchronized to the git repo but I think > it's easier discussing some changes via links I can post directly in

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Michael Hamburger
I started working on the changes. To discuss the changes I forked unofficial HAProxy repository. I know it's not synchronized to the git repo but I think it's easier discussing some changes via links I can post directly in this mail. Everyone just can click on the URLs and knows what I mean.

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Willy Tarreau
Hi Aleks, On Mon, Feb 13, 2017 at 01:19:54PM +0100, Aleksandar Lazic wrote: > Hi. > > Am 13-02-2017 12:15, schrieb Willy Tarreau: > > On Mon, Feb 13, 2017 at 11:33:53AM +0100, Michael Hamburger wrote: > > > > Willy wrote: > [snipp] > > > > > Maybe you're interested in trying to implement the

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Aleksandar Lazic
Hi. Am 13-02-2017 12:15, schrieb Willy Tarreau: On Mon, Feb 13, 2017 at 11:33:53AM +0100, Michael Hamburger wrote: > Willy wrote: [snipp] > Maybe you're interested in trying to implement the stuff above ? If > so, just let me know, I can give you a few hints which could possibly > help. I

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Willy Tarreau
On Mon, Feb 13, 2017 at 11:33:53AM +0100, Michael Hamburger wrote: > > Thanks for the description. However this change causes a big issue which > > is that a printf-format file is directly exposed outside. The nasty side > > effect is that someone using 2 "%s" instead of exactly one will cause > >

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-13 Thread Michael Hamburger
Hello Willy, thanks for answering. Thanks for the description. However this change causes a big issue which is that a printf-format file is directly exposed outside. The nasty side effect is that someone using 2 "%s" instead of exactly one will cause the process to randomly crash for example,

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-12 Thread Willy Tarreau
Hi Michael, On Sat, Feb 11, 2017 at 07:17:20PM +0100, Michael Hamburger wrote: > Hello :) > > My name is Michael Hamburger and I work for a game development startup. > Currently I am using Docker Flow: Proxy > (https://github.com/vfarcic/docker-flow-proxy) which is based on HAProxy. I > think

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-11 Thread Michael Hamburger
While creating the patch I noticed that I used 1.8-dev0 tag which can be downloaded as tar.gz file. I now used the master branch, added my changes, did a commit and exported the changes via patch. Don't worry, I restarted HAProxy and checked if my custom 401 error pages are still working (they

Re: Introduction and small changes to HAProxy for adding custom errorfiles for 401 and 407 http status page

2017-02-11 Thread Robin H. Johnson
On Sat, Feb 11, 2017 at 07:17:20PM +0100, Michael Hamburger wrote: > If you nonetheless like a git patch I will try to send one. Please do send a patch, it's a LOT easier to review, and if it's good, it can be applied with your name on it :-). If you have all of your changes in a single commit,