Re: mworker: seamless reloads broken since 1.8.1

Hello, I retrieve this old thread since we are getting the issue again with: # haproxy -vv HA-Proxy version 1.8.4-1deb90d 2018/02/08 I am trying to see whether I can reproduce it easily. Best, -- William

Re: mworker: seamless reloads broken since 1.8.1

Hi Pierre, On Wed, Jan 24, 2018 at 03:07:54PM +0100, Pierre Cheynier wrote: > Willy, I confirm that it works well again running the following version: > > $ haproxy -v > HA-Proxy version 1.8.3-945f4cf 2018/01/23 > > Added nbthread again, reloads are transparents. Excellent, many thanks for

Re: mworker: seamless reloads broken since 1.8.1

On 23/01/2018 19:29, Willy Tarreau wrote: > Pierre, please give a try to the latest 1.8 branch or the next nightly > snapshot tomorrow morning. It addresses the aforementionned issue, and > I hope it's the same you're facing. > > Cheers, > Willy Willy, I confirm that it works well again running

Re: mworker: seamless reloads broken since 1.8.1

On Tue, Jan 23, 2018 at 06:43:51PM +0100, Willy Tarreau wrote: > I'm switching to this now after having dealt with the polling fixes, > I'll try to have something testable this evening or tomorrow. Pierre, please give a try to the latest 1.8 branch or the next nightly snapshot tomorrow morning.

Re: mworker: seamless reloads broken since 1.8.1

Hi Pierre, On Wed, Jan 17, 2018 at 05:03:18PM +0100, Pierre Cheynier wrote: > Hi, > > On 08/01/2018 14:32, Pierre Cheynier wrote: > > I retried this morning, I confirm that on 1.8.3, using > (...) > > I get RSTs (not seamless reloads) when I introduce the global/nbthread > > X, after a systemctl

Re: mworker: seamless reloads broken since 1.8.1

Hi, On 08/01/2018 14:32, Pierre Cheynier wrote: > I retried this morning, I confirm that on 1.8.3, using (...) > I get RSTs (not seamless reloads) when I introduce the global/nbthread > X, after a systemctl haproxy restart. Any news on that ? I saw one mworker commit ("execvp failure depending

Re: mworker: seamless reloads broken since 1.8.1

Hi, On 08/01/2018 10:24, Lukas Tribus wrote: > > FYI there is a report on discourse mentioning this problem, and the > poster appears to be able to reproduce the problem without nbthread > paramter as well: > > https://discourse.haproxy.org/t/seamless-reloads-dont-work-with-systemd/1954 > > >

Re: mworker: seamless reloads broken since 1.8.1

Hello, On Fri, Jan 5, 2018 at 4:44 PM, William Lallemand wrote: > I'm able to reproduce, looks like it happens with the nbthread parameter only, > I'll try to find the problem in the code. FYI there is a report on discourse mentioning this problem, and the poster

Re: mworker: seamless reloads broken since 1.8.1

On 05/01/2018 16:44, William Lallemand wrote: > I'm able to reproduce, looks like it happens with the nbthread parameter only, Exact, I observe the same. At least I have a workaround for now to perform the upgrade. > I'll try to find the problem in the code. > Thanks ! Pierre

Re: mworker: seamless reloads broken since 1.8.1

On Fri, Jan 05, 2018 at 03:52:22PM +0100, Pierre Cheynier wrote: > OK so now that I've applied all of Lukas recos (I kept the -x added ) : > > * I don't see any ALERT log anymore.. Only the WARNs > I'm still seing a few of them in journalctl. Maybe you don't see those emitted by the workers,

Re: mworker: seamless reloads broken since 1.8.1

>> Hi, >> >>> Your systemd configuration is not uptodate. >>> >>> Please: >>> - make sure haproxy is compiled with USE_SYSTEMD=1 >>> - update the unit file: start haproxy with -Ws instead of -W (ExecStart) >>> - update the unit file: use Type=notify instead of Type=forking >> In fact that should

Re: mworker: seamless reloads broken since 1.8.1

> Hi, > >>> $ cat /usr/lib/systemd/system/haproxy.service >>> [Unit] >>> Description=HAProxy Load Balancer >>> After=syslog.target network.target >>> >>> [Service] >>> EnvironmentFile=/etc/sysconfig/haproxy >>> ExecStartPre=/usr/sbin/haproxy -f $CONFIG -c -q >>> ExecStart=/usr/sbin/haproxy -W -f

Re: mworker: seamless reloads broken since 1.8.1

Hi, > > $ cat /usr/lib/systemd/system/haproxy.service > > [Unit] > > Description=HAProxy Load Balancer > > After=syslog.target network.target > > > > [Service] > > EnvironmentFile=/etc/sysconfig/haproxy > > ExecStartPre=/usr/sbin/haproxy -f $CONFIG -c -q > > ExecStart=/usr/sbin/haproxy -W -f

Re: mworker: seamless reloads broken since 1.8.1

Hello Pierre, On Fri, Jan 5, 2018 at 11:48 AM, Pierre Cheynier wrote: > Hi list, > > We've recently tried to upgrade from 1.8.0 to 1.8.1, then 1.8.2, 1.8.3 > on a preprod environment and noticed that the reload is not so seamless > since 1.8.1 (easily getting TCP RSTs

mworker: seamless reloads broken since 1.8.1

Hi list, We've recently tried to upgrade from 1.8.0 to 1.8.1, then 1.8.2, 1.8.3 on a preprod environment and noticed that the reload is not so seamless since 1.8.1 (easily getting TCP RSTs while reloading). Having a short look on the haproxy-1.8 git remote on the changes affecting haproxy.c,