Re: segfault writing to log from Lua

2015-10-01 Thread Willy Tarreau
On Thu, Oct 01, 2015 at 11:29:38AM -0400, Michael Ezzell wrote: > Thank you for the patch. > > This does appear to resolve the issue. Great, thanks for the quick patch and for testing! I've just merged it. When I'm seeing how much cleaner the logging chain becomes with vectors, I wish we'd down t

Re: segfault writing to log from Lua

2015-10-01 Thread Michael Ezzell
Thank you for the patch. This does appear to resolve the issue. On Thu, Oct 1, 2015 at 8:11 AM, Dragan Dosen wrote: > Hi all, > > On 29.09.2015 19:31, Willy Tarreau wrote: > >> > >> Maybe, we should build a defaults strings (one for each rfc) at the > >> start of haproxy, and uses these default

Re: segfault writing to log from Lua

2015-10-01 Thread Dragan Dosen
t;From 7c9ed80a2979cfbb1860330393915dafccc617aa Mon Sep 17 00:00:00 2001 From: Dragan Dosen Date: Thu, 1 Oct 2015 13:18:13 +0200 Subject: [PATCH] BUG/MEDIUM: logs: segfault writing to log from Lua Michael Ezzell reported a bug causing haproxy to segfault during startup when trying to send syslog messa

Re: segfault writing to log from Lua

2015-09-29 Thread Willy Tarreau
On Tue, Sep 29, 2015 at 02:01:59PM +0200, Thierry FOURNIER wrote: > Michael, thank you for the bug repport. I reproduce it. > > It is introduced with the support of the RFC5424 for the logs format > sublitted by dragan. > > Hi Dragan, after your patch about the RFC5424, the funcion __send_log() >

Re: segfault writing to log from Lua

2015-09-29 Thread Dragan Dosen
Hi, Thank you for reporting this bug. I'll fix it as soon as possible. Best regards, Dragan Dosen On 29.09.2015 14:01, Thierry FOURNIER wrote: > Michael, thank you for the bug repport. I reproduce it. > > It is introduced with the support of the RFC5424 for the logs format > sublitted by drag

Re: segfault writing to log from Lua

2015-09-29 Thread Thierry FOURNIER
ps: a temporary workaround waiting for the fix, is to add the following line at the start of the first loaded lua script. core.Alert = function(msg) print(msg) end Thierry On Tue, 29 Sep 2015 07:37:12 -0400 Michael Ezzell wrote: > Although I am seeing this in Lua, it does not appear (to me

Re: segfault writing to log from Lua

2015-09-29 Thread Thierry FOURNIER
Michael, thank you for the bug repport. I reproduce it. It is introduced with the support of the RFC5424 for the logs format sublitted by dragan. Hi Dragan, after your patch about the RFC5424, the funcion __send_log() no longer support NULL for the "*p" param. Can you fix this ? It seems that th

Re: segfault writing to log from Lua

2015-09-29 Thread Michael Ezzell
Although I am seeing this in Lua, it does not appear (to me) to a the fault in the Lua code... recent changes in __send_log() in log.c appear to assume p is never null (there's a test for this condition earlier, then p is referenced later), and that is not valid behavior in this case, because there

Re: segfault writing to log from Lua

2015-09-29 Thread Michael Ezzell
This a clean build, on both systems, using a freshly-extracted tarball of 1.6-dev6 downloaded from http://www.haproxy.org/download/1.6/src/devel/haproxy-1.6-dev6.tar.gz. I'll recheck and send files to replicate. On Sep 29, 2015 4:47 AM, "Thierry FOURNIER" wrote: > On Mon, 28 Sep 2015 20:50:44 -0

Re: segfault writing to log from Lua

2015-09-29 Thread Thierry FOURNIER
On Mon, 28 Sep 2015 20:50:44 -0400 Michael Ezzell wrote: > I fired up HA-Proxy version 1.6-dev6-e7ae656 2015/09/28 for testing, and > was greeted with... > > Segmentation fault (core dumped) > > Since I've been primarily testing Lua, I started by commenting out my Lua > config lines. Startup s

segfault writing to log from Lua

2015-09-28 Thread Michael Ezzell
I fired up HA-Proxy version 1.6-dev6-e7ae656 2015/09/28 for testing, and was greeted with... Segmentation fault (core dumped) Since I've been primarily testing Lua, I started by commenting out my Lua config lines. Startup succeeds. Re-enabling the scripts, I find this to be the offending line: