Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-06 Thread Willy Tarreau
Hi Robin, On Fri, Apr 06, 2018 at 03:52:33PM +0200, Robin Geuze wrote: > Hey Willy, > > I was actually the one that had the hunch to disable compression. I > suspected that this was the issue because there was a bunch of "abort" calls > in include/common/hathreads.h" which is used by the

[ANNOUNCE] haproxy-1.8.7

2018-04-06 Thread Willy Tarreau
Subject: [ANNOUNCE] haproxy-1.8.7 To: haproxy@formilux.org Hi, HAProxy 1.8.7 was released on 2018/04/07. It added 2 new commits after version 1.8.6. I know it's very short after 1.8.6, but Thierry found that the cache issue would still occasionally strike so I really wanted to knock it down

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
Hi Lukas, On Fri, Apr 06, 2018 at 12:33:14PM +0200, Lukas Tribus wrote: > On 6 April 2018 at 11:14, Willy Tarreau wrote: > >> I don't think we need a new config know. > > > > Just thinking, is the goal *not to have to* configure "resolve" on > > server lines in this case, or to

Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-06 Thread Willy Tarreau
Hi Frank, On Fri, Apr 06, 2018 at 10:53:36AM +, Frank Schreuder wrote: > We tested haproxy 1.8.6 with compression enabled today, within the first few > hours it already went wrong: > [ALERT] 095/120526 (12989) : Current worker 5241 exited with code 134 OK thanks, and sorry for that. > Our

format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
Hello, please review the attached patch Ilya Shipitsin From a7f2e5a064c40a5842decc7e053a6e4a4291df33 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 6 Apr 2018 17:06:10 +0500 Subject: [PATCH] MINOR: format warnings cleanup issue detected by cppcheck

Re: format warning cleanup (patch attached)

2018-04-06 Thread Willy Tarreau
Hi Ilya, On Fri, Apr 06, 2018 at 05:08:20PM +0500, ??? wrote: > Hello, > > please review the attached patch thank you, but in the future, you should definitely split that into several patches when it touches different areas since different people will be involved. For halog and hpack I

Re: format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
well, I was not sure whether to split into several files or not. ok, will split next time :) 2018-04-06 17:32 GMT+05:00 Willy Tarreau : > Hi Ilya, > > On Fri, Apr 06, 2018 at 05:08:20PM +0500, ??? wrote: > > Hello, > > > > please review the attached patch > > thank you,

Re: DNS resolver and mixed case responses

2018-04-06 Thread Dennis Jacobfeuerborn
On 04.04.2018 16:30, Tim Düsterhus wrote: > Dale, > > Am 03.04.2018 um 16:17 schrieb Dale Smith: >> I'm trying to understand what system is at fault here; the DNS server for >> not responding with the same case as the query, or HAProxy which >> should be >> performing a case insensitive match. >

Why is it that the summary line of the backend at the bottom says limit 1?

2018-04-06 Thread Pieter Vogelaar
Hi, I use a configuration with global maxconn 8000 and defaults maxconn 8000. This affects the frontends. On the stats page I see the servers of backend have a “-” in the limit field. Which means there is no limit. But why is it that the summary line of the backend at the bottom says limit 1?

Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-06 Thread Frank Schreuder
Hi Willy, >> There are very few abort() calls in the code : >>   - some in the thread debugging code to detect recursive locks ; >>   - one in the cache applet which triggers on an impossible case very >>     likely resulting from cache corruption (hence a bug) >>   - a

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Lukas Tribus
Hi Willy, On 6 April 2018 at 11:14, Willy Tarreau wrote: >> I don't think we need a new config know. > > Just thinking, is the goal *not to have to* configure "resolve" on > server lines in this case, or to avoid having to pre-configure the > resolvers themselves when they're the

Re: No enabled listener found and reloads triggered an inconsistent state.

2018-04-06 Thread Willy Tarreau
Hi Pierre, On Wed, Apr 04, 2018 at 08:12:50AM +, Pierre Cheynier wrote: > Hi there, > > We had an issue recently, using 1.8.5. For some reason we ended up entering > in the "No enabled listener found" state (I guess the config file was > incomplete, being written at that time, something like

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
Hi guys, On Wed, Apr 04, 2018 at 12:32:41PM +0200, Lukas Tribus wrote: > Hello Baptiste, > > > > - (for Lukas) what do you think is better, a configuration option to trigger > > parsing of resolv.conf or as proposed, if no nameserver are found, we use > > resolv.conf as a failback? > > > I

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

2018-04-06 Thread Willy Tarreau
Hi Aurélien, I finally found some time to review your patch, really sorry for the long delay, but bug fixing passes first when they are sensitive :-/ On Sat, Mar 24, 2018 at 11:16:03PM +0100, Aurélien Nephtali wrote: > From 53356f83dab6483512d2db1fae87abd24beca4c0 Mon Sep 17 00:00:00 2001 >

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

2018-04-06 Thread Aurélien Nephtali
Hello Willy, On Fri, Apr 6, 2018 at 12:02 PM, Willy Tarreau wrote: > > Hi Aurélien, > > I finally found some time to review your patch, really sorry for the > long delay, but bug fixing passes first when they are sensitive :-/ No problem. Adding features over fixing bugs would be

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
On Fri, Apr 06, 2018 at 04:50:54PM +0200, Lukas Tribus wrote: > > Well, sometimes when you're debugging a configuration, it's nice to be > > able to disable some elements. Same for those manipulating/building > > configs by assembling elements and iteratively pass them through > > "haproxy -c".

Re: [PATCH] MEDIUM: cli: Add multi-line mode support

2018-04-06 Thread Willy Tarreau
On Fri, Apr 06, 2018 at 03:59:59PM +0200, Aurélien Nephtali wrote: > I tried to be the less intrusive as > possible into the CLI parser so I tried to reuse what was already > done. > Maybe that's not the best approach but with all the legacy behind I > REALLY didn't want to break something, even

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Lukas Tribus
Hello Willy, On 6 April 2018 at 14:14, Willy Tarreau wrote: >> The confusion often arises because haproxy accepts a resolver >> configuration where no resolvers are configured. Maybe we should >> reject the configuration when a resolver is referred to in the servers >> lines, but

Re: Cookies, load balancing, stick tables.

2018-04-06 Thread Moemen MHEDHBI
Hi Franks, On 28/03/2018 14:11, Franks Andy (IT Technical Architecture Manager) wrote: > > Hi all, > >   Hopefully an easy one, but I can’t really find the solution. > > We’ve come up with a control system for haproxy, where we manually can > clear stick table entries from a GUI. We’re also

Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-06 Thread Robin Geuze
Hey Willy, I was actually the one that had the hunch to disable compression. I suspected that this was the issue because there was a bunch of "abort" calls in include/common/hathreads.h" which is used by the compression stuff. However I just noticed those aborts are actually only there if

Re: Segfault on haproxy 1.7.10 with state file and slowstart

2018-04-06 Thread Willy Tarreau
Hi Raghu, On Wed, Mar 28, 2018 at 08:30:39PM +, Raghu Udiyar wrote: > Hi Willy, Baptiste > > It looks like this was the intended behaviour as per the documentation. But > it looks to be simple to enable the init-addr behaviour for IP addresses as > well. Can you please review the attached

Re: Fix building haproxy 1.8.5 with LibreSSL 2.6.4

2018-04-06 Thread Willy Tarreau
Hi Andy, On Sat, Mar 31, 2018 at 05:43:55PM +0300, Andy Postnikov wrote: > I used to rework previous patch from Alpinelinux to build with latest > stable libressl > But found no way to run tests with openssl which is primary library as I see > Is it possible to accept the patch upstream or get

Re: [PATCH] server-template and allowed chars in the name

2018-04-06 Thread Willy Tarreau
On Mon, Mar 26, 2018 at 03:42:32PM +0200, Frederic Lecaille wrote: > I have no objection to accept your patch (have a look to the comments). OK now merged, thanks guys. Willy