Re: [PATCH] documentation typo fixes

2020-03-06 Thread Илья Шипицин
пт, 6 мар. 2020 г. в 14:50, Willy Tarreau : > On Fri, Mar 06, 2020 at 01:09:54PM +0500, ??? wrote: > > Hello, > > > > ongoing typo fixes. > > Thanks Ilya. I re-tagged "DOC" so that we don't forget to consider > it for backporting, eventhough the parts on the makefile can be > dropped

Re: [PATCH] documentation typo fixes

2020-03-06 Thread Илья Шипицин
as for stable branches, I can run spell check for every branch and send appropriate PR for every branch. would it be better compared to backporting ? пт, 6 мар. 2020 г. в 14:50, Willy Tarreau : > On Fri, Mar 06, 2020 at 01:09:54PM +0500, ??? wrote: > > Hello, > > > > ongoing typo

[PATCH] documentation typo fixes

2020-03-06 Thread Илья Шипицин
Hello, ongoing typo fixes. Cheers, Ilya Shipitcin From c3cd13340c961a62a78b2db924aabf594f2508a4 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 6 Mar 2020 13:07:38 +0500 Subject: [PATCH] CLEANUP: fix documentation typos --- CONTRIBUTING | 4 ++-- INSTALL

Re: maxconn default from 1.7 to 2.0

2020-03-06 Thread Willy Tarreau
On Fri, Mar 06, 2020 at 08:38:19AM +0100, Willy Tarreau wrote: > Could you try the current patch ? For me as an unprivileged user, it > raises my default maxconn from 488 to 2024 since I'm running with > 1024/4096: > > diff --git a/src/haproxy.c b/src/haproxy.c > index 759612dfd8..c7905a52e4

Re: [PATCH] documentation typo fixes

2020-03-06 Thread Willy Tarreau
On Fri, Mar 06, 2020 at 01:09:54PM +0500, ??? wrote: > Hello, > > ongoing typo fixes. Thanks Ilya. I re-tagged "DOC" so that we don't forget to consider it for backporting, eventhough the parts on the makefile can be dropped from backports if they cause trouble. Willy

Re: [PR] Add missing string length for lua sticktable lookup

2020-03-06 Thread Willy Tarreau
Hello Nathan, On Wed, Mar 04, 2020 at 04:23:09AM +0100, PR Bot wrote: > Description: >Consider moving this to smp_to_stkey - or at least adding a: >```if ( smp->data.u.str.data == 0 ) { static_table_key.key_len = >strlen(smp->data.u.str.key); }``` > >equivalent to smp_to_stkey

Re: [PATCH] documentation typo fixes

2020-03-06 Thread Willy Tarreau
On Fri, Mar 06, 2020 at 03:19:07PM +0500, ??? wrote: > that's nice point to fix speling in earlier documentation as well. > > > side question, when some version become "unsupported", has its > documentation also retired in some sense ? > for example "here should be documentation for

Re: [PATCH] documentation typo fixes

2020-03-06 Thread Willy Tarreau
On Fri, Mar 06, 2020 at 03:21:57PM +0500, ??? wrote: > as for stable branches, I can run spell check for every branch and send > appropriate PR for every branch. > > would it be better compared to backporting ? No, it would be a pain as it will conflict with the backporting process. If

[PATCH 2/3] MINOR: proxy_protocol: Ingest PP2_TYPE_UNIQUE_ID on incoming connections

2020-03-06 Thread Tim Duesterhus
Willy, while my primary motivation of this series is to *send* the unique ID, instead of *receiving* it the patch to receive it comes first, because it's super straight forward. I could basically copy the implementation for the authority TLV. For the whole unique ID processing I've used the new

[PATCH 3/3] MEDIUM: proxy_protocol: Support sending unique IDs using PPv2

2020-03-06 Thread Tim Duesterhus
Willy, this patch adds the sending of generated unique IDs using PROXYv2. I'm not sure whether the way I made the stream available in the proxy line sending is acceptable. There's also a `BUG_ON` left in the patch, because I wasn't sure if I should grab the session from the stream or from the

[PATCH 1/3] DOC: proxy_protocol: Reserve TLV type 0x05 as PP2_TYPE_UNIQUE_ID

2020-03-06 Thread Tim Duesterhus
Willy, this one should be fairly obvious: It reserves TLV type 0x05 to contain a unique ID within the PROXYv2 definition and also defines the type within HAProxy source code. Best regards Tim Düsterhus Apply with `git am --scissors` to automatically cut the commit message. -- >8 -- This

[PATCH 0/3] Unique ID for PROXYv2

2020-03-06 Thread Tim Duesterhus
Willy, this series adds support for sending and receiving unique IDs using PROXYv2. I've added specific comments about the patches within the other emails. Best regards Tim Düsterhus Tim Duesterhus (3): DOC: proxy_protocol: Reserve TLV type 0x05 as PP2_TYPE_UNIQUE_ID MINOR: proxy_protocol:

[PATCH] MINOR: ssl: skip self issued CA in cert chain for ssl_ctx

2020-03-06 Thread Emmanuel Hocdet
Hi, Patch proposal. I will update the documentation if this feature is approved. ++ Manu 0001-MINOR-ssl-skip-self-issued-CA-in-cert-chain-for-ssl_.patch Description: Binary data

Re: Segfault on 2.1.3

2020-03-06 Thread Sean Reifschneider
Here's what the stack traces look like, they all seem to be showing "pattern_exec_match" and "epool_wait": PID: 14348 (haproxy) UID: 0 (root) GID: 0 (root) Signal: 11 (SEGV) Timestamp: Thu 2020-03-05 19:59:05 MST (14h ago) Command Line:

[PATCH] 3rd round of documentation typo fixes

2020-03-06 Thread Илья Шипицин
Hello, I attached a patch based on documentation spelcheck. Cheers, Ilya Shipitcin From ad38d6c0819df867524338a55ac51b3ed8e510be Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 6 Mar 2020 23:22:22 +0500 Subject: [PATCH] DOC: assorted typo fixes in the documentation This is the third